From patchwork Thu Nov 13 05:26:53 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 40707 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-la0-f69.google.com (mail-la0-f69.google.com [209.85.215.69]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 9E94024493 for ; Thu, 13 Nov 2014 05:27:29 +0000 (UTC) Received: by mail-la0-f69.google.com with SMTP id q1sf8558139lam.8 for ; Wed, 12 Nov 2014 21:27:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:mime-version:in-reply-to:references :date:message-id:subject:from:to:cc:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe:content-type; bh=pC4jogAwaWZK7/A4bEa8Yrch2TLMhoH0N+teAtOmhJU=; b=TJI9XX/fF1Kt4DouA/bJmiE0g2fp61g7RRXEw8J5Qhu7WnRY5LuSGV1SSKkN3OZCv5 QG4dtc5ubguv8NRYM+oq3sXFQUcj53aI20DUo5+ciw6XFh1J5izhyR2IOfQFoQYWXi7Y Yzfr/Lzye7J7MRH84KoyUB5y4ew46AUkqr2uABIiGlvxaX715416yME2sDYv+aHzyJoW fqCBfXEgJ9O97643k4ajisjm12yO2DtcREwvAPvPymkC6E49pUsrEjw7nScPtWNVEDjk /SsGzoYpIc7PiHdVgnD+LBDrvLQM8w3SYtz12MKW4WcNn6h+ZdtiSnqsV/lT6iCFJ0gp MEzA== X-Gm-Message-State: ALoCoQnJc9UqliUJdMj7YE0eSvPY3sKgq/bn6DMWbt2b66rfpEomstbcVsSskhcM1jLMsp7v/JHL X-Received: by 10.152.37.37 with SMTP id v5mr4018laj.9.1415856448542; Wed, 12 Nov 2014 21:27:28 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.88.99 with SMTP id bf3ls78092lab.13.gmail; Wed, 12 Nov 2014 21:27:28 -0800 (PST) X-Received: by 10.112.87.65 with SMTP id v1mr272939lbz.12.1415856448207; Wed, 12 Nov 2014 21:27:28 -0800 (PST) Received: from mail-la0-f49.google.com (mail-la0-f49.google.com. [209.85.215.49]) by mx.google.com with ESMTPS id r5si37227467lal.3.2014.11.12.21.27.28 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 12 Nov 2014 21:27:28 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.49 as permitted sender) client-ip=209.85.215.49; Received: by mail-la0-f49.google.com with SMTP id ge10so12667035lab.36 for ; Wed, 12 Nov 2014 21:27:28 -0800 (PST) X-Received: by 10.152.2.41 with SMTP id 9mr169771lar.47.1415856448026; Wed, 12 Nov 2014 21:27:28 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.184.201 with SMTP id ew9csp539895lbc; Wed, 12 Nov 2014 21:27:27 -0800 (PST) X-Received: by 10.68.57.239 with SMTP id l15mr221415pbq.3.1415856446074; Wed, 12 Nov 2014 21:27:26 -0800 (PST) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ks5si24771869pdb.42.2014.11.12.21.26.56 for ; Wed, 12 Nov 2014 21:27:26 -0800 (PST) Received-SPF: none (google.com: linux-pm-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753654AbaKMF0z (ORCPT + 12 others); Thu, 13 Nov 2014 00:26:55 -0500 Received: from mail-qa0-f44.google.com ([209.85.216.44]:47947 "EHLO mail-qa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753635AbaKMF0y (ORCPT ); Thu, 13 Nov 2014 00:26:54 -0500 Received: by mail-qa0-f44.google.com with SMTP id v10so339821qac.3 for ; Wed, 12 Nov 2014 21:26:54 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.224.25.208 with SMTP id a16mr247521qac.41.1415856414154; Wed, 12 Nov 2014 21:26:54 -0800 (PST) Received: by 10.96.211.137 with HTTP; Wed, 12 Nov 2014 21:26:53 -0800 (PST) In-Reply-To: <1415843008.15957.45.camel@freescale.com> References: <92d6fb45a43b8d800cbcdf690bbf6f8e4713b95e.1415765396.git.viresh.kumar@linaro.org> <2888462.gyjhHfUy7m@vostro.rjw.lan> <1415843008.15957.45.camel@freescale.com> Date: Thu, 13 Nov 2014 10:56:53 +0530 Message-ID: Subject: Re: [PATCH] cpufreq: Remove architecture specific menu entries From: Viresh Kumar To: Scott Wood Cc: "Rafael J. Wysocki" , Lists linaro-kernel , "linux-pm@vger.kernel.org" , Yuantian Tang Sender: linux-pm-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: viresh.kumar@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.49 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , On 13 November 2014 07:13, Scott Wood wrote: > On Thu, 2014-11-13 at 02:47 +0100, Rafael J. Wysocki wrote: >> On Wednesday, November 12, 2014 09:40:43 AM Viresh Kumar wrote: >> > CPUFreq driver's Kconfig entries are added in Kconfig. files and they are >> > all included from the main Kconfig file using a menu entry. This creates another >> > level of (unnecessary) hierarchy within the menuconfig entries. >> > >> > The problem occurs when there are drivers usable across architectures. Either >> > their config entry is duplicated in all the supported architectures or is put >> > into the main Kconfig entry. With the later one, we have menuconfig entries for >> > drivers at two levels then. >> > >> > Fix these issues by getting rid of another level of menuconfig entries and >> > populate all drivers within the main cpufreq menu. >> >> Won't this be confusing? > > Why would it be confusing? It's already in a not-too-large "CPU > Frequency scaling" menu, the names of the individual options should be > clear enough, and they'd all be grouped at the end of the menu. > > FWIW, there's already "Generic DT based cpufreq driver" under that menu. > >> Can we at least have a "CPU frequency scaling drivers" menu for drivers >> the *contents* of which will depend on the architecture? > > That works too -- I just don't see the confusion aspect. After thinking a bit about the concerns raised by both of you, I decided to look at what others are doing about this. And this is the best I came around: And this is how it looks in menuconfig now: [*] CPU Frequency scaling <*> CPU frequency translation statistics (NEW) [ ] CPU frequency translation statistics details (NEW) Default CPUFreq governor (performance) ---> -*- 'performance' governor < > 'powersave' governor (NEW) < > 'userspace' governor for userspace frequency scaling (NEW) < > 'ondemand' cpufreq policy governor (NEW) < > 'conservative' cpufreq governor (NEW) *** CPU frequency scaling drivers *** < > Generic DT based cpufreq driver (NEW) < > Generic ARM big LITTLE CPUfreq driver (NEW) [*] SAMSUNG EXYNOS4210 (NEW) [*] SAMSUNG EXYNOS4x12 (NEW) [*] SAMSUNG EXYNOS5250 (NEW) [*] SAMSUNG EXYNOS5440 (NEW) [ ] EXYNOS Frequency Overclocking - Software (NEW) Good enough ? --- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig index a24d678..230a912 100644 --- a/drivers/cpufreq/Kconfig +++ b/drivers/cpufreq/Kconfig @@ -183,6 +183,8 @@ config CPU_FREQ_GOV_CONSERVATIVE If in doubt, say N. +comment "CPU frequency scaling drivers" + config CPUFREQ_DT tristate "Generic DT based cpufreq driver" depends on HAVE_CLK && OF