From patchwork Mon Feb 17 06:02:55 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 24732 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-pb0-f69.google.com (mail-pb0-f69.google.com [209.85.160.69]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 843732055D for ; Mon, 17 Feb 2014 06:03:11 +0000 (UTC) Received: by mail-pb0-f69.google.com with SMTP id md12sf34533634pbc.4 for ; Sun, 16 Feb 2014 22:03:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:mime-version:in-reply-to:references :date:message-id:subject:from:to:cc:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe:content-type; bh=yT9LaIa7ZJLFUVS5RtOzE0anYTIBYaaPZSPKgI1wQ7c=; b=ciC22pWhK9iTpa+/uL3T4lkvvxds9EuLOGqZf4RtgwK71sRg+AC+nVhB1YwYfVEgOZ L6oAnFZW7fLGbNun8+DhRLKuMdqQheBC7+erC82UC1QGq7TWGFNZFZNAqx28MRwtEPgn xlMnrIVcHBcQKJzjNJJc/OCYmqjudSHEAh5Ntt2T4tFrLZEdCcb+EiPIwpo238dTGuVi rvccVjRG/7mgD3KX6Bo83E8+7CKzOnbJ/E7D4IUWqMnUd7YsRvU2kNvMzkyywbKSy01R BvWJfQ/Xcg7ot0W7RUsik+pvY1uTP3rvqhQTZU8sf1qH9m0Z9K2V6gZ008ksVNi5CAbC 2DkQ== X-Gm-Message-State: ALoCoQmsr9GT8ZYM4Ak4qB3Fbnmqd4vvel1rdiWrQpqAk3esWDgenJd6d3t8rbC/SZtNIirLr/vO X-Received: by 10.66.137.8 with SMTP id qe8mr9619111pab.46.1392616990567; Sun, 16 Feb 2014 22:03:10 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.42.138 with SMTP id c10ls793516qga.63.gmail; Sun, 16 Feb 2014 22:03:10 -0800 (PST) X-Received: by 10.220.92.135 with SMTP id r7mr15810670vcm.11.1392616990439; Sun, 16 Feb 2014 22:03:10 -0800 (PST) Received: from mail-vc0-f172.google.com (mail-vc0-f172.google.com [209.85.220.172]) by mx.google.com with ESMTPS id l16si4270888vcl.51.2014.02.16.22.03.10 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 16 Feb 2014 22:03:10 -0800 (PST) Received-SPF: neutral (google.com: 209.85.220.172 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.172; Received: by mail-vc0-f172.google.com with SMTP id lf12so11459770vcb.3 for ; Sun, 16 Feb 2014 22:03:10 -0800 (PST) X-Received: by 10.52.171.39 with SMTP id ar7mr13194288vdc.5.1392616990357; Sun, 16 Feb 2014 22:03:10 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.174.196 with SMTP id u4csp112891vcz; Sun, 16 Feb 2014 22:03:09 -0800 (PST) X-Received: by 10.68.197.8 with SMTP id iq8mr24310395pbc.124.1392616989437; Sun, 16 Feb 2014 22:03:09 -0800 (PST) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id pp3si12602298pbb.49.2014.02.16.22.03.06; Sun, 16 Feb 2014 22:03:06 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752492AbaBQGDA (ORCPT + 27 others); Mon, 17 Feb 2014 01:03:00 -0500 Received: from mail-ob0-f179.google.com ([209.85.214.179]:58757 "EHLO mail-ob0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752129AbaBQGC4 (ORCPT ); Mon, 17 Feb 2014 01:02:56 -0500 Received: by mail-ob0-f179.google.com with SMTP id wo20so16618541obc.10 for ; Sun, 16 Feb 2014 22:02:56 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.60.132.234 with SMTP id ox10mr18833580oeb.17.1392616975369; Sun, 16 Feb 2014 22:02:55 -0800 (PST) Received: by 10.182.28.168 with HTTP; Sun, 16 Feb 2014 22:02:55 -0800 (PST) In-Reply-To: <52FE7AFD.2040203@wwwdotorg.org> References: <52FE71BD.3020103@wwwdotorg.org> <52FE7AFD.2040203@wwwdotorg.org> Date: Mon, 17 Feb 2014 11:32:55 +0530 Message-ID: Subject: Re: [PATCH V5 0/7] cpufreq: suspend early/resume late: dpm_{suspend|resume}() From: Viresh Kumar To: Stephen Warren Cc: "Rafael J. Wysocki" , Lists linaro-kernel , "cpufreq@vger.kernel.org" , "linux-pm@vger.kernel.org" , Linux Kernel Mailing List , Nishanth Menon , Kgene Kim , jinchoi@broadcom.com, Lan Tianyu , Sebastian Capella , Jonghwan Choi Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: viresh.kumar@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.172 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , On 15 February 2014 01:52, Stephen Warren wrote: > BTW, I also happened to test these on a Tegra114 system, on which there > is no cpufreq driver, and this series (applied on top of commit > 9398a10cd964 Merge tag 'regulator-v3.14-rc2') causes the following > during suspend: Ahh, that's a obvious bug. Following would fix it, thanks: the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index c13c100..2dfbb7e 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c @@ -1617,6 +1617,9 @@ void cpufreq_suspend(void) { struct cpufreq_policy *policy; + if (!cpufreq_driver) + return; + if (!has_target()) return; @@ -1645,6 +1648,9 @@ void cpufreq_resume(void) { struct cpufreq_policy *policy; + if (!cpufreq_driver) + return; + if (!has_target()) return; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in