From patchwork Sat Sep 26 22:04:06 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 54185 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wi0-f199.google.com (mail-wi0-f199.google.com [209.85.212.199]) by patches.linaro.org (Postfix) with ESMTPS id 1991D22E7B for ; Sat, 26 Sep 2015 22:04:51 +0000 (UTC) Received: by wisv5 with SMTP id v5sf23134432wis.0 for ; Sat, 26 Sep 2015 15:04:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe; bh=a+mXGHVKKp4wLzI1RDmoL15IkO7cHfDYCV/PCiBthE8=; b=alKFQc5HxQrIrpHrkJSjZdMXlz1bpHZ3HpuCMyjUE4bZWUMwnrLuoWNL1KXFDsPNBk 5uVbFZMFRsSytLpE6OvsOOVuKXCnk+6XkHXx1UtamR5lZ0BRAXSpGLc1N5FETrO+f5RF quKN5qdHTkGzWz3vX9oXZCAammARK+kfUHgI4+7Nhl8T4rsgvoKvlfhUyihGbnYkZM30 UPAmXnpvlj8kgE7PLTqyzh5epiUB0bVhtj8jAziFrLxodLSqoY4JxvNqlaJgVt2ArZWV QiYYV9vg6kU6ZJbDb49t0jLBCCRBFDlmRafvQIN8oXcbdF4dkdxq9JtSOxXmb+PE0nav zALQ== X-Gm-Message-State: ALoCoQkzObnl4yubMrkoguzT/FWCEwclbp1iI39KPNbLUpkwxJA/IOdfugyspkCI5vDUB6sPBWuQ X-Received: by 10.180.105.98 with SMTP id gl2mr1605536wib.0.1443305090376; Sat, 26 Sep 2015 15:04:50 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.23.1 with SMTP id i1ls160816laf.105.gmail; Sat, 26 Sep 2015 15:04:50 -0700 (PDT) X-Received: by 10.112.132.1 with SMTP id oq1mr3425030lbb.108.1443305090057; Sat, 26 Sep 2015 15:04:50 -0700 (PDT) Received: from mail-la0-f45.google.com (mail-la0-f45.google.com. [209.85.215.45]) by mx.google.com with ESMTPS id d79si4607037lfe.74.2015.09.26.15.04.50 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 26 Sep 2015 15:04:50 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.45 as permitted sender) client-ip=209.85.215.45; Received: by laclj5 with SMTP id lj5so33681014lac.3 for ; Sat, 26 Sep 2015 15:04:50 -0700 (PDT) X-Received: by 10.112.61.194 with SMTP id s2mr2431679lbr.29.1443305089952; Sat, 26 Sep 2015 15:04:49 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.59.35 with SMTP id w3csp761331lbq; Sat, 26 Sep 2015 15:04:48 -0700 (PDT) X-Received: by 10.66.163.136 with SMTP id yi8mr16546195pab.124.1443305088860; Sat, 26 Sep 2015 15:04:48 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id tp2si15461326pbc.123.2015.09.26.15.04.48; Sat, 26 Sep 2015 15:04:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932610AbbIZWEq (ORCPT + 30 others); Sat, 26 Sep 2015 18:04:46 -0400 Received: from mail-pa0-f54.google.com ([209.85.220.54]:35197 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932311AbbIZWEm (ORCPT ); Sat, 26 Sep 2015 18:04:42 -0400 Received: by pacfv12 with SMTP id fv12so140492133pac.2 for ; Sat, 26 Sep 2015 15:04:41 -0700 (PDT) X-Received: by 10.68.191.200 with SMTP id ha8mr16768041pbc.72.1443305081197; Sat, 26 Sep 2015 15:04:41 -0700 (PDT) Received: from localhost (c-67-169-81-235.hsd1.ca.comcast.net. [67.169.81.235]) by smtp.gmail.com with ESMTPSA id qy5sm10933604pbb.16.2015.09.26.15.04.40 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sat, 26 Sep 2015 15:04:40 -0700 (PDT) From: Viresh Kumar To: Greg Kroah-Hartman Cc: linaro-kernel@lists.linaro.org, QCA ath9k Development , Intel Linux Wireless , Viresh Kumar , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, linux-bluetooth@vger.kernel.org, iommu@lists.linux-foundation.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-scsi@vger.kernel.org, linux-usb@vger.kernel.org, linux-edac@vger.kernel.org, linux-mm@kvack.org, alsa-devel@alsa-project.org Subject: [PATCH V5 1/2] ACPI / EC: Fix broken 64bit big-endian users of 'global_lock' Date: Sat, 26 Sep 2015 15:04:06 -0700 Message-Id: <8d3d3428c3a36f821e4c3d8563d094ca4b4763fd.1443304934.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.4.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: viresh.kumar@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.45 as permitted sender) smtp.mailfrom=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , global_lock is defined as an unsigned long and accessing only its lower 32 bits from sysfs is incorrect, as we need to consider other 32 bits for big endian 64-bit systems. There are no such platforms yet, but the code needs to be robust for such a case. Fix that by changing type of 'global_lock' to u32. Signed-off-by: Viresh Kumar --- BCC'd a lot of people (rather than cc'ing them) to make sure - the series reaches them - mailing lists do not block the patchset due to long cc list - and we don't spam the BCC'd people for every reply V4->V5: - Switch back to the original solution of making global_lock u32. --- drivers/acpi/ec_sys.c | 2 +- drivers/acpi/internal.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/acpi/ec_sys.c b/drivers/acpi/ec_sys.c index b4c216bab22b..bea8e425a8de 100644 --- a/drivers/acpi/ec_sys.c +++ b/drivers/acpi/ec_sys.c @@ -128,7 +128,7 @@ static int acpi_ec_add_debugfs(struct acpi_ec *ec, unsigned int ec_device_count) if (!debugfs_create_x32("gpe", 0444, dev_dir, (u32 *)&first_ec->gpe)) goto error; if (!debugfs_create_bool("use_global_lock", 0444, dev_dir, - (u32 *)&first_ec->global_lock)) + &first_ec->global_lock)) goto error; if (write_support) diff --git a/drivers/acpi/internal.h b/drivers/acpi/internal.h index 9e426210c2a8..9db196de003c 100644 --- a/drivers/acpi/internal.h +++ b/drivers/acpi/internal.h @@ -138,7 +138,7 @@ struct acpi_ec { unsigned long gpe; unsigned long command_addr; unsigned long data_addr; - unsigned long global_lock; + u32 global_lock; unsigned long flags; unsigned long reference_count; struct mutex mutex;