From patchwork Thu Jun 11 10:51:53 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 49747 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-lb0-f198.google.com (mail-lb0-f198.google.com [209.85.217.198]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 481E320C81 for ; Thu, 11 Jun 2015 10:53:06 +0000 (UTC) Received: by lbcue7 with SMTP id ue7sf973680lbc.3 for ; Thu, 11 Jun 2015 03:53:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:in-reply-to:references :sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe; bh=Q5j2unH/JF4eyIIXQ4vc5UL5HKV2CJNh5yckvXEqZvI=; b=M+opTL9eqOyYyhZdq0aGFnY/vXWlxV0wnPYLXtq+dGFaI83Oxfg/C4sWObTx7K1QZm SZo+OQ9Ygr6u9hfsFmtYt0gpippFZmp/UdkLeCuBP6fKEETy0fdesCYlVaG2CvXi3+Kf TJ8JqQgIALnEU50fY8qn7XdJZjQNteeEuDEmM1i0ZrmV9ZlVJS+eJjgvoeiZ/TFThrae 0STLnDwDWX1UmBy+8f0bkgWrzGgALtc26M7AHR8NOsoMUGwA6pMLN2oDI6l/arzQvbt0 7qUhbpofhfsWwSF3GgXpjZbYYF+8lWOFGit+sqeDxflQ5vUdC1uxIbYrANwxKT6WYJPv h+Dw== X-Gm-Message-State: ALoCoQmqoruq8yn+0q83R+cH5WAtdBIFDCewmH++FBkKWghuYKvCBJMuE3pCqFXAOvxAdYsBYITu X-Received: by 10.112.142.67 with SMTP id ru3mr7878404lbb.1.1434019985181; Thu, 11 Jun 2015 03:53:05 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.224.162 with SMTP id rd2ls360123lac.84.gmail; Thu, 11 Jun 2015 03:53:05 -0700 (PDT) X-Received: by 10.152.25.198 with SMTP id e6mr9129439lag.83.1434019985026; Thu, 11 Jun 2015 03:53:05 -0700 (PDT) Received: from mail-la0-f47.google.com (mail-la0-f47.google.com. [209.85.215.47]) by mx.google.com with ESMTPS id kd4si271777lbc.42.2015.06.11.03.53.05 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 11 Jun 2015 03:53:05 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.47 as permitted sender) client-ip=209.85.215.47; Received: by labke4 with SMTP id ke4so2466934lab.0 for ; Thu, 11 Jun 2015 03:53:05 -0700 (PDT) X-Received: by 10.112.219.70 with SMTP id pm6mr9000372lbc.41.1434019984904; Thu, 11 Jun 2015 03:53:04 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.108.230 with SMTP id hn6csp3952681lbb; Thu, 11 Jun 2015 03:53:03 -0700 (PDT) X-Received: by 10.68.190.8 with SMTP id gm8mr13882246pbc.30.1434019974497; Thu, 11 Jun 2015 03:52:54 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id xz3si375664pab.181.2015.06.11.03.52.53; Thu, 11 Jun 2015 03:52:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752735AbbFKKwx (ORCPT + 11 others); Thu, 11 Jun 2015 06:52:53 -0400 Received: from mail-pa0-f46.google.com ([209.85.220.46]:36808 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752680AbbFKKww (ORCPT ); Thu, 11 Jun 2015 06:52:52 -0400 Received: by pabqy3 with SMTP id qy3so2227267pab.3 for ; Thu, 11 Jun 2015 03:52:52 -0700 (PDT) X-Received: by 10.70.43.10 with SMTP id s10mr13950568pdl.57.1434019972052; Thu, 11 Jun 2015 03:52:52 -0700 (PDT) Received: from localhost ([122.167.219.251]) by mx.google.com with ESMTPSA id ni1sm402180pdb.32.2015.06.11.03.52.50 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 11 Jun 2015 03:52:51 -0700 (PDT) From: Viresh Kumar To: Rafael Wysocki , Preeti U Murthy , ke.wang@spreadtrum.com Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, ego@linux.vnet.ibm.com, paulus@samba.org, shilpa.bhat@linux.vnet.ibm.com, prarit@redhat.com, robert.schoene@tu-dresden.de, skannan@codeaurora.org, Viresh Kumar Subject: [PATCH 10/12] cpufreq: governor: Don't WARN on invalid states Date: Thu, 11 Jun 2015 16:21:53 +0530 Message-Id: <70b94233535af5a1fa391f3199ef8915b40fb7b7.1434019473.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.4.0 In-Reply-To: References: In-Reply-To: References: Sender: linux-pm-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: viresh.kumar@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.47 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , The last commit returned errors on invalid state requests for a governor. But we are already issuing a WARN for an invalid state in cpufreq_governor_dbs(). Lets stop warning on that until the time cpufreq core is fixed to serialize state changes of the governor. Signed-off-by: Viresh Kumar --- drivers/cpufreq/cpufreq_governor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/cpufreq/cpufreq_governor.c b/drivers/cpufreq/cpufreq_governor.c index ee2e19a1218a..c26f535d3d91 100644 --- a/drivers/cpufreq/cpufreq_governor.c +++ b/drivers/cpufreq/cpufreq_governor.c @@ -542,7 +542,7 @@ int cpufreq_governor_dbs(struct cpufreq_policy *policy, else dbs_data = cdata->gdbs_data; - if (WARN_ON(!dbs_data && (event != CPUFREQ_GOV_POLICY_INIT))) { + if (!dbs_data && (event != CPUFREQ_GOV_POLICY_INIT)) { ret = -EINVAL; goto unlock; }