From patchwork Fri Jun 6 04:38:58 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 31462 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ob0-f199.google.com (mail-ob0-f199.google.com [209.85.214.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id F30B6203AC for ; Fri, 6 Jun 2014 04:39:25 +0000 (UTC) Received: by mail-ob0-f199.google.com with SMTP id wm4sf8976492obc.10 for ; Thu, 05 Jun 2014 21:39:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:cc:subject:date:message-id :mime-version:sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe:content-type :content-transfer-encoding; bh=uK7+p1nntXd25zyAdMvUhgczucYZgTVpdLcB5DZSzHo=; b=dgckC3Sp/NsYWGg06aqtuOEVDYnUg5GROJvMospzEihJzXcoBk8imfyP+xAmMZt5XJ FkOPHlvRmTqBVJFAwTwjMB5M7AEYtZLSww+6SEb0dyShkiKtAc46eh1Dmt+1tnh98eFJ 9lV5hgK8pIX1GKhKC8bFVN+gaSEVOku+14cjYScGe29qMsH97JPphsIctrc5AeiHYgZq ueMIlPd7blN06L3nLOp2fOEkaja+LOqI/niuyys6t7ZYEa+BdFGtcyIFXpgiM050aewB pdZW1NlyGQIAuzqK73T3pwIlQw4y9gmzVYD8RE1HqPNpp50L2rHRRV5YtjCcpJ2b4Vvr qzlA== X-Gm-Message-State: ALoCoQnFwmhUU+yCKqE15z9IjwmXPvK3hAGv+FCpb+fPpWOKkX0ntjD/Af8qrqKfYLRlbztL+cXE X-Received: by 10.42.88.193 with SMTP id d1mr1439336icm.33.1402029565520; Thu, 05 Jun 2014 21:39:25 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.33.244 with SMTP id j107ls496489qgj.24.gmail; Thu, 05 Jun 2014 21:39:25 -0700 (PDT) X-Received: by 10.58.112.8 with SMTP id im8mr1781993veb.35.1402029565407; Thu, 05 Jun 2014 21:39:25 -0700 (PDT) Received: from mail-ve0-f170.google.com (mail-ve0-f170.google.com [209.85.128.170]) by mx.google.com with ESMTPS id b8si3848285vcf.7.2014.06.05.21.39.25 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 05 Jun 2014 21:39:25 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.128.170 as permitted sender) client-ip=209.85.128.170; Received: by mail-ve0-f170.google.com with SMTP id db11so2421762veb.15 for ; Thu, 05 Jun 2014 21:39:25 -0700 (PDT) X-Received: by 10.58.161.101 with SMTP id xr5mr2018666veb.36.1402029565328; Thu, 05 Jun 2014 21:39:25 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.54.6 with SMTP id vs6csp69584vcb; Thu, 5 Jun 2014 21:39:24 -0700 (PDT) X-Received: by 10.69.25.105 with SMTP id ip9mr4029987pbd.145.1402029564625; Thu, 05 Jun 2014 21:39:24 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id hb8si17126503pbc.8.2014.06.05.21.39.24; Thu, 05 Jun 2014 21:39:24 -0700 (PDT) Received-SPF: none (google.com: linux-pm-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752793AbaFFEjI (ORCPT + 13 others); Fri, 6 Jun 2014 00:39:08 -0400 Received: from mail-qa0-f42.google.com ([209.85.216.42]:64296 "EHLO mail-qa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751060AbaFFEjH (ORCPT ); Fri, 6 Jun 2014 00:39:07 -0400 Received: by mail-qa0-f42.google.com with SMTP id j5so2887333qaq.15 for ; Thu, 05 Jun 2014 21:39:06 -0700 (PDT) X-Received: by 10.224.130.196 with SMTP id u4mr4101792qas.13.1402029546055; Thu, 05 Jun 2014 21:39:06 -0700 (PDT) Received: from localhost (ec2-23-23-178-99.compute-1.amazonaws.com. [23.23.178.99]) by mx.google.com with ESMTPSA id w105sm5125438qgd.22.2014.06.05.21.39.02 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 05 Jun 2014 21:39:05 -0700 (PDT) From: Viresh Kumar To: rjw@rjwysocki.net Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, arvind.chauhan@arm.com, swarren@nvidia.com, dianders@chromium.org, Viresh Kumar Subject: [PATCH] cpufreq: tegra: update comment for clarity Date: Fri, 6 Jun 2014 10:08:58 +0530 Message-Id: <594cf0e6982c471eb314fe4a00647bfaf59a3456.1402029512.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.0.0.rc2 MIME-Version: 1.0 Sender: linux-pm-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: viresh.kumar@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.128.170 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Tegra's driver got updated a bit (00917dd cpufreq: Tegra: implement intermediate frequency callbacks) and implements new 'intermediate freq' infrastructure of core. Above commit updated comments about when to call clk_prepare_enable(pll_x_clk) and Doug wasn't satisfied with those comments and said this: > The "Though when target-freq is intermediate freq, we don't need to > take this reference." makes me think that this function is actually > called when target-freq is intermediate freq.  I don't think it is, > right? For better clarity just make that comment more explicit about when we call tegra_target_intermediate(). Wasn't sure if we actually need a commit for this, but anyway lets other decide if its worth enough :) Reported-by: Doug Anderson Signed-off-by: Viresh Kumar Reviewed-by: Doug Anderson Reviewed-by: Stephen Warren --- drivers/cpufreq/tegra-cpufreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/cpufreq/tegra-cpufreq.c b/drivers/cpufreq/tegra-cpufreq.c index a5fbc0a..48bc89b 100644 --- a/drivers/cpufreq/tegra-cpufreq.c +++ b/drivers/cpufreq/tegra-cpufreq.c @@ -73,7 +73,7 @@ static int tegra_target_intermediate(struct cpufreq_policy *policy, * off when we move the cpu off of it as enabling it again while we * switch to it from tegra_target() would take additional time. Though * when target-freq is intermediate freq, we don't need to take this - * reference. + * reference and so this routine isn't called at all. */ clk_prepare_enable(pll_x_clk);