From patchwork Thu Aug 28 05:52:25 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 36151 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ig0-f199.google.com (mail-ig0-f199.google.com [209.85.213.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 2D8412054F for ; Thu, 28 Aug 2014 05:53:05 +0000 (UTC) Received: by mail-ig0-f199.google.com with SMTP id l13sf6014377iga.6 for ; Wed, 27 Aug 2014 22:53:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:in-reply-to:references :sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe; bh=BTR48nmaqL0kUnT19z0t6GcmKb524Y17mQWsaR9GnTE=; b=gPQwPoW2PyJQO9rYxIc8kB9NtdLD05AYondNhB6QFAhptM8eHWynD6bMF1rWq9n8/L Jm2b0Qa3uZkp185DZ6/DUtwFWNoD0MuzFlc+TW9x15VmB5DueDvdwzlc43ATpiLl76bw AMDKbSz4n6btpPgZL/SKnRCasZgeZ1ivcOSwDFVm4iuEoOaxpuM73yodujqmnuUjbfiU 4roAdHKYB2Zdm2nVfVpNptwxq5GMdAgtcJKhzb5RabeSP0t1EegMso/NTZNeAbTzjjun pRXbE+utnT2l7kVu9ZXxWmngmPJW2nxW3gTERrTaticeQp1MMaVnMGv0eGEeRoRaKFCd 4ovQ== X-Gm-Message-State: ALoCoQmusgM2ebxVAvLyp0O8+Ye3wEWiL1oTwpdK9a+NZJlvVT2ZFGnmqWn1G3CMc6taMALgkzjy X-Received: by 10.42.96.193 with SMTP id k1mr1656714icn.13.1409205184666; Wed, 27 Aug 2014 22:53:04 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.39.231 with SMTP id v94ls406708qgv.16.gmail; Wed, 27 Aug 2014 22:53:04 -0700 (PDT) X-Received: by 10.220.167.9 with SMTP id o9mr1496035vcy.8.1409205184565; Wed, 27 Aug 2014 22:53:04 -0700 (PDT) Received: from mail-vc0-f177.google.com (mail-vc0-f177.google.com [209.85.220.177]) by mx.google.com with ESMTPS id ev4si2822275vdb.15.2014.08.27.22.53.04 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 27 Aug 2014 22:53:04 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.177 as permitted sender) client-ip=209.85.220.177; Received: by mail-vc0-f177.google.com with SMTP id hq11so295720vcb.8 for ; Wed, 27 Aug 2014 22:53:04 -0700 (PDT) X-Received: by 10.220.105.201 with SMTP id u9mr1381785vco.11.1409205184434; Wed, 27 Aug 2014 22:53:04 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.45.67 with SMTP id uj3csp184422vcb; Wed, 27 Aug 2014 22:53:03 -0700 (PDT) X-Received: by 10.70.65.34 with SMTP id u2mr2494695pds.58.1409205183499; Wed, 27 Aug 2014 22:53:03 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id oz2si4047100pbc.237.2014.08.27.22.53.02 for ; Wed, 27 Aug 2014 22:53:03 -0700 (PDT) Received-SPF: none (google.com: linux-arm-msm-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933148AbaH1FxB (ORCPT + 5 others); Thu, 28 Aug 2014 01:53:01 -0400 Received: from mail-pa0-f48.google.com ([209.85.220.48]:32833 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933992AbaH1FxB (ORCPT ); Thu, 28 Aug 2014 01:53:01 -0400 Received: by mail-pa0-f48.google.com with SMTP id ey11so1110624pad.35 for ; Wed, 27 Aug 2014 22:53:00 -0700 (PDT) X-Received: by 10.68.143.100 with SMTP id sd4mr2445658pbb.76.1409205180748; Wed, 27 Aug 2014 22:53:00 -0700 (PDT) Received: from localhost ([122.167.123.172]) by mx.google.com with ESMTPSA id du5sm2289728pbb.80.2014.08.27.22.52.59 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 27 Aug 2014 22:53:00 -0700 (PDT) From: Viresh Kumar To: Rafael Wysocki Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, shawn.guo@linaro.org, sboyd@codeaurora.org, linux-arm-msm@vger.kernel.org, spk.linux@gmail.com, thomas.ab@samsung.com, t.figa@samsung.com, santosh.shilimkar@ti.com, thomas.petazzoni@free-electrons.com, pramod.gurav@smartplayin.com, Viresh Kumar Subject: [PATCH V3 03/10] cpufreq: cpu0: don't validate clock on clk_put() Date: Thu, 28 Aug 2014 11:22:25 +0530 Message-Id: <4f6f0b21db83466aef5569fddcef76a3c9b7dc5a.1409201048.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.0.3.693.g996b0fd In-Reply-To: References: In-Reply-To: References: Sender: linux-arm-msm-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: viresh.kumar@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.177 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , CPU clk is not optional for this driver and probe would fail if it couldn't find a suitable clock. And so, while calling clk_put() we don't need to validate clocks. Acked-by: Santosh Shilimkar Tested-by: Stephen Boyd Signed-off-by: Viresh Kumar --- drivers/cpufreq/cpufreq-cpu0.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/cpufreq/cpufreq-cpu0.c b/drivers/cpufreq/cpufreq-cpu0.c index 4cfde63..d2dc921 100644 --- a/drivers/cpufreq/cpufreq-cpu0.c +++ b/drivers/cpufreq/cpufreq-cpu0.c @@ -217,8 +217,7 @@ static int cpu0_cpufreq_probe(struct platform_device *pdev) out_free_table: dev_pm_opp_free_cpufreq_table(cpu_dev, &freq_table); out_put_clk: - if (!IS_ERR(cpu_clk)) - clk_put(cpu_clk); + clk_put(cpu_clk); out_put_reg: if (!IS_ERR(cpu_reg)) regulator_put(cpu_reg);