From patchwork Tue Jun 10 04:57:12 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 31605 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-oa0-f70.google.com (mail-oa0-f70.google.com [209.85.219.70]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 12C4920675 for ; Tue, 10 Jun 2014 04:57:42 +0000 (UTC) Received: by mail-oa0-f70.google.com with SMTP id g18sf41183071oah.1 for ; Mon, 09 Jun 2014 21:57:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe:content-type :content-transfer-encoding; bh=cuyMqCUYe3pORPz0UflqTdVmroSXkEXwx8MZcIeBf6Q=; b=R5ch8rBJ19cyWimH0189HgWknh8EjOrQib62see6rhh5nnlK06dhSs7z770IN52KJW SR9WN6CjsTzMQ5VVkWPMC9jEas6VW6duHElpASBd35+UXZSL8No/gqza7A3Nek+9an0q StbjT2zW54mqMqkBPKnM/4mgmF5bT5Kop+jG4fMJvqOWJaHpMzVcwIxtoDeRV8fRZoVC ybSk3u/pjbUmqSc8xJ+tCULasVqAe5Y3ciGsTl5kWkJQUplzDaqBDAv/jSWiNKli4Rsm qL7MALnEKV+QD6JNlPWm2csMGR/6zug4zzaMqoLVO0NXZl2bMESI00FETGWnEoz8yZPP xAWA== X-Gm-Message-State: ALoCoQl82VWi5T+7TKiVmyFMV/TXkwspkNKHs20nPq8d7Q5vk1CnVSuBCmaY0IUu4g9BgP3yB7i/ X-Received: by 10.182.105.230 with SMTP id gp6mr15931560obb.18.1402376262243; Mon, 09 Jun 2014 21:57:42 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.93.131 with SMTP id d3ls1906052qge.52.gmail; Mon, 09 Jun 2014 21:57:42 -0700 (PDT) X-Received: by 10.58.126.135 with SMTP id my7mr31074800veb.27.1402376262026; Mon, 09 Jun 2014 21:57:42 -0700 (PDT) Received: from mail-vc0-f178.google.com (mail-vc0-f178.google.com [209.85.220.178]) by mx.google.com with ESMTPS id jq7si12681816vec.22.2014.06.09.21.57.41 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 09 Jun 2014 21:57:42 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.178 as permitted sender) client-ip=209.85.220.178; Received: by mail-vc0-f178.google.com with SMTP id ij19so3607959vcb.37 for ; Mon, 09 Jun 2014 21:57:41 -0700 (PDT) X-Received: by 10.221.4.66 with SMTP id ob2mr30632095vcb.28.1402376261910; Mon, 09 Jun 2014 21:57:41 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.54.6 with SMTP id vs6csp197699vcb; Mon, 9 Jun 2014 21:57:41 -0700 (PDT) X-Received: by 10.69.31.11 with SMTP id ki11mr9158846pbd.88.1402376260959; Mon, 09 Jun 2014 21:57:40 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id ys3si1531716pab.26.2014.06.09.21.57.40; Mon, 09 Jun 2014 21:57:40 -0700 (PDT) Received-SPF: none (google.com: linux-pm-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751153AbaFJE5j (ORCPT + 13 others); Tue, 10 Jun 2014 00:57:39 -0400 Received: from mail-qc0-f181.google.com ([209.85.216.181]:60465 "EHLO mail-qc0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750994AbaFJE5i (ORCPT ); Tue, 10 Jun 2014 00:57:38 -0400 Received: by mail-qc0-f181.google.com with SMTP id x3so1668298qcv.26 for ; Mon, 09 Jun 2014 21:57:37 -0700 (PDT) X-Received: by 10.224.13.4 with SMTP id z4mr17162319qaz.51.1402376257777; Mon, 09 Jun 2014 21:57:37 -0700 (PDT) Received: from localhost (ec2-23-23-178-99.compute-1.amazonaws.com. [23.23.178.99]) by mx.google.com with ESMTPSA id z8sm33987329qar.49.2014.06.09.21.57.33 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 09 Jun 2014 21:57:37 -0700 (PDT) From: Viresh Kumar To: rjw@rjwysocki.net Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, arvind.chauhan@arm.com, swarren@nvidia.com, dianders@chromium.org, Viresh Kumar Subject: [PATCH Resend] cpufreq: tegra: update comment for clarity Date: Tue, 10 Jun 2014 10:27:12 +0530 Message-Id: <3eb9a48877bbb208f3c1f3e121f8d78b1d306bd9.1402376112.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.0.0.rc2 In-Reply-To: <594cf0e6982c471eb314fe4a00647bfaf59a3456.1402029512.git.viresh.kumar@linaro.org> References: <594cf0e6982c471eb314fe4a00647bfaf59a3456.1402029512.git.viresh.kumar@linaro.org> MIME-Version: 1.0 Sender: linux-pm-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: viresh.kumar@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.178 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Tegra's driver got updated a bit (00917dd cpufreq: Tegra: implement intermediate frequency callbacks) and implements new 'intermediate freq' infrastructure of core. Above commit updated comments about when to call clk_prepare_enable(pll_x_clk) and Doug wasn't satisfied with those comments and said this: > The "Though when target-freq is intermediate freq, we don't need to > take this reference." makes me think that this function is actually > called when target-freq is intermediate freq.  I don't think it is, > right? For better clarity just make that comment more explicit about when we call tegra_target_intermediate(). Reviewed-by: Stephen Warren Reported-and-reviewed-by: Doug Anderson Signed-off-by: Viresh Kumar --- Resend: Improved comment as suggested by Stephen. drivers/cpufreq/tegra-cpufreq.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/cpufreq/tegra-cpufreq.c b/drivers/cpufreq/tegra-cpufreq.c index a5fbc0a..8084c7f 100644 --- a/drivers/cpufreq/tegra-cpufreq.c +++ b/drivers/cpufreq/tegra-cpufreq.c @@ -71,9 +71,12 @@ static int tegra_target_intermediate(struct cpufreq_policy *policy, /* * Take an extra reference to the main pll so it doesn't turn * off when we move the cpu off of it as enabling it again while we - * switch to it from tegra_target() would take additional time. Though - * when target-freq is intermediate freq, we don't need to take this - * reference. + * switch to it from tegra_target() would take additional time. + * + * When target-freq is equal to intermediate freq we don't need to + * switch to an intermediate freq and so this routine isn't called. + * Also, we wouldn't be using pll_x anymore and must not take extra + * reference to it, as it can be disabled now to save some power. */ clk_prepare_enable(pll_x_clk);