From patchwork Thu May 17 00:50:14 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anton Vorontsov X-Patchwork-Id: 8698 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 56C1B23F00 for ; Thu, 17 May 2012 00:51:46 +0000 (UTC) Received: from mail-yw0-f52.google.com (mail-yw0-f52.google.com [209.85.213.52]) by fiordland.canonical.com (Postfix) with ESMTP id F2D86A18A96 for ; Thu, 17 May 2012 00:51:45 +0000 (UTC) Received: by yhpp61 with SMTP id p61so1612744yhp.11 for ; Wed, 16 May 2012 17:51:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:date:from :to:cc:subject:message-id:references:mime-version:content-type :content-disposition:in-reply-to:user-agent:x-gm-message-state; bh=KXQCstNSNUCpXJYZx1+18QFEwWuqVmPy5FYVhUpvK1g=; b=WbALmvLKidMb9Zn+E6WGOqCpJCT+8XtmGVWL9Jhy/vHAVSMn3aMQqjiswzojU32fAC B49oa9d95OLHb6z1v0KkUrP0yPXPGHmEcczyOKXFVanwdntxk9g5rdTdYAf+VzKlnBud RxKryp/7AO80LyiPVsOthoQBDzTOtIaCETUm60WsH0zverWMgubKCXHuZuWbJ3zw2/mL F9tE5cpFZUfcN80Tg/HQ8krpRrj+gD1WZ1ueGir/NlMqDTPexZF4ajEbl0+HacSwI8ez KMfPcgFwgKXifaV+ygu1OOy2vH0KeLuIkHBxZKepiG9pUh6M0UtuI8/JpP5w3Al6LZUu oE0Q== Received: by 10.50.85.163 with SMTP id i3mr3719857igz.57.1337215905256; Wed, 16 May 2012 17:51:45 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.231.35.72 with SMTP id o8csp530437ibd; Wed, 16 May 2012 17:51:44 -0700 (PDT) Received: by 10.68.132.201 with SMTP id ow9mr21482001pbb.160.1337215904388; Wed, 16 May 2012 17:51:44 -0700 (PDT) Received: from mail-pz0-f50.google.com (mail-pz0-f50.google.com [209.85.210.50]) by mx.google.com with ESMTPS id p7si9170529pbk.44.2012.05.16.17.51.44 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 16 May 2012 17:51:44 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.210.50 is neither permitted nor denied by best guess record for domain of anton.vorontsov@linaro.org) client-ip=209.85.210.50; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.210.50 is neither permitted nor denied by best guess record for domain of anton.vorontsov@linaro.org) smtp.mail=anton.vorontsov@linaro.org Received: by danh15 with SMTP id h15so2055272dan.37 for ; Wed, 16 May 2012 17:51:44 -0700 (PDT) Received: by 10.68.228.97 with SMTP id sh1mr21509341pbc.113.1337215904046; Wed, 16 May 2012 17:51:44 -0700 (PDT) Received: from localhost (c-71-204-165-222.hsd1.ca.comcast.net. [71.204.165.222]) by mx.google.com with ESMTPS id gq5sm5388947pbc.65.2012.05.16.17.51.41 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 16 May 2012 17:51:43 -0700 (PDT) Date: Wed, 16 May 2012 17:50:14 -0700 From: Anton Vorontsov To: Greg Kroah-Hartman Cc: Kees Cook , Colin Cross , devel@driverdev.osuosl.org, linaro-kernel@lists.linaro.org, Arnd Bergmann , patches@linaro.org, Marco Stornelli , Stephen Boyd , linux-kernel@vger.kernel.org, arve@android.com, Jesper Juhl , John Stultz , Shuah Khan , Rebecca Schultz Zavin , WANG Cong , Andrew Morton , kernel-team@android.com, Thomas Meyer Subject: Re: [PATCH 4/6] staging: android: persistent_ram: Move to fs/pstore/ram_core.c Message-ID: <20120517005014.GA333@lizard> References: <20120516124109.GA14658@lizard> <20120516124338.GD18345@lizard> <20120516150550.GA22945@kroah.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20120516150550.GA22945@kroah.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Gm-Message-State: ALoCoQn7Vf+8GwLlCCH4YYZGHn3dHQTLA23knpwxSs2gZLLRKVXn6Lcg10xOwICZVRn2QfdJ+WWo On Wed, May 16, 2012 at 08:05:50AM -0700, Greg Kroah-Hartman wrote: [...] > After applying this patch, and building things, I get the following > errors: > > drivers/built-in.o: In function `ram_console_write': > ram_console.c:(.text+0x1690b9): undefined reference to `persistent_ram_write' > drivers/built-in.o: In function `ram_console_read_old': > ram_console.c:(.text+0x1690f7): undefined reference to `persistent_ram_old_size' > ram_console.c:(.text+0x169103): undefined reference to `persistent_ram_old' > ram_console.c:(.text+0x169136): undefined reference to `persistent_ram_ecc_string' > ram_console.c:(.text+0x169177): undefined reference to `persistent_ram_ecc_string' > drivers/built-in.o: In function `ram_console_probe': > ram_console.c:(.init.text+0xc9ea): undefined reference to `persistent_ram_init_ringbuffer' > drivers/built-in.o: In function `ram_console_late_init': > ram_console.c:(.init.text+0xca6c): undefined reference to `persistent_ram_old_size' > ram_console.c:(.init.text+0xcaa2): undefined reference to `persistent_ram_free_old' > ram_console.c:(.init.text+0xcab4): undefined reference to `persistent_ram_old_size' > ram_console.c:(.init.text+0xcac3): undefined reference to `persistent_ram_ecc_string' > make: *** [.tmp_vmlinux1] Error 1 > > What went wrong? I believe that error caused by two missing bytes: '=' and 'y'. :-) RAM_CONSOLE is a bool, so it should be enabled only when PSTORE_RAM is also =y. (For some reason I keep foregetting that bool's 'depends on' may be satisfied by tristates' =m option, which easily lead to the errors above.) Thanks for catching this! I've applied the following hunk to this patch and will resend the left over patches soon: diff --git a/drivers/staging/android/Kconfig b/drivers/staging/android/Kconfig index 4bfcceb..0e16b59 100644 --- a/drivers/staging/android/Kconfig +++ b/drivers/staging/android/Kconfig @@ -27,7 +27,7 @@ config ANDROID_LOGGER config ANDROID_RAM_CONSOLE bool "Android RAM buffer console" - depends on !S390 && !UML && HAVE_MEMBLOCK && PSTORE_RAM + depends on !S390 && !UML && HAVE_MEMBLOCK && PSTORE_RAM=y default n config ANDROID_TIMED_OUTPUT