From patchwork Fri Apr 4 06:36:18 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 27758 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-qg0-f70.google.com (mail-qg0-f70.google.com [209.85.192.70]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 78BDE2036E for ; Fri, 4 Apr 2014 06:44:03 +0000 (UTC) Received: by mail-qg0-f70.google.com with SMTP id z60sf3200267qgd.9 for ; Thu, 03 Apr 2014 23:44:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:in-reply-to:references :sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe; bh=NLV2sr1QTmMoy4BYHAZcUR1V5zTReeycdjr6TcVLzAM=; b=CyQLwClPAjZv/pxG1wChDf93p/gdFqu1f87Bbfh4FriuJdjO0nIcJks6+7ExK+gdAq DkORudJTTRMCQ24CARkDx+/MOJqIp21FnQRdUwC1WNv8TWY6oHKsacuX8yJocvoiDKq9 tqPHL2rT1IpVdAtiQ1/xM3IRY7NMOzfkgNa/DLaigQpmug14jBlyjUkjMGh6FB1HYqcV UQu0uqOWRfG5fDPl3eCAt6KT5lj7mjLULC6VrGsSUudvD5LBRCmp/5edXe7v1N7h9Nx6 gU7XBlbR+3y+iN3wps48B4lNDrcN8NOlw3q246G+I4yEUiGpSxtaX/7hGnlJCqwrdgIE kgsg== X-Gm-Message-State: ALoCoQn/FBeV4Yn3U1XelZPeBUZW2cuRXvtD23cB8n/LidgDV2okxWi0c6gREQxOfnYgXH3ukZJO X-Received: by 10.236.173.42 with SMTP id u30mr6958509yhl.2.1396593843284; Thu, 03 Apr 2014 23:44:03 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.109.101 with SMTP id k92ls926950qgf.64.gmail; Thu, 03 Apr 2014 23:44:03 -0700 (PDT) X-Received: by 10.58.49.10 with SMTP id q10mr3511694ven.5.1396593843217; Thu, 03 Apr 2014 23:44:03 -0700 (PDT) Received: from mail-vc0-f176.google.com (mail-vc0-f176.google.com [209.85.220.176]) by mx.google.com with ESMTPS id h11si1635033vcu.152.2014.04.03.23.44.03 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 03 Apr 2014 23:44:03 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.220.176 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.176; Received: by mail-vc0-f176.google.com with SMTP id lc6so2762089vcb.21 for ; Thu, 03 Apr 2014 23:44:03 -0700 (PDT) X-Received: by 10.220.163.3 with SMTP id y3mr6821214vcx.7.1396593843148; Thu, 03 Apr 2014 23:44:03 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.12.8 with SMTP id v8csp89374vcv; Thu, 3 Apr 2014 23:44:01 -0700 (PDT) X-Received: by 10.68.234.2 with SMTP id ua2mr12819083pbc.81.1396593837880; Thu, 03 Apr 2014 23:43:57 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id xs1si4206350pab.32.2014.04.03.23.43.57; Thu, 03 Apr 2014 23:43:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753045AbaDDGnU (ORCPT + 27 others); Fri, 4 Apr 2014 02:43:20 -0400 Received: from mail-wi0-f179.google.com ([209.85.212.179]:50832 "EHLO mail-wi0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753006AbaDDGnN (ORCPT ); Fri, 4 Apr 2014 02:43:13 -0400 Received: by mail-wi0-f179.google.com with SMTP id z2so596662wiv.12 for ; Thu, 03 Apr 2014 23:43:11 -0700 (PDT) X-Received: by 10.194.9.8 with SMTP id v8mr16807030wja.53.1396593791701; Thu, 03 Apr 2014 23:43:11 -0700 (PDT) Received: from localhost ([213.122.173.131]) by mx.google.com with ESMTPSA id xm12sm2734913wib.1.2014.04.03.23.43.08 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 03 Apr 2014 23:43:11 -0700 (PDT) From: Viresh Kumar To: tglx@linutronix.de Cc: linaro-kernel@lists.linaro.org, fweisbec@gmail.com, linaro-networking@linaro.org, Arvind.Chauhan@arm.com, linux-kernel@vger.kernel.org, Viresh Kumar Subject: [PATCH V2 35/36] timer: simplify CPU_UP_PREPARE notifier code path Date: Fri, 4 Apr 2014 12:06:18 +0530 Message-Id: <17837b2835498eba99afc173daf33771816bf141.1396592516.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 1.7.12.rc2.18.g61b472e In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: viresh.kumar@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.176 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Currently we are returning notifier_from_errno() from CPU_UP_PREPARE notifier when we detect there is an error while calling init_timers_cpu(). notifier_from_errno() already has enough checks within to do something similar. And so we can call it directly without checking if there was an error or not. Reviewed-by: Srivatsa S. Bhat Signed-off-by: Viresh Kumar --- kernel/timer.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/kernel/timer.c b/kernel/timer.c index 1d35dda..4360edc 100644 --- a/kernel/timer.c +++ b/kernel/timer.c @@ -1646,9 +1646,7 @@ static int timer_cpu_notify(struct notifier_block *self, case CPU_UP_PREPARE: case CPU_UP_PREPARE_FROZEN: err = init_timers_cpu(cpu); - if (err < 0) - return notifier_from_errno(err); - break; + return notifier_from_errno(err); #ifdef CONFIG_HOTPLUG_CPU case CPU_DEAD: case CPU_DEAD_FROZEN: