From patchwork Thu Feb 27 13:06:39 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Liviu Dudau X-Patchwork-Id: 25447 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-vc0-f199.google.com (mail-vc0-f199.google.com [209.85.220.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 6B12520447 for ; Thu, 27 Feb 2014 13:07:53 +0000 (UTC) Received: by mail-vc0-f199.google.com with SMTP id hu8sf5476764vcb.10 for ; Thu, 27 Feb 2014 05:07:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=99Hja67NCyk4/hkP1mabXa1rbrNRpYEUUTqzXjIR/Pk=; b=BpRmHQ+15OWpelMPRz19Wz8lFODmz5jmHvZEGL6mSqmrvZaqenBSjET7FLDgC+C5kq DTQKCJsQfkKEWcGK8qY/IVLszLNM3CgJzv7eRqHTmQ5yC7ubeXIMhWGwBFPiOAUZjbcL 8huWTn9LB+KYV6FVQKw3I2+ZtSmRsmBMVKfWCw9ZLFl7PULGR2n4typb0AWuLYtGkkT2 JCT+R2G90UwgREKvlVmbaXxUezMnR1z41KqvKyEYDcoshnKNt2iMsyRVlhsLC7uz/dRh zgEwAQ+fkEnM7LHe1CQFk7T0SzhSmPH1VxQEWFU/oTf/D2PRWUTjGuWs3RrtxSyYU4Gz +KjQ== X-Gm-Message-State: ALoCoQkFQ4V27LeBrgEobQFIPUBDRetDQUVSYa6G/Diyz4NuBNGmhOBI/xtrCEfS16kP2mW25089 X-Received: by 10.58.151.98 with SMTP id up2mr5501814veb.14.1393506473153; Thu, 27 Feb 2014 05:07:53 -0800 (PST) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.36.7 with SMTP id o7ls663733qgo.15.gmail; Thu, 27 Feb 2014 05:07:53 -0800 (PST) X-Received: by 10.58.86.230 with SMTP id s6mr10625090vez.16.1393506473061; Thu, 27 Feb 2014 05:07:53 -0800 (PST) Received: from mail-vc0-f171.google.com (mail-vc0-f171.google.com [209.85.220.171]) by mx.google.com with ESMTPS id fb12si1126798veb.128.2014.02.27.05.07.53 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 27 Feb 2014 05:07:53 -0800 (PST) Received-SPF: neutral (google.com: 209.85.220.171 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.171; Received: by mail-vc0-f171.google.com with SMTP id le5so2448578vcb.16 for ; Thu, 27 Feb 2014 05:07:53 -0800 (PST) X-Received: by 10.58.48.133 with SMTP id l5mr871462ven.36.1393506472963; Thu, 27 Feb 2014 05:07:52 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.174.196 with SMTP id u4csp15585vcz; Thu, 27 Feb 2014 05:07:52 -0800 (PST) X-Received: by 10.67.5.7 with SMTP id ci7mr14956168pad.99.1393506471827; Thu, 27 Feb 2014 05:07:51 -0800 (PST) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id wh10si4555487pab.133.2014.02.27.05.07.51; Thu, 27 Feb 2014 05:07:51 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752817AbaB0NHY (ORCPT + 26 others); Thu, 27 Feb 2014 08:07:24 -0500 Received: from fw-tnat.cambridge.arm.com ([217.140.96.21]:52926 "EHLO cam-smtp0.cambridge.arm.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751613AbaB0NHT (ORCPT ); Thu, 27 Feb 2014 08:07:19 -0500 Received: from e106497-lin.cambridge.arm.com (e106497-lin.cambridge.arm.com [10.1.195.170]) by cam-smtp0.cambridge.arm.com (8.13.8/8.13.8) with ESMTP id s1RD6gmE016111; Thu, 27 Feb 2014 13:06:42 GMT From: Liviu Dudau To: linux-pci , Bjorn Helgaas , Catalin Marinas , Will Deacon , linaro-kernel Cc: LKML , "devicetree@vger.kernel.org" , LAKML Subject: [PATCH v2 1/4] pci: OF: Fix the conversion of IO ranges into IO resources. Date: Thu, 27 Feb 2014 13:06:39 +0000 Message-Id: <1393506402-11474-2-git-send-email-Liviu.Dudau@arm.com> X-Mailer: git-send-email 1.9.0 In-Reply-To: <1393506402-11474-1-git-send-email-Liviu.Dudau@arm.com> References: <1393506402-11474-1-git-send-email-Liviu.Dudau@arm.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: liviu.dudau@arm.com X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.171 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , The ranges property for a host bridge controller in DT describes the mapping between the PCI bus address and the CPU physical address. The resources framework however expects that the IO resources start at a pseudo "port" address 0 (zero) and have a maximum size of 64kb. The conversion from pci ranges to resources failed to take that into account. In the process move the function into drivers/of/address.c as it now depends on pci_address_to_pio() code. Signed-off-by: Liviu Dudau diff --git a/drivers/of/address.c b/drivers/of/address.c index 1a54f1f..7cf2b16 100644 --- a/drivers/of/address.c +++ b/drivers/of/address.c @@ -719,3 +719,34 @@ void __iomem *of_iomap(struct device_node *np, int index) return ioremap(res.start, resource_size(&res)); } EXPORT_SYMBOL(of_iomap); + +/** + * of_pci_range_to_resource - Create a resource from an of_pci_range + * @range: the PCI range that describes the resource + * @np: device node where the range belongs to + * @res: pointer to a valid resource that will be updated to + * reflect the values contained in the range. + * Note that if the range is an IO range, the resource will be converted + * using pci_address_to_pio() which can fail if it is called to early or + * if the range cannot be matched to any host bridge IO space. + */ +void of_pci_range_to_resource(struct of_pci_range *range, + struct device_node *np, struct resource *res) +{ + res->flags = range->flags; + if (res->flags & IORESOURCE_IO) { + unsigned long port; + port = pci_address_to_pio(range->pci_addr); + if (port == (unsigned long)-1) { + res->start = (resource_size_t)OF_BAD_ADDR; + res->end = (resource_size_t)OF_BAD_ADDR; + return; + } + res->start = port; + } else { + res->start = range->cpu_addr; + } + res->end = res->start + range->size - 1; + res->parent = res->child = res->sibling = NULL; + res->name = np->full_name; +} diff --git a/include/linux/of_address.h b/include/linux/of_address.h index 5f6ed6b..a667762 100644 --- a/include/linux/of_address.h +++ b/include/linux/of_address.h @@ -23,17 +23,8 @@ struct of_pci_range { #define for_each_of_pci_range(parser, range) \ for (; of_pci_range_parser_one(parser, range);) -static inline void of_pci_range_to_resource(struct of_pci_range *range, - struct device_node *np, - struct resource *res) -{ - res->flags = range->flags; - res->start = range->cpu_addr; - res->end = range->cpu_addr + range->size - 1; - res->parent = res->child = res->sibling = NULL; - res->name = np->full_name; -} - +extern void of_pci_range_to_resource(struct of_pci_range *range, + struct device_node *np, struct resource *res); /* Translate a DMA address from device space to CPU space */ extern u64 of_translate_dma_address(struct device_node *dev, const __be32 *in_addr);