From patchwork Mon Aug 19 14:44:14 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 19307 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-qa0-f72.google.com (mail-qa0-f72.google.com [209.85.216.72]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 6CCF3246F8 for ; Mon, 19 Aug 2013 14:45:51 +0000 (UTC) Received: by mail-qa0-f72.google.com with SMTP id o19sf4112110qap.3 for ; Mon, 19 Aug 2013 07:45:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-gm-message-state:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:in-reply-to:references :x-original-sender:x-original-authentication-results:precedence :mailing-list:list-id:list-post:list-help:list-archive :list-unsubscribe; bh=/FkbEurlsaTe1mnMcO+aVvvCy4mu9ktYdG30dNBDBls=; b=kyknSgrhGxFtG9P34R615zTvhi9TogO1Wd7HhWVoVGs+AAWrAMmAyfqT3IhOj5mcx1 r2xHpf4/VdS5u0EVJPDv2lPdt0p35vIbcwhvEOQvTi84KYKMf8oJyWAC/GOKBJa4Ni0l wYoKL6K718fjczsbZNovdhCz6jQNUGdrlkHX2x7m9SqZ1aLBl+S97SkJV/lsz7OFUwjX fB3BYYWvZQehj5NYTnAJBjuhNra37jokWjRmj4GS5i/zXqmm66mvHGVqTToGuox44eNt 3g61/z4jHcbt5Q6/uf/kccZgJDxHmvdTxalnsAGQbNh5kILjTi4lGf7+rPRCnicy+TYe 7VIw== X-Received: by 10.236.31.228 with SMTP id m64mr4439532yha.5.1376923551199; Mon, 19 Aug 2013 07:45:51 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.108.198 with SMTP id hm6ls1746700qeb.40.gmail; Mon, 19 Aug 2013 07:45:51 -0700 (PDT) X-Received: by 10.52.103.35 with SMTP id ft3mr11819890vdb.5.1376923551062; Mon, 19 Aug 2013 07:45:51 -0700 (PDT) Received: from mail-vb0-f44.google.com (mail-vb0-f44.google.com [209.85.212.44]) by mx.google.com with ESMTPS id cu1si2429380vcb.61.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 19 Aug 2013 07:45:51 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.212.44 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.212.44; Received: by mail-vb0-f44.google.com with SMTP id e13so3344786vbg.3 for ; Mon, 19 Aug 2013 07:45:51 -0700 (PDT) X-Gm-Message-State: ALoCoQk4bIDhSANvFAT81LxVJl6i9YbUHjiI2IfSieZJaGKR6acvQLCAWkeHGSxQaJepeafXRwbh X-Received: by 10.58.100.234 with SMTP id fb10mr13905196veb.5.1376923550986; Mon, 19 Aug 2013 07:45:50 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.174.196 with SMTP id u4csp100143vcz; Mon, 19 Aug 2013 07:45:50 -0700 (PDT) X-Received: by 10.68.250.5 with SMTP id yy5mr13838831pbc.93.1376923549983; Mon, 19 Aug 2013 07:45:49 -0700 (PDT) Received: from mail-pd0-f176.google.com (mail-pd0-f176.google.com [209.85.192.176]) by mx.google.com with ESMTPS id bk3si8650040pbd.148.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 19 Aug 2013 07:45:49 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.192.176 is neither permitted nor denied by best guess record for domain of viresh.kumar@linaro.org) client-ip=209.85.192.176; Received: by mail-pd0-f176.google.com with SMTP id q10so1757418pdj.35 for ; Mon, 19 Aug 2013 07:45:49 -0700 (PDT) X-Received: by 10.68.36.38 with SMTP id n6mr13793541pbj.15.1376923549571; Mon, 19 Aug 2013 07:45:49 -0700 (PDT) Received: from localhost ([122.172.193.46]) by mx.google.com with ESMTPSA id xe9sm16110999pab.0.1969.12.31.16.00.00 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 19 Aug 2013 07:45:48 -0700 (PDT) From: Viresh Kumar To: gregkh@linuxfoundation.org, jslaby@suse.cz Cc: linaro-kernel@lists.linaro.org, patches@linaro.org, linux-serial@vger.kernel.org, Viresh Kumar Subject: [PATCH V2 10/25] tty: serial: lpc32xx_hs: don't call tty_flip_buffer_push() twice Date: Mon, 19 Aug 2013 20:14:14 +0530 Message-Id: <00d9c7ce1f24cdaae6707fc71c957cc65b854751.1376923198.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 1.7.12.rc2.18.g61b472e In-Reply-To: References: In-Reply-To: References: X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: viresh.kumar@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.212.44 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , serial_lpc32xx_interrupt() calls __serial_lpc32xx_rx() first and then tty_flip_buffer_push() immediately after that. But last statement of __serial_lpc32xx_rx() already called tty_flip_buffer_push().. So, probably its not required to be called twice. Lets remove one of them. Signed-off-by: Viresh Kumar --- drivers/tty/serial/lpc32xx_hs.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/tty/serial/lpc32xx_hs.c b/drivers/tty/serial/lpc32xx_hs.c index dffea6b..8fdf6a8 100644 --- a/drivers/tty/serial/lpc32xx_hs.c +++ b/drivers/tty/serial/lpc32xx_hs.c @@ -351,10 +351,8 @@ static irqreturn_t serial_lpc32xx_interrupt(int irq, void *dev_id) } /* Data received? */ - if (status & (LPC32XX_HSU_RX_TIMEOUT_INT | LPC32XX_HSU_RX_TRIG_INT)) { + if (status & (LPC32XX_HSU_RX_TIMEOUT_INT | LPC32XX_HSU_RX_TRIG_INT)) __serial_lpc32xx_rx(port); - tty_flip_buffer_push(tport); - } /* Transmit data request? */ if ((status & LPC32XX_HSU_TX_INT) && (!uart_tx_stopped(port))) {