From patchwork Tue Apr 19 21:35:59 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cole Robinson X-Patchwork-Id: 66141 Delivered-To: patch@linaro.org Received: by 10.140.93.198 with SMTP id d64csp2101028qge; Tue, 19 Apr 2016 14:38:41 -0700 (PDT) X-Received: by 10.28.140.12 with SMTP id o12mr26299882wmd.19.1461101921683; Tue, 19 Apr 2016 14:38:41 -0700 (PDT) Return-Path: Received: from mx4-phx2.redhat.com (mx4-phx2.redhat.com. [209.132.183.25]) by mx.google.com with ESMTPS id nw5si2361441wjb.32.2016.04.19.14.38.40 (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 19 Apr 2016 14:38:41 -0700 (PDT) Received-SPF: pass (google.com: domain of libvir-list-bounces@redhat.com designates 209.132.183.25 as permitted sender) client-ip=209.132.183.25; Authentication-Results: mx.google.com; spf=pass (google.com: domain of libvir-list-bounces@redhat.com designates 209.132.183.25 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by mx4-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id u3JLa2x0015301; Tue, 19 Apr 2016 17:36:03 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id u3JLa1U0005405 for ; Tue, 19 Apr 2016 17:36:01 -0400 Received: from colepc.redhat.com (ovpn-113-99.phx2.redhat.com [10.3.113.99]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u3JLa0v5022241; Tue, 19 Apr 2016 17:36:00 -0400 From: Cole Robinson To: libvirt-list@redhat.com Date: Tue, 19 Apr 2016 17:35:59 -0400 Message-Id: X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] man: Clarify virsh vol-clone works within a single pool X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com virsh vol-clone is expected to clone a volume within a single pool; it doesn't work for cloning across pools. Clarify the docs https://bugzilla.redhat.com/show_bug.cgi?id=1103714 --- tools/virsh-volume.c | 2 +- tools/virsh.pod | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) -- 2.7.3 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list diff --git a/tools/virsh-volume.c b/tools/virsh-volume.c index 36dd0ed..9cc8e52 100644 --- a/tools/virsh-volume.c +++ b/tools/virsh-volume.c @@ -546,7 +546,7 @@ static const vshCmdInfo info_vol_clone[] = { .data = N_("clone a volume.") }, {.name = "desc", - .data = N_("Clone an existing volume.") + .data = N_("Clone an existing volume within the parent pool.") }, {.name = NULL} }; diff --git a/tools/virsh.pod b/tools/virsh.pod index 6c9d4ec..e1c0d8e 100644 --- a/tools/virsh.pod +++ b/tools/virsh.pod @@ -3530,10 +3530,10 @@ only slightly higher initial disk space usage. =item B [I<--pool> I] I I [I<--prealloc-metadata>] [I<--reflink>] -Clone an existing volume. Less powerful, but easier to type, version of -B. +Clone an existing volume within the parent pool. Less powerful, +but easier to type, version of B. I<--pool> I is the name or UUID of the storage pool to create -the volume in. +that contains the source volume, and will contain the new volume. I is the name or key or path of the source volume. I is the name of the new volume. [I<--prealloc-metadata>] preallocate metadata (for qcow2 images which don't