From patchwork Tue Jan 31 09:42:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 648922 Delivered-To: patch@linaro.org Received: by 2002:a17:522:d8c:b0:4be:c3dc:14d8 with SMTP id d12csp1639708pva; Tue, 31 Jan 2023 01:42:51 -0800 (PST) X-Google-Smtp-Source: AMrXdXvllAsqowujre1qKCwbq3jjnkyJZR0vOsyyx7xerBAeKtkR+BwO5uF2NULPTaGscOMWy6mw X-Received: by 2002:ac8:5545:0:b0:3b6:2f0d:1925 with SMTP id o5-20020ac85545000000b003b62f0d1925mr71624830qtr.64.1675158171226; Tue, 31 Jan 2023 01:42:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675158171; cv=none; d=google.com; s=arc-20160816; b=uOVcxXTxeHhqlRckR16jkTBSrWBUFwQnVqGwL8dlwCIEXhU8hIuJnBlHhMdYdUyJnX Ng3hYkbq0A+48yzWRp3BIaDNguk+VI3UlyT4NHSR73cMOc86BVuAZB4CEzg16HR+rUC+ 1Vs7WN/+JFpypcPSsRPA43PCeMVMu5yBWLc+HXEOIwRmrPUsDXV1OGEHmCqOKR6LAQaJ KiwaI06ES9bZUAE02BpgAYX9fjvTHG21xdFsK/dbdiOBT2bpwgvHpOchGymN5OwMNJRm mYkHZbJE0PuN2FtQybV7q2pOPueNMTLvx3SIbvGVzQaXDrrZBZebn0MoG7AG0igP2xal zfsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:sender:errors-to:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:message-id:date:subject:to:from :delivered-to:delivered-to:dkim-signature; bh=OLR+bI0/lJP2K0uDO1O4tQXfXXXstBm7WjMh3wgoSZY=; b=Wn5UicS/jTex28xnYqDTRhBMs+AA11nHzyp6Yw1UzAtxWDaF7gwFwfbpagNjTDlfzi ByhkFsJ6zO6D0kaUWY/x9EJ6UiFXMCUX4lUcmjGz/C3TTwIJkYoRPjFCxqePu/xeR9Z9 TyZD7BmGVhaXKlfEeZTlkGphAn2NFPlVSKuGTuPeQUSTL7FaGaYFUwYNekRCyoDakZft YjQkwPY1lriIXoS1Zuwdhehu2rXlTeuxsxV1kcA1GkxvMsYba7Cuzuhu9MjovU0EHMwZ SwB5SGtIJ/jfqwQaKtkaTEt8d/aJ7b6MFmBDB0nbD9hZhpw/1lkWYufW304WPlK1hBih d/qw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=i6Pg7NRD; spf=pass (google.com: domain of libvir-list-bounces@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com. [170.10.133.124]) by mx.google.com with ESMTPS id d19-20020ac800d3000000b003b82e3623easi5674514qtg.414.2023.01.31.01.42.51 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Jan 2023 01:42:51 -0800 (PST) Received-SPF: pass (google.com: domain of libvir-list-bounces@redhat.com designates 170.10.133.124 as permitted sender) client-ip=170.10.133.124; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=i6Pg7NRD; spf=pass (google.com: domain of libvir-list-bounces@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675158170; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=OLR+bI0/lJP2K0uDO1O4tQXfXXXstBm7WjMh3wgoSZY=; b=i6Pg7NRD06Q4strkM2OEYfhYZWcrNdpKmNI6rB7W27zIGHgM5uCsROh6OQcGhNY/L7DZGR /M/suKVPyHAmgBgITrzpWBoNuKZ+jK/vUAHXPF7D5C/pS6lCENsTy2uD2Zdbu6twBB8Zpf K8lcj7eywMLNrKxdXAefhD51XZAX6gk= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-614-t4civ3MFNPOl9CoJ-OThdQ-1; Tue, 31 Jan 2023 04:42:47 -0500 X-MC-Unique: t4civ3MFNPOl9CoJ-OThdQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 34446855304; Tue, 31 Jan 2023 09:42:45 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (unknown [10.30.29.100]) by smtp.corp.redhat.com (Postfix) with ESMTP id 389D214171B6; Tue, 31 Jan 2023 09:42:42 +0000 (UTC) Received: from mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (localhost [IPv6:::1]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id B35741946589; Tue, 31 Jan 2023 09:42:41 +0000 (UTC) X-Original-To: libvir-list@listman.corp.redhat.com Delivered-To: libvir-list@listman.corp.redhat.com Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) by mm-prod-listman-01.mail-001.prod.us-east-1.aws.redhat.com (Postfix) with ESMTP id E5AB01946587 for ; Tue, 31 Jan 2023 09:42:40 +0000 (UTC) Received: by smtp.corp.redhat.com (Postfix) id B533A40C141B; Tue, 31 Jan 2023 09:42:40 +0000 (UTC) Delivered-To: libvir-list@redhat.com Received: from mimecast-mx02.redhat.com (mimecast07.extmail.prod.ext.rdu2.redhat.com [10.11.55.23]) by smtp.corp.redhat.com (Postfix) with ESMTPS id ACDE840C1255 for ; Tue, 31 Jan 2023 09:42:40 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8F3BD3C0F220 for ; Tue, 31 Jan 2023 09:42:40 +0000 (UTC) Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-564--4RVogKXNcecrvY_4UOIfw-1; Tue, 31 Jan 2023 04:42:39 -0500 X-MC-Unique: -4RVogKXNcecrvY_4UOIfw-1 Received: by mail-wm1-f45.google.com with SMTP id l8so9880519wms.3 for ; Tue, 31 Jan 2023 01:42:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OLR+bI0/lJP2K0uDO1O4tQXfXXXstBm7WjMh3wgoSZY=; b=MaLPmkHAOVmkglkdCHf9yHgrvkGFedWIi2VDItBxqFK9nyPDtnq+rOdgfE5v26s7Uh Uc+GP/ECmb+y1+kGotGIxDIZNtlyAy9WSMgocEbNOEUx3tDbKIwYOfNeZCaLzyclawa3 us5W3RKAeWa6Rh4yMypblAXvFDimvHPZdH+p4UVZk3BfM3Ywjl0x4yt5sowD1WKaluL4 xPNTSKcjj/qvZkv1fqH2bWPQyMKBvHJNBKB/oAyH8V+OH/WiBBswIp2xu4cY1FY+/0G8 3d0BoQp67CmVToxOME5rzcFBuEileNBcNxM1XJ7ElCRjw6rARFJKck+xyXsP/ZhM/zLR kamg== X-Gm-Message-State: AO0yUKUTJo/c8K4eUKxsoFsdh0WfvjQhY/eYdeQH/T5W0hR67cREjWlM kD7K++4UHprRCN0DKOQRWBsIzQ== X-Received: by 2002:a05:600c:3d18:b0:3dc:2c58:e6f2 with SMTP id bh24-20020a05600c3d1800b003dc2c58e6f2mr18525551wmb.4.1675158157740; Tue, 31 Jan 2023 01:42:37 -0800 (PST) Received: from zen.linaroharston ([185.81.254.11]) by smtp.gmail.com with ESMTPSA id 3-20020a05600c248300b003db0ad636d1sm8311909wms.28.2023.01.31.01.42.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Jan 2023 01:42:37 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id CC1E51FFB7; Tue, 31 Jan 2023 09:42:36 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [RFC PATCH] build: deprecate --enable-gprof builds and remove from CI Date: Tue, 31 Jan 2023 09:42:23 +0000 Message-Id: <20230131094224.861621-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , Beraldo Leal , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , "reviewer:Incompatible changes" , Wainer dos Santos Moschetta , =?utf-8?q?Marc-Andr?= =?utf-8?q?=C3=A9_Lureau?= , Paolo Bonzini , =?utf-8?q?Alex_Benn=C3=A9e?= Errors-To: libvir-list-bounces@redhat.com Sender: "libvir-list" X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com As gprof relies on instrumentation you rarely get useful data compared to a real optimised build. Lets deprecate the build option and simplify the CI configuration as a result. Signed-off-by: Alex Bennée Cc: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé --- docs/about/deprecated.rst | 14 ++++++++++++++ meson.build | 7 ++++++- .gitlab-ci.d/buildtest.yml | 19 ++++--------------- meson_options.txt | 3 ++- 4 files changed, 26 insertions(+), 17 deletions(-) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 9f1bbc495d..87b4511535 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -20,6 +20,20 @@ they were first deprecated in the 2.10.0 release. What follows is a list of all features currently marked as deprecated. +Build options +------------- + +``gprof`` builds (since 8.0) +'''''''''''''''''''''''''''' + +The ``--enable-gprof`` configure setting relies on compiler +instrumentation to gather its data which can distort the generated +profile. As other non-instrumenting tools are available that give a +more holistic view of the system with non-instrumented binaries we are +deprecating the build option and no longer defend it in CI. The +``--enable-gcov`` build option remains for analysis test case +coverage. + System emulator command line arguments -------------------------------------- diff --git a/meson.build b/meson.build index 56320ae717..ecf44ea534 100644 --- a/meson.build +++ b/meson.build @@ -3791,7 +3791,12 @@ summary_info += {'mutex debugging': get_option('debug_mutex')} summary_info += {'memory allocator': get_option('malloc')} summary_info += {'avx2 optimization': config_host_data.get('CONFIG_AVX2_OPT')} summary_info += {'avx512f optimization': config_host_data.get('CONFIG_AVX512F_OPT')} -summary_info += {'gprof enabled': get_option('gprof')} +if get_option('gprof') + gprof_info = 'YES (deprecated)' +else + gprof_info = get_option('gprof') +endif +summary_info += {'gprof': gprof_info} summary_info += {'gcov': get_option('b_coverage')} summary_info += {'thread sanitizer': config_host.has_key('CONFIG_TSAN')} summary_info += {'CFI support': get_option('cfi')} diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml index 9a6ba1fe3b..dc8fa0a498 100644 --- a/.gitlab-ci.d/buildtest.yml +++ b/.gitlab-ci.d/buildtest.yml @@ -468,27 +468,16 @@ tsan-build: TARGETS: x86_64-softmmu ppc64-softmmu riscv64-softmmu x86_64-linux-user MAKE_CHECK_ARGS: bench V=1 -# gprof/gcov are GCC features -build-gprof-gcov: +# gcov is a GCC features +gcov: extends: .native_build_job_template needs: job: amd64-ubuntu2004-container + timeout: 80m variables: IMAGE: ubuntu2004 - CONFIGURE_ARGS: --enable-gprof --enable-gcov + CONFIGURE_ARGS: --enable-gcov TARGETS: aarch64-softmmu ppc64-softmmu s390x-softmmu x86_64-softmmu - artifacts: - expire_in: 1 days - paths: - - build - -check-gprof-gcov: - extends: .native_test_job_template - needs: - - job: build-gprof-gcov - artifacts: true - variables: - IMAGE: ubuntu2004 MAKE_CHECK_ARGS: check after_script: - cd build diff --git a/meson_options.txt b/meson_options.txt index 559a571b6b..53459c15fc 100644 --- a/meson_options.txt +++ b/meson_options.txt @@ -316,7 +316,8 @@ option('debug_stack_usage', type: 'boolean', value: false, option('qom_cast_debug', type: 'boolean', value: false, description: 'cast debugging support') option('gprof', type: 'boolean', value: false, - description: 'QEMU profiling with gprof') + description: 'QEMU profiling with gprof', + deprecated: true) option('profiler', type: 'boolean', value: false, description: 'profiler support') option('slirp_smbd', type : 'feature', value : 'auto',