From patchwork Fri Apr 22 21:59:37 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cole Robinson X-Patchwork-Id: 66498 Delivered-To: patch@linaro.org Received: by 10.140.93.198 with SMTP id d64csp956440qge; Fri, 22 Apr 2016 15:02:38 -0700 (PDT) X-Received: by 10.176.1.117 with SMTP id 108mr12267585uak.49.1461362558887; Fri, 22 Apr 2016 15:02:38 -0700 (PDT) Return-Path: Received: from mx6-phx2.redhat.com (mx6-phx2.redhat.com. [209.132.183.39]) by mx.google.com with ESMTPS id h5si1686175uad.21.2016.04.22.15.02.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 Apr 2016 15:02:38 -0700 (PDT) Received-SPF: pass (google.com: domain of libvir-list-bounces@redhat.com designates 209.132.183.39 as permitted sender) client-ip=209.132.183.39; Authentication-Results: mx.google.com; spf=pass (google.com: domain of libvir-list-bounces@redhat.com designates 209.132.183.39 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by mx6-phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u3MLxf4R013665; Fri, 22 Apr 2016 17:59:42 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id u3MLxeOV029548 for ; Fri, 22 Apr 2016 17:59:40 -0400 Received: from colepc.redhat.com (ovpn-113-101.phx2.redhat.com [10.3.113.101]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u3MLxeNH029580; Fri, 22 Apr 2016 17:59:40 -0400 From: Cole Robinson To: libvirt-list@redhat.com Date: Fri, 22 Apr 2016 17:59:37 -0400 Message-Id: <16c76926ec34c082e70765cdddee303e13922a3c.1461362377.git.crobinso@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH] vbox: VIR_WARN if we don't support the API version X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com We presently don't give any indication if the VirtualBox version isn't in our support whitelist. --- src/vbox/vbox_common.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) -- 2.7.3 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list diff --git a/src/vbox/vbox_common.c b/src/vbox/vbox_common.c index 0cead10..50ebdba 100644 --- a/src/vbox/vbox_common.c +++ b/src/vbox/vbox_common.c @@ -7856,7 +7856,11 @@ virHypervisorDriverPtr vboxGetHypervisorDriver(uint32_t uVersion) /* Install gVBoxAPI according to the vbox API version. */ int result = 0; installUniformedAPI(gVBoxAPI, result); - if (result < 0) return NULL; + if (result < 0) { + VIR_WARN(_("Libvirt doesn't support VirtualBox API version %u"), + uVersion); + return NULL; + } updateDriver(); return &vboxCommonDriver; }