From patchwork Sun Apr 24 20:58:46 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cole Robinson X-Patchwork-Id: 66545 Delivered-To: patch@linaro.org Received: by 10.140.93.198 with SMTP id d64csp721003qge; Sun, 24 Apr 2016 14:01:48 -0700 (PDT) X-Received: by 10.194.23.226 with SMTP id p2mr30541658wjf.131.1461531707946; Sun, 24 Apr 2016 14:01:47 -0700 (PDT) Return-Path: Received: from mx5-phx2.redhat.com (mx5-phx2.redhat.com. [209.132.183.37]) by mx.google.com with ESMTPS id c125si15727853wmf.81.2016.04.24.14.01.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 24 Apr 2016 14:01:47 -0700 (PDT) Received-SPF: pass (google.com: domain of libvir-list-bounces@redhat.com designates 209.132.183.37 as permitted sender) client-ip=209.132.183.37; Authentication-Results: mx.google.com; spf=pass (google.com: domain of libvir-list-bounces@redhat.com designates 209.132.183.37 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by mx5-phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u3OKwwIv013809; Sun, 24 Apr 2016 16:58:59 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id u3OKwu4E031836 for ; Sun, 24 Apr 2016 16:58:56 -0400 Received: from colepc.redhat.com (ovpn-113-101.phx2.redhat.com [10.3.113.101]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u3OKwrw8010332; Sun, 24 Apr 2016 16:58:56 -0400 From: Cole Robinson To: libvirt-list@redhat.com Date: Sun, 24 Apr 2016 16:58:46 -0400 Message-Id: <108acc5d4cc9bbae76b52787a0ff61ecc0dd0785.1461531451.git.crobinso@redhat.com> In-Reply-To: References: In-Reply-To: References: X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 2/2] daemon: stream: Don't log error when client aborts X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com Every time a client aborts a stream via the virStreamAbort API, the daemon always logs an error like: error : daemonStreamHandleAbort:617 : stream aborted at client request For example, this message is logged any time the user disconnects from 'virsh console'. However this isn't really an error condition, and instead the result of a successful RPC call to abort the stream. Downgrade the message to VIR_INFO --- daemon/stream.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.7.3 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list diff --git a/daemon/stream.c b/daemon/stream.c index c892dcb..d2f85ad 100644 --- a/daemon/stream.c +++ b/daemon/stream.c @@ -613,8 +613,7 @@ daemonStreamHandleAbort(virNetServerClientPtr client, virStreamAbort(stream->st); if (msg->header.status == VIR_NET_ERROR) { - virReportError(VIR_ERR_RPC, - "%s", _("stream aborted at client request")); + VIR_INFO("stream aborted at client request"); } else { VIR_WARN("unexpected stream status %d", msg->header.status); virReportError(VIR_ERR_RPC,