From patchwork Thu Sep 26 21:18:39 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cole Robinson X-Patchwork-Id: 174549 Delivered-To: patch@linaro.org Received: by 2002:a92:7e96:0:0:0:0:0 with SMTP id q22csp2613034ill; Thu, 26 Sep 2019 14:24:41 -0700 (PDT) X-Google-Smtp-Source: APXvYqzVL7X9qwt3GaawhQtDeGzfMJdPPbwG9li/M0ZPtTIzYQgpzHGqOYJYOFnzvWu+nUi4SBv2 X-Received: by 2002:a6b:7b01:: with SMTP id l1mr5416818iop.292.1569533081487; Thu, 26 Sep 2019 14:24:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569533081; cv=none; d=google.com; s=arc-20160816; b=ofVl2YNoIVv8q6yxYWl9oh9GoltdBr40PXqigQ4EquAPsLO+6t/YQx6LhabMvixvg+ +PyuoFkegM0vufLuuC6CLc4vaeaMafhf2xNRckuDedAEbet2OUr3Wt2OX6PC80VV8sef iS5gLY4Or+FLWPwHwBw/olQt3YGUIplQ/xIxVUmKzXUI5jIFSNyItgV0Hzdt++7LV69d oz42hzbH6CNFrD9v+Um3xsqIjfRFtfNv3vjDGSvnhrgUOFVny7M6jRz8GRZfsQKz1sSO gB00f3qMFrUK+XHexuUFgAw1mYxgQHug4NcvRUvVmsO4tNwn98HN2F/ZLP+l1fUTOz4P GNMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:sender:content-transfer-encoding:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence:subject :mime-version:message-id:date:to:from:delivered-to; bh=zq9SGEs+0B9sKcmQw/vZQ3c7a7jyOanF8YekT/LPF6A=; b=vPQtxXMWd7RIQ251D3ezHN8koPTPQPR0tYDy+eriYoXzBjU4D1fSLWJU8qk5UR89nB oyN8eAcZVr8zerk4j45h4158qIPAGIyrzcfsKy5z6q4tuXJyh5Qx9e8DKEpc5y95uq70 onCCZxnayQLqMTdyF+oAx5bZZxdhmDrTrfkMc+g0HdC38Yv7Wt5mGtTpWkEBtodayhhw UVlO5Tynhd2qf92fNfMor27RngXBLp7r54LEDZ4LERp8JF8xUYMXI8EkZUZUwx6Ib/NA E3rv9XMdEcuDK4mMPm6J4DUOOZtTyUpFK/wWin7yDmaFdtpS+x9A4u7PxErY34I4JF9z 1tEw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of libvir-list-bounces@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from mx1.redhat.com (mx1.redhat.com. [209.132.183.28]) by mx.google.com with ESMTPS id i19si3644471jal.70.2019.09.26.14.24.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 26 Sep 2019 14:24:41 -0700 (PDT) Received-SPF: pass (google.com: domain of libvir-list-bounces@redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; Authentication-Results: mx.google.com; spf=pass (google.com: domain of libvir-list-bounces@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=libvir-list-bounces@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 40D6E10DCC82; Thu, 26 Sep 2019 21:24:40 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1A55660BE2; Thu, 26 Sep 2019 21:24:40 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 9C0AA4E589; Thu, 26 Sep 2019 21:24:39 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id x8QLIUfN018365 for ; Thu, 26 Sep 2019 17:18:30 -0400 Received: by smtp.corp.redhat.com (Postfix) id 9CE7560A9F; Thu, 26 Sep 2019 21:18:30 +0000 (UTC) Delivered-To: libvirt-list@redhat.com Received: from worklaptop.redhat.com (ovpn-123-202.rdu2.redhat.com [10.10.123.202]) by smtp.corp.redhat.com (Postfix) with ESMTP id E78A0608C2; Thu, 26 Sep 2019 21:18:27 +0000 (UTC) From: Cole Robinson To: libvirt-list@redhat.com Date: Thu, 26 Sep 2019 17:18:39 -0400 Message-Id: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-loop: libvir-list@redhat.com Subject: [libvirt] [PATCH 0/2] Fix cgroupv2 issue on Fedora 31 X-BeenThere: libvir-list@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Development discussions about the libvirt library & tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: libvir-list-bounces@redhat.com Errors-To: libvir-list-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.64]); Thu, 26 Sep 2019 21:24:40 +0000 (UTC) There's been a bunch of reports of VM startup failures on Fedora 31 and elsewhere: https://bugzilla.redhat.com/show_bug.cgi?id=1751120 The reproducer I found is running a mock build, which adds a name=systemd cgroup to /proc/self/cgroup, which messes up libvirt's logic. The first patch has a bit more detail. I'm not positive this is entirely correct... maybe we should be doing something with that cgroup in some way? I'm kinda ignorant here. I also filed a systemd bug incase that behavior is unintentional. We probably want to change libvirt regardless though https://bugzilla.redhat.com/show_bug.cgi?id=1756143 Cole Robinson (2): vircgroupv2: Fix VM startup when legacy cgroups are defined vircgroup: Add some VIR_DEBUG statements src/util/vircgroup.c | 3 ++- src/util/vircgroupv2.c | 15 ++++++++++++++- 2 files changed, 16 insertions(+), 2 deletions(-) -- 2.23.0 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list