From patchwork Wed Apr 30 19:43:37 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella Netto X-Patchwork-Id: 886080 Delivered-To: patch@linaro.org Received: by 2002:a5d:4884:0:b0:38f:210b:807b with SMTP id g4csp1033314wrq; Wed, 30 Apr 2025 12:44:22 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWEGcYt4rWTxYg90Mz/YfCOH018BjNmt9AXkK8R9Vbcfe/sxsCOMS8XR/mJgY8ol54kiwxz9Q==@linaro.org X-Google-Smtp-Source: AGHT+IGNxkTOzArdOh+7gs+N1vRXcwhrlZ9pS/n/QYAE7qhDcKxhDmBp8Pd8uRN18ea4g+C2D05P X-Received: by 2002:ac8:6907:0:b0:48a:1f89:f933 with SMTP id d75a77b69052e-48ae714e254mr8302271cf.8.1746042262668; Wed, 30 Apr 2025 12:44:22 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1746042262; cv=pass; d=google.com; s=arc-20240605; b=jJ5tJ+6jsfO5MrbYZM4Pw8Nphjo5jIZSe7XMhV5ONljXsH3Nr4gmsJSdtG0A3QqtWW 6eLWTcHuc47RL/7AC3uUk7Pq/Zw9mdHuzZBgEyQH3543uvhjVmXGOuMs8NY5t3g9KqOT HiuvjhiEUqvF5BysFMHVZN+Anwi0zxx9iZOjNJc6ljLTS3D9gBWUGVQezRRiM9NBC+NY pq4/ydS667iKUWD9coINxD+KGLNjHPIbJOBj+dP915MOs6vhPSOpOeNYeTP+xNclXKki Y/7jrqesIN0FV6QJxkCNkJ+yHCtEnNCAy7fjoXNU2Odl8GVWUbjHoGuZMJC6Z8C4bpJ/ ZaDA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:to:from:dkim-signature :dkim-filter:arc-filter:dmarc-filter:delivered-to:dkim-filter; bh=nJEtOUBiuByVFnZiX+hxLy/dwlxpxQjz/1+O2Xwu5Ss=; fh=dHLBnA+MhGtNtN2B2JMAELi4oD+gmgMg7DL8H0jYbkI=; b=S5wd/sHDcu9tS8fIii9pmaCGZR+tyF/ZP77CMbAOpY7B3BIm+AmL4FuLpIzjTIxXqq S5MW4FXetA64CMlwtsjf6J9kee3G2cjbQdW6N91caR3iJQxXU7Bbm+eMGuSDviF3V7gf sMzYToe6+wYyleDsdPoBfF/Aq+2NbkyX7FShmHvWDfxZCc1J4K8lozUpxTn2JDNSq1ir yFp/b0Cq5waEt1kxR1RUCJNl4Rkz6v0KOMravSjCAuzCGcA9dZSmhb42Ig8d0uK10HlA J4jFuQ1FVjNEHVjcQ+Ivc5jfdBsaY488PwdylVwb/tbUtMoQ/+7RXaXkdu7vmMPwZ281 i5eQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="fhcrTAM/"; arc=pass (i=1); spf=pass (google.com: domain of libc-alpha-bounces~patch=linaro.org@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="libc-alpha-bounces~patch=linaro.org@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id d75a77b69052e-47ea27a3e88si137946801cf.587.2025.04.30.12.44.22 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Apr 2025 12:44:22 -0700 (PDT) Received-SPF: pass (google.com: domain of libc-alpha-bounces~patch=linaro.org@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="fhcrTAM/"; arc=pass (i=1); spf=pass (google.com: domain of libc-alpha-bounces~patch=linaro.org@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="libc-alpha-bounces~patch=linaro.org@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3E5FF3858D34 for ; Wed, 30 Apr 2025 19:44:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3E5FF3858D34 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=fhcrTAM/ X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com [IPv6:2607:f8b0:4864:20::52e]) by sourceware.org (Postfix) with ESMTPS id AF9873858D29 for ; Wed, 30 Apr 2025 19:44:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AF9873858D29 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AF9873858D29 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::52e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1746042246; cv=none; b=LHoDbcqYMtCeSWeelg/J9RIRDIloknunOUPSvGjhkwu1tJw3nM0tsw2XGNRg4KE8dl2X4BIXXG6BTGVrnPN6pbmIQdVld2ORhO7Ss6uVNk2NydBrqSuVeHqv5yc59L9XQQS+c+bUX+vF3WcGtItDdX0tMRPa47ARtXeNsWCcXPI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1746042246; c=relaxed/simple; bh=zcuPkA8ylJQwKvs+yvTB7ftfSbYcVHq+aRmKF2oPpJA=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=oCtRbhpS2D7r7g0MMj/4Sqpeh5GOMieOerVs+PAiu+jgH0rB2GOMr/ol0wLsluaengipGEf2Ob4PMn5ESp75jhHiARvxh5AXcUeGS0OeaXlg1sQlmfh3zjRItELpF6xqqGHxe2u6cxqguJVSKTx2hENeXbFLMtC7B4ikhNSPLC4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AF9873858D29 Received: by mail-pg1-x52e.google.com with SMTP id 41be03b00d2f7-af91fc1fa90so222270a12.0 for ; Wed, 30 Apr 2025 12:44:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1746042245; x=1746647045; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=nJEtOUBiuByVFnZiX+hxLy/dwlxpxQjz/1+O2Xwu5Ss=; b=fhcrTAM/nUL3+gccjic4ZWan65k10gh3Kwkow8+574x8bmK45Y3DMUvWino8xAgYWD SQRiyGm4xIKMM9uyFxjSnvfN0zIF/7oQSSj8/jU5mIQX5iqy6J8b47EbGpY61isGiIk6 7lH9FqjfxvPFwooy2YHjx82syyXlc2coj5YXC6DxjBomGZQV0fIC90eQTYXYlJKm8OsE fhdOk3NjZ75fiK73zePDtIjfFKvOG18apUayGptYZjoCna8MShXI8Ukh+nCbnRkqa6NX NxDM6BOFIS98hzoazgsAIzUkrd0OAtNKN2LTdKkVHQKPtAjVpsFFR15t0WPAAsqg2Df8 RPuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746042245; x=1746647045; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nJEtOUBiuByVFnZiX+hxLy/dwlxpxQjz/1+O2Xwu5Ss=; b=qClLJhco26hHfpHPFW9HBCRtU5UzaMhEiv8iah06leLFhB3so4bsHDWwWVPWk5HBZ6 Nj9G7Yln37O93J+trEsHtoacoQHM1IRhgNSe70GYjjSfN+hBmsK2Pc8SA5Az1FWpLJzS 6SOz1Z/3h6X+VmakygO6nV7Z4LPBTxBvb4ger3waCkMBL/oTfSaYGVmDGbLa4g3xKzRb 68Jr0sJTMbOhbZBf/qlTQeyUIVE92VWvfjReNTmD2shctidP0T2GhlZII/XigYjB4SHf 5PH7QyIcS1X0pXQ+eOO+29mI8Q1X2R9ui5IHyxPnsLWVWXx3/Bme4nBlgSpMGOHb7Nmm BVCg== X-Gm-Message-State: AOJu0YxLWjllRNRtvPhDSLV/XoASHpTM4H4MKa9UqE+1B1dz73MtaPFx 5VUz9J6LwIvyLqLuc4n2GGmq047bKr0Wtfr5YVp5v84Q45yhWkyzuMHb61NPRVEfBmGqJpgGN5M z X-Gm-Gg: ASbGncsAlcyvGUCyJR1xkKbKi31LaEB5UPKYFgz8yGOS53Fd01f9O59dCq84evl6hf8 RShJ3hYw9cUf3ohfRHo5igPCBmId/dfUxu4mlAO9AwvX1Z8/6JEDp+Go53WwYvOKvxW645MvAFd hs3MNl+ziwnhsxGujLYQvwoYTZ7q8P1Cf6BC0qJmpUfuGcQ/zb/23/jXXMUIBB6FAVlRo2WCd/z dzcbK+bUovlUC15OYIB0MV8XiCO8zYwNrfpozv4j+rpva2ioxBHP99hGphez7JzMkHRkrv03285 lheGTc/qhwJtdeKLDl8a2sI60X9NQYpOGxqM9A+vixVlACEU+qC0qNRiK/00OlEF X-Received: by 2002:a05:6a20:548d:b0:1f5:6f95:2544 with SMTP id adf61e73a8af0-20ba87881fdmr605591637.33.1746042245396; Wed, 30 Apr 2025 12:44:05 -0700 (PDT) Received: from mandiga.. ([2804:1b3:a7c0:9bf1:520e:5fbc:7cda:b6af]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-740398f9d67sm2084839b3a.30.2025.04.30.12.44.04 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Apr 2025 12:44:05 -0700 (PDT) From: Adhemerval Zanella To: libc-alpha@sourceware.org Subject: [PATCH] stdlib: Fix __libc_message_impl iovec size Date: Wed, 30 Apr 2025 16:43:37 -0300 Message-ID: <20250430194401.818624-1-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces~patch=linaro.org@sourceware.org The iovec size should account for all substrings between each conversion specification. For the format: "abc %s efg" The list of substrings are: ["abc ", arg, " efg] which is 2 times the number of maximum arguments *plus* one. This issue triggered 'out of bounds' errors by stdlib/tst-bz20544 when glibc is built with experimental UBSAN support [1]. Checked on x86_64-linux-gnu. [1] https://sourceware.org/git/?p=glibc.git;a=shortlog;h=refs/heads/azanella/ubsan-undef --- sysdeps/posix/libc_fatal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sysdeps/posix/libc_fatal.c b/sysdeps/posix/libc_fatal.c index d90cc6c681..25ef20cfc1 100644 --- a/sysdeps/posix/libc_fatal.c +++ b/sysdeps/posix/libc_fatal.c @@ -61,7 +61,7 @@ __libc_message_impl (const char *fmt, ...) if (fd == -1) fd = STDERR_FILENO; - struct iovec iov[LIBC_MESSAGE_MAX_ARGS * 2 - 1]; + struct iovec iov[LIBC_MESSAGE_MAX_ARGS * 2 + 1]; int iovcnt = 0; ssize_t total = 0;