From patchwork Mon Oct 2 19:33:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella Netto X-Patchwork-Id: 728563 Delivered-To: patch@linaro.org Received: by 2002:a5d:60c8:0:b0:31d:da82:a3b4 with SMTP id x8csp1820046wrt; Mon, 2 Oct 2023 12:34:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGskLAeJt47UXNHo57wSGBUOql8wa/UWUmOai4OhoWjXd6VgwLiNRqnE5ztm/28A+bsSiEi X-Received: by 2002:aa7:c0ca:0:b0:521:d2ab:e4df with SMTP id j10-20020aa7c0ca000000b00521d2abe4dfmr520212edp.19.1696275259982; Mon, 02 Oct 2023 12:34:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696275259; cv=none; d=google.com; s=arc-20160816; b=lgHM5n6sb0yX3QV0YEnsEJK46GZra7o55fUdg6aMWauE4TnENsGPlwsL734c8HpA5G M3Cn9YSjBnwPB50O5CfILEWm6ppunVJHTVPIwoK0+6dv/981CTmtMd4JSGJbNlPN3q+I DfIGJrreyIUzpzPdyB0Y30gIc3bQNONOoOUQysJTiKXkM7qS7kg3oNXGTs1eBRgLPxE2 /+fZujuzhHbeKSLz5d9UpILowpAHwhwbW6XW2C1siVBkXX8PutI9hShrSLpW+3zDj05k hm2kZqCoRGLNXhG2Q7iIktUxSBHjKjmVj02YffXEqNgYzUHEUBzhVSaBRc6hS3oB3j7T ge7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature:dmarc-filter:delivered-to; bh=LVH9FPyqXhMnof20qz68Oz9ngaGXWyE1ZxEz6o7y/lg=; fh=ubzLPtaquqORyAJ/TX35zypB35/iXKzZJOEWlgP8mu4=; b=iVBNdN2x2zri+4wTnjbdf1gs+Y7aIA9p1ezZtiukJPEGj5gdlUL4fuwpoUvD5y7xVW mHiFFWOvL+j9hufxTtkXgBqj9QkueaIC0472zPDwVuq3CsuyjDmp1y25UCMc26vldi4i KkrdQ5paXVjOYMrWbsVKFicn5zwRRBbL4anNEbb4tdhNqsdWxqZwqW9PNJig07k7I8wm uwZapyv4yU3WGMvxn8GtTNAhlCtu56o/NW+SefsrRwJU00R3te2LWInB8xmQwKSN+jgF WbHKdZ6cscB5xrr2fGUuNfR9kksuoMbxdhGs8E/dpgfhVMD/JcLoCg4dOyVgDxPwPp/n DMkQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="W/Y+ofvJ"; spf=pass (google.com: domain of libc-alpha-bounces+patch=linaro.org@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="libc-alpha-bounces+patch=linaro.org@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id z5-20020aa7d405000000b00532c6fcb85esi18356525edq.143.2023.10.02.12.34.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Oct 2023 12:34:19 -0700 (PDT) Received-SPF: pass (google.com: domain of libc-alpha-bounces+patch=linaro.org@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="W/Y+ofvJ"; spf=pass (google.com: domain of libc-alpha-bounces+patch=linaro.org@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="libc-alpha-bounces+patch=linaro.org@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A90B1386188F for ; Mon, 2 Oct 2023 19:34:18 +0000 (GMT) X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by sourceware.org (Postfix) with ESMTPS id B54A63858024 for ; Mon, 2 Oct 2023 19:33:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B54A63858024 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-pl1-x62f.google.com with SMTP id d9443c01a7336-1c60778a3bfso1301935ad.1 for ; Mon, 02 Oct 2023 12:33:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1696275206; x=1696880006; darn=sourceware.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=LVH9FPyqXhMnof20qz68Oz9ngaGXWyE1ZxEz6o7y/lg=; b=W/Y+ofvJdq4b8xnt5gXpF0UgeUdZ/oMSZQlyJVgMj7pCOeLVW5CZq3vG2/46qbwqNZ Gz4EULsJbaMi7U1+G7iOX/qqqI/8PU9qLyT+O2mbgUEwaDQXq/pB5RCom4UnNEgGm1Y7 1W7bGm6TO9+Wv5mUVi1tjT2R/hIIQuXFZ73eOZZsm+xMrvEJhShcqlO/bJWKrXSAeYxC 7tmjcQwnbLHpilSBXcZBEcb1gcgCeI7spUvjaAS4NYr4jQ58vjOmZq2DheARs4zYFAF+ 3k6r+RdYBidbaBqiDZy8JpLEFR/2nJdVxBtSOPk7U6oGiG3XKMqMyU8EVrGZYT7kcOue mOUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696275206; x=1696880006; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LVH9FPyqXhMnof20qz68Oz9ngaGXWyE1ZxEz6o7y/lg=; b=PyxHUE2lHxfFM7/X/1z5AT1BhOuMKq1wGJZqAPuWfCkn1QuGJvHdUwGbiMDylXXOeI M9XY8xt9RB9JEmgCvYZcpSf7R1CnE2NVUAHxFLlU7zYsWjy3Yw/OdUkGGlVdipnelCC/ 3Sv6dPmDXq2nYcHxXgfd1zXhiV7dMsyeVRQ+T4XLbgtQcFI2pFbgwC8PefJ/zkarKDYi Iymolo22cyYzogTRww6H9D7dRQpYiB/FBkKyfiuWuVcoWr9NVMXK4+6L2pycmYiNWSgc k2qETQ4p6hfn3AnnQYMFfjH4G3+WAOhELoUwosIgzlfNZf8K4KSdDvtFsM7s5v6DRTkW ccmw== X-Gm-Message-State: AOJu0YxAEFkTDsg3db4sA5I1UPLhah18syCQDdcgOKAhoBFdLlUPOH/E 4cOcBZSMLRhXGNd7yUQCheBrvvCiZXi38M70j3hFzA== X-Received: by 2002:a17:902:9a44:b0:1bd:aeb3:9504 with SMTP id x4-20020a1709029a4400b001bdaeb39504mr11784918plv.15.1696275206267; Mon, 02 Oct 2023 12:33:26 -0700 (PDT) Received: from mandiga.. ([2804:1b3:a7c1:feaf:8f32:80e:c10a:4836]) by smtp.gmail.com with ESMTPSA id u10-20020a170902b28a00b001c7453fae33sm6982828plr.280.2023.10.02.12.33.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Oct 2023 12:33:25 -0700 (PDT) From: Adhemerval Zanella To: libc-alpha@sourceware.org, Noah Goldstein , Paul Eggert , Florian Weimer Subject: [PATCH v8 5/7] stdlib: Implement introsort for qsort (BZ 19305) Date: Mon, 2 Oct 2023 16:33:09 -0300 Message-Id: <20231002193311.3985890-6-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231002193311.3985890-1-adhemerval.zanella@linaro.org> References: <20231002193311.3985890-1-adhemerval.zanella@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces+patch=linaro.org@sourceware.org This patch makes the quicksort implementation to acts as introsort, to avoid worse-case performance (and thus making it O(nlog n)). It switch to heapsort when the depth level reaches 2*log2(total elements). The heapsort is a textbook implementation. Checked on x86_64-linux-gnu. --- stdlib/qsort.c | 87 ++++++++++++++++++++++++++++++++++++++++++++++---- 1 file changed, 80 insertions(+), 7 deletions(-) diff --git a/stdlib/qsort.c b/stdlib/qsort.c index 4082f5f9c1..e160932657 100644 --- a/stdlib/qsort.c +++ b/stdlib/qsort.c @@ -97,6 +97,7 @@ typedef struct { char *lo; char *hi; + size_t depth; } stack_node; /* The stack needs log (total_elements) entries (we could even subtract @@ -106,22 +107,83 @@ typedef struct enum { STACK_SIZE = CHAR_BIT * sizeof (size_t) }; static inline stack_node * -push (stack_node *top, char *lo, char *hi) +push (stack_node *top, char *lo, char *hi, size_t depth) { top->lo = lo; top->hi = hi; + top->depth = depth; return ++top; } static inline stack_node * -pop (stack_node *top, char **lo, char **hi) +pop (stack_node *top, char **lo, char **hi, size_t *depth) { --top; *lo = top->lo; *hi = top->hi; + *depth = top->depth; return top; } +/* A fast, small, non-recursive O(nlog n) heapsort, adapted from Linux + lib/sort.c. Used on introsort implementation as a fallback routine with + worst-case performance of O(nlog n) and worst-case space complexity of + O(1). */ + +static inline void +siftdown (void *base, size_t size, size_t k, size_t n, + enum swap_type_t swap_type, __compar_d_fn_t cmp, void *arg) +{ + while (k <= n / 2) + { + size_t j = 2 * k; + if (j < n && cmp (base + (j * size), base + ((j + 1) * size), arg) < 0) + j++; + + if (cmp (base + (k * size), base + (j * size), arg) >= 0) + break; + + do_swap (base + (size * j), base + (k * size), size, swap_type); + k = j; + } +} + +static inline void +heapify (void *base, size_t size, size_t n, enum swap_type_t swap_type, + __compar_d_fn_t cmp, void *arg) +{ + size_t k = n / 2; + while (1) + { + siftdown (base, size, k, n, swap_type, cmp, arg); + if (k-- == 0) + break; + } +} + +static void +heapsort_r (void *base, void *end, size_t size, enum swap_type_t swap_type, + __compar_d_fn_t cmp, void *arg) +{ + const size_t count = ((uintptr_t) end - (uintptr_t) base) / size; + + if (count < 2) + return; + + size_t n = count - 1; + + /* Build the binary heap, largest value at the base[0]. */ + heapify (base, size, n, swap_type, cmp, arg); + + /* On each iteration base[0:n] is the binary heap, while base[n:count] + is sorted. */ + while (n > 0) + { + do_swap (base, base + (n * size), size, swap_type); + n--; + siftdown (base, size, 0, n, swap_type, cmp, arg); + } +} static inline void insertion_sort_qsort_partitions (void *const pbase, size_t total_elems, @@ -207,7 +269,7 @@ _quicksort (void *const pbase, size_t total_elems, size_t size, const size_t max_thresh = MAX_THRESH * size; - if (total_elems == 0) + if (total_elems <= 1) /* Avoid lossage with unsigned arithmetic below. */ return; @@ -219,15 +281,26 @@ _quicksort (void *const pbase, size_t total_elems, size_t size, else swap_type = SWAP_BYTES; + /* Maximum depth before quicksort switches to heapsort. */ + size_t depth = 2 * (sizeof (size_t) * CHAR_BIT - 1 + - __builtin_clzl (total_elems)); + if (total_elems > MAX_THRESH) { char *lo = base_ptr; char *hi = &lo[size * (total_elems - 1)]; stack_node stack[STACK_SIZE]; - stack_node *top = stack + 1; + stack_node *top = push (stack, NULL, NULL, depth); while (stack < top) { + if (depth == 0) + { + heapsort_r (lo, hi, size, swap_type, cmp, arg); + top = pop (top, &lo, &hi, &depth); + continue; + } + char *left_ptr; char *right_ptr; @@ -291,7 +364,7 @@ _quicksort (void *const pbase, size_t total_elems, size_t size, { if ((size_t) (hi - left_ptr) <= max_thresh) /* Ignore both small partitions. */ - top = pop (top, &lo, &hi); + top = pop (top, &lo, &hi, &depth); else /* Ignore small left partition. */ lo = left_ptr; @@ -302,13 +375,13 @@ _quicksort (void *const pbase, size_t total_elems, size_t size, else if ((right_ptr - lo) > (hi - left_ptr)) { /* Push larger left partition indices. */ - top = push (top, lo, right_ptr); + top = push (top, lo, right_ptr, depth - 1); lo = left_ptr; } else { /* Push larger right partition indices. */ - top = push (top, left_ptr, hi); + top = push (top, left_ptr, hi, depth - 1); hi = right_ptr; } }