From patchwork Fri Sep 2 20:39:24 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella Netto X-Patchwork-Id: 602181 Delivered-To: patch@linaro.org Received: by 2002:a05:7000:4388:0:0:0:0 with SMTP id w8csp1789294mae; Fri, 2 Sep 2022 13:40:02 -0700 (PDT) X-Google-Smtp-Source: AA6agR6eAFCYQTesgRQmBJnOqkkZDtBQUb7dgzrvzGNYTVxz94rGJ8hJig+FH1PIRg+n4PYcmwZe X-Received: by 2002:a17:906:c150:b0:751:2181:87a6 with SMTP id dp16-20020a170906c15000b00751218187a6mr3097373ejc.692.1662151201989; Fri, 02 Sep 2022 13:40:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1662151201; cv=none; d=google.com; s=arc-20160816; b=njRTtHPlY5BX+RH+/tLCx64fLoTbbEoFyfpLY8cIpE78xyU6XnmJ9Qry2p5Hv6y6ji l+h4ZVkMc3s4d3i8AILpuNVqTM5uGRNK23R3Eghx68OJg3ijh9T/p8Y3cBTF/lHUX694 R2/FoZOBC2v8ZI+NJUIxFknGn45HRoyaNJMg2ZoSpHjy4Hq4gIXxfyebgdqchReaKCqN JMKwhnWxOJFNSaSCT+Ph9vYcqoE/sWwKWX2nxW2lrYYfsfh3w5XSNIyf1sewmrhfsldj NTmDpIM7wgnoU3dFGswzQwWBpSnusKrmVhztRfPqcAfop+aZdWOHoj0WUAhrKF/kTILC +z5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:reply-to:from:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:dmarc-filter:delivered-to:dkim-signature :dkim-filter; bh=uyhyLz38LFlPYNj6QCjH8NWe1tXKsAkhUH/RV/4H9fs=; b=erTQ5PnGguYB793DNmZdn97x1tyInLd1f4EVaLlm57PTwkDlIvWqVkjqa6cOFbJMiP 5WUq05bwUVjwvyvmnpHC+z+fXbaab19Yf8cp+8WEVfj6Gcwaw9eRTZjwtBgWyLuzglmS n+apz39hhapvyUghCaZJDf96XPWqo7ca0JOrq4++e1NAOQC1afqmopP4lVjLTxNSi6yx FTiwj5CK2w3QEMRf5JGcG/hvPrHkqG9xMdyXs19UtRhaodjYhKKyIjKOrO4te1/hx5g1 8ErKbaq17W84bGhd2dxwEJGdGoSqhCHHjyfZhis2OmtqAteZgv17lkg3eXsvROkoYCQe TeDQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=OvbbsAFj; spf=pass (google.com: domain of libc-alpha-bounces+patch=linaro.org@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="libc-alpha-bounces+patch=linaro.org@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Return-Path: Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id hg7-20020a1709072cc700b007307bde1f23si2323276ejc.716.2022.09.02.13.40.01 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Sep 2022 13:40:01 -0700 (PDT) Received-SPF: pass (google.com: domain of libc-alpha-bounces+patch=linaro.org@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=OvbbsAFj; spf=pass (google.com: domain of libc-alpha-bounces+patch=linaro.org@sourceware.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="libc-alpha-bounces+patch=linaro.org@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AEC1C3857C5B for ; Fri, 2 Sep 2022 20:40:00 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AEC1C3857C5B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1662151200; bh=uyhyLz38LFlPYNj6QCjH8NWe1tXKsAkhUH/RV/4H9fs=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=OvbbsAFjc4z7i67XD8xkK7tf8PESyo6BBRQQrno335uzmSM88q9r5JcDGT2arwWb1 CHMVuQcnAFOn1k5Vv6Rvr1oBX/GC+2HxsRIEUFJ1jZC+Y1UJjzvuELcfbeZy3MDN0W AfsvKlr9RE+RnC3TbjGDxfhRAkPflNoJH/zFxijo= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-oa1-x2b.google.com (mail-oa1-x2b.google.com [IPv6:2001:4860:4864:20::2b]) by sourceware.org (Postfix) with ESMTPS id 18B263858D39 for ; Fri, 2 Sep 2022 20:39:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 18B263858D39 Received: by mail-oa1-x2b.google.com with SMTP id 586e51a60fabf-11f11d932a8so7639244fac.3 for ; Fri, 02 Sep 2022 13:39:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=uyhyLz38LFlPYNj6QCjH8NWe1tXKsAkhUH/RV/4H9fs=; b=flgViO2sRMaVroWWObXpqUatP7tPmRkHj8oGWD3gPnfJK5+eOIY3DxM3acyhohf3t+ UjGULE5WYVTTbVck/TEmk1z6tBz3SKrjA/EktCkGjErVk0SvMcGY0gp6NlHpRYWRV9i4 VsnkASfz29JrBeWhoojldZ33my+DXmSrcyKEJnakaXT4xTnSmbF4RB98VHqUJW5+jydO pYtghzdgoMGrQHw2pkOxezBXcVPFC75zl+eoc7CsFeTHNGZ9ZjsrY1tqH1RtI6NXcZtI kRxIRZGg5kdnDBw97KVrNyFIV7jBHOLgOBY/TF4D4994PdU96SvMKadDJp5/n8TUPO1N VUVg== X-Gm-Message-State: ACgBeo08JR7pnPk1SljC0mQMb1+RB/Y11TjPd7xdmLqT/9IuHXyl6uPs 3YLpW/lTw9tyaF/ZuHW9PbNspsf39W5gJw== X-Received: by 2002:a05:6870:f5a9:b0:11d:cbad:301d with SMTP id eh41-20020a056870f5a900b0011dcbad301dmr3016421oab.202.1662151188302; Fri, 02 Sep 2022 13:39:48 -0700 (PDT) Received: from mandiga.. ([2804:1b3:a7c0:dfed:72d1:946c:4eb1:ce5f]) by smtp.gmail.com with ESMTPSA id i27-20020a4a6f5b000000b00425678b9c4bsm1107902oof.0.2022.09.02.13.39.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Sep 2022 13:39:48 -0700 (PDT) To: libc-alpha@sourceware.org Subject: [PATCH 01/17] Parameterize op_t from memcopy.h Date: Fri, 2 Sep 2022 17:39:24 -0300 Message-Id: <20220902203940.2385967-2-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220902203940.2385967-1-adhemerval.zanella@linaro.org> References: <20220902203940.2385967-1-adhemerval.zanella@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Adhemerval Zanella via Libc-alpha From: Adhemerval Zanella Netto Reply-To: Adhemerval Zanella Cc: Richard Henderson , Joseph Myers , caiyinyu Errors-To: libc-alpha-bounces+patch=linaro.org@sourceware.org Sender: "Libc-alpha" From: Richard Henderson It moves the op_t definition out to an specific header, adds the attribute 'may-alias', and cleanup its duplicated definitions. Checked with a build and check with run-built-tests=no for all major Linux ABIs. Co-authored-by: Adhemerval Zanella --- string/memcmp.c | 1 - sysdeps/generic/memcopy.h | 6 ++---- sysdeps/generic/string-optype.h | 31 +++++++++++++++++++++++++++++++ 3 files changed, 33 insertions(+), 5 deletions(-) create mode 100644 sysdeps/generic/string-optype.h diff --git a/string/memcmp.c b/string/memcmp.c index 40029474e6..6a9ceb8ac3 100644 --- a/string/memcmp.c +++ b/string/memcmp.c @@ -46,7 +46,6 @@ /* Type to use for aligned memory operations. This should normally be the biggest type supported by a single load and store. Must be an unsigned type. */ -# define op_t unsigned long int # define OPSIZ (sizeof (op_t)) /* Threshold value for when to enter the unrolled loops. */ diff --git a/sysdeps/generic/memcopy.h b/sysdeps/generic/memcopy.h index 251632e8ae..efe5f2475d 100644 --- a/sysdeps/generic/memcopy.h +++ b/sysdeps/generic/memcopy.h @@ -55,10 +55,8 @@ [I fail to understand. I feel stupid. --roland] */ -/* Type to use for aligned memory operations. - This should normally be the biggest type supported by a single load - and store. */ -#define op_t unsigned long int +/* Type to use for aligned memory operations. */ +#include #define OPSIZ (sizeof (op_t)) /* Type to use for unaligned operations. */ diff --git a/sysdeps/generic/string-optype.h b/sysdeps/generic/string-optype.h new file mode 100644 index 0000000000..fb6d67a19e --- /dev/null +++ b/sysdeps/generic/string-optype.h @@ -0,0 +1,31 @@ +/* Define a type to use for word access. Generic version. + Copyright (C) 2022 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +#ifndef _STRING_OPTYPE_H +#define _STRING_OPTYPE_H 1 + +/* Use the existing parameterization from gmp as a default. */ +#include + +#ifdef _LONG_LONG_LIMB +typedef unsigned long long int __attribute__ ((__may_alias__)) op_t; +#else +typedef unsigned long int __attribute__ ((__may_alias__)) op_t; +#endif + +#endif /* string-optype.h */