From patchwork Tue Dec 17 21:47:15 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella X-Patchwork-Id: 181914 Delivered-To: patch@linaro.org Received: by 2002:a92:3001:0:0:0:0:0 with SMTP id x1csp6349625ile; Tue, 17 Dec 2019 13:48:10 -0800 (PST) X-Google-Smtp-Source: APXvYqwuxRhnvVHh4TaUCBT3CH/SFhALAhK8e2bcQZqQq5Yc4K51+BZdQWTECboTnLinej5EXeA5 X-Received: by 2002:aca:1103:: with SMTP id 3mr2904839oir.171.1576619289969; Tue, 17 Dec 2019 13:48:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576619289; cv=none; d=google.com; s=arc-20160816; b=bu1xWW2VVbYP6hLwUnvQadk/ODpL5KDqVy2OfLPlvBU6M2l/RiLvDKjaIpxfvLHnWz 1CGLD7RyJafWDwJKRoqQoeGYqX1RMnOt6yTdUE873VgtVHHmCjqkFljvd7bTUyQtoFl8 ec5AvZl84J3VMyHMLkdKIxx0/AadHrfylhyFjuscJWry4qJhPTIiBqc9uL9z82LSJvj6 wo701pVNFF+w45nTzfIN5iswhKE4AdHymPJYQXoyYbjAQC2M31uPBYyBatJZ4H8Kv9E/ beHHsV1Imvtvo8G1fslm/iNMC7RFOA5XjIadwoWwMAvd3iuES0jSjuEOngHbB+JX1meT kUXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:to:from :dkim-signature:delivered-to:sender:list-help:list-post:list-archive :list-subscribe:list-unsubscribe:list-id:precedence:mailing-list :dkim-signature:domainkey-signature; bh=jhofP24iy+EIsWqORv9KnFvA524I9prsM9/VYL+ZFL0=; b=z6UxrbkFxfLhX6sDgqA8RxxXnPN6WjLBDylnt5KKO9S2Vd4/V71FI2ozIwHWaUB6cq OZFOVsYDEcVQVsOQ2l7QsoLsEQf2A0gqStMGUoKOErjzwdZYstq7r3t+ybnRaYJ9p6wV tQHXU4jetuUkRkP4z3tNFL0b98jFfMlGfYoWAgXzK/hS2fnGPRahBWgSv3GFOCIgY5BS 2D2iRoD4rS4aHGyaTcgcjBwPqBz2PwBJ6i1O/ml/tQSNWFMvoqKNw9G0hqy5NF0JYyH3 FLgo3i0twechLuAxL7/dg0O5ncdmRGdGkmS2LWgVgIe4AhPrn4DP7ymOAmhcysLt+Xi/ 80XQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=pqJnzbBi; dkim=pass header.i=@linaro.org header.s=google header.b=Z+wLbZJJ; spf=pass (google.com: domain of libc-alpha-return-108165-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) smtp.mailfrom="libc-alpha-return-108165-patch=linaro.org@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id 194si2118053oii.2.2019.12.17.13.48.09 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Dec 2019 13:48:09 -0800 (PST) Received-SPF: pass (google.com: domain of libc-alpha-return-108165-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=pqJnzbBi; dkim=pass header.i=@linaro.org header.s=google header.b=Z+wLbZJJ; spf=pass (google.com: domain of libc-alpha-return-108165-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) smtp.mailfrom="libc-alpha-return-108165-patch=linaro.org@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:in-reply-to :references; q=dns; s=default; b=lTc3uzRc+5ziFNdlJDFNmyCOPSqveC2 WKClsfopmNUmRTGZMrbspEL1YmJMzsiiL7pixpACh+bGB9zhtMLtc9+RbYbBJyZK CzBBFSfrz4cNDepdJWvQEIQ0DAxskQZaTBatT3cj1KfyEbb5H72oWVA8bbYuSMWK /oyknZxftUVs= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:in-reply-to :references; s=default; bh=TTozQ/otqIR+N9gLRGWzZEx6gxc=; b=pqJnz bBi0cYVgxLCzOMwbMSVxGh5fZZBplM1rpZrxYtK6VK45o2pAvYEKMENq0cY7Terw CeTp/zPh8Ixq5cms4qB8wNP8aIiPylmtUuOq+vuZA69urPOkJBN08Urg79kaAdFu O1Ar3b77Kg6yze77eHCMZS9jfv03TYycjtd2Ok= Received: (qmail 109673 invoked by alias); 17 Dec 2019 21:47:41 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 109625 invoked by uid 89); 17 Dec 2019 21:47:40 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-21.8 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.1 spammy=HX-HELO:sk:mail-pj X-HELO: mail-pj1-f65.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references; bh=jhofP24iy+EIsWqORv9KnFvA524I9prsM9/VYL+ZFL0=; b=Z+wLbZJJC322wqgvd5kzOPKu3051tcBRDYJR5A/+MoqpbbdvciRNrY1h7i7TksLvHc x1mOP/xASX7PNiE35aeb9zQLe22EmGgNiLdyjsesB8A2wBdBCIWfOJweOqDHyJYlsHeY BnduzXMQd3BLzT6I+lifsVDD2ypxP+so1q8esKgUeKFf/PdQUKRbP5qkIt2s0TFoyYFO SQlqthfqZfNxqbDEeguwWv/YFpvijBZ+o1y4+JNj5tC8EdXzcRH6N5cWfwAILw5mcKfQ /GQbVK9+cM2WDitF7hVUhiIozZA74MA3i9wKEfAfZ2jx+CYq5EhbhPXbmNxsH1JDd5p3 AH7g== Return-Path: From: Adhemerval Zanella To: libc-alpha@sourceware.org Subject: [PATCH 03/16] Remove vDSO support from make-syscall.sh Date: Tue, 17 Dec 2019 18:47:15 -0300 Message-Id: <20191217214728.2886-3-adhemerval.zanella@linaro.org> In-Reply-To: <20191217214728.2886-1-adhemerval.zanella@linaro.org> References: <20191217214728.2886-1-adhemerval.zanella@linaro.org> The auto-generated vDSO call shows some issues: - It requires sync the auto-generated C file with current glibc implementation; - It still uses symbol redirections hacks where libc-symbols.h provide macros that uses compiler builtins (libc_ifunc_redirected for instance); - It does not handle all required compiler handling (inhibit_stack_protector on iFUNC resolver). - No architecure uses it. Checked with a build against all major ABIs. --- sysdeps/unix/make-syscalls.sh | 45 +---------------------------------- 1 file changed, 1 insertion(+), 44 deletions(-) -- 2.17.1 diff --git a/sysdeps/unix/make-syscalls.sh b/sysdeps/unix/make-syscalls.sh index fe24bbc78f..c07626677f 100644 --- a/sysdeps/unix/make-syscalls.sh +++ b/sysdeps/unix/make-syscalls.sh @@ -149,14 +149,6 @@ emit_weak_aliases() echo "$calls" | while read file srcfile caller syscall args strong weak; do - vdso_syscall= - case x"$syscall" in - *:*@*) - vdso_syscall="${syscall#*:}" - syscall="${syscall%:*}" - ;; - esac - case x"$syscall" in x-) callnum=_ ;; *) @@ -233,10 +225,9 @@ while read file srcfile caller syscall args strong weak; do if test $shared_only = t; then # The versioned symbols are only in the shared library. echo "shared-only-routines += $file" - test -n "$vdso_syscall" || echo "\$(objpfx)${file}.os: \\" + echo "\$(objpfx)${file}.os: \\" else object_suffixes='$(object-suffixes)' - test -z "$vdso_syscall" || object_suffixes='$(object-suffixes-noshared)' echo "\ \$(foreach p,\$(sysd-rules-targets),\ \$(foreach o,${object_suffixes},\$(objpfx)\$(patsubst %,\$p,$file)\$o)): \\" @@ -268,40 +259,6 @@ while read file srcfile caller syscall args strong weak; do echo ' ) | $(compile-syscall) '"\ \$(foreach p,\$(patsubst %$file,%,\$(basename \$(@F))),\$(\$(p)CPPFLAGS))" - if test -n "$vdso_syscall"; then - # In the shared library, we're going to emit an IFUNC using a vDSO function. - # $vdso_syscall looks like "name@KERNEL_X.Y" where "name" is the symbol - # name in the vDSO and KERNEL_X.Y is its symbol version. - vdso_symbol="${vdso_syscall%@*}" - vdso_symver="${vdso_syscall#*@}" - vdso_symver=`echo "$vdso_symver" | sed 's/\./_/g'` - cat <'; \\ - echo '#undef ${strong}'; \\ - echo '#define vdso_ifunc_init()'; \\ - echo '__ifunc (__redirect_${strong}, ${strong},'; \\ - echo ' get_vdso_symbol ("${vdso_symbol}"), void,'; \\ - echo ' vdso_ifunc_init)'; \\ -EOF - # This is doing "hidden_def (${strong})", but the compiler - # doesn't know that we've defined ${strong} in the same file, so - # we can't do it the normal way. - cat <