From patchwork Fri Nov 29 21:03:23 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella Netto X-Patchwork-Id: 180500 Delivered-To: patch@linaro.org Received: by 2002:a92:3001:0:0:0:0:0 with SMTP id x1csp2089695ile; Fri, 29 Nov 2019 13:04:07 -0800 (PST) X-Google-Smtp-Source: APXvYqxE0B3qouwrO/5vZjt0pXFp15FwtedaefU/MvZf6NiXAfo/ZlGHQNMlrmBjn2oAERESqhJE X-Received: by 2002:aa7:d842:: with SMTP id f2mr47422214eds.262.1575061447447; Fri, 29 Nov 2019 13:04:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1575061447; cv=none; d=google.com; s=arc-20160816; b=YtJD7Y71qyRJzXPCzkX8af+2khjy2DHsXwTfCT2MS5WX9YkrwYw0T6chBGcOcVGCuB ujY3fcTxnxpcVdtX5qKSEqSKE4QIG7kqIT/phPfnRn0Mv9JxkX9KDL473u0pcsGZNZQ/ 1TqcL80BaIKEaoV8S/CEEzJ0bsCVLRHoAFNQrdNqN8U+W28A4bQJp8vUSfFTZRq3j+XO DHgjTxcIn2CG2pZlmohEI3YD9z4QM6e0VvU5ApOD+I3f1K/3HhW4uABxJm8F2WskoPAA UgXths8oyuGrWdv2g6UeXWzxi9UgwE/7tt7FsKsbnE5Qb7ZbY6rDetGmgqFSt50sEdVh ToFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:to:from :dkim-signature:delivered-to:sender:list-help:list-post:list-archive :list-subscribe:list-unsubscribe:list-id:precedence:mailing-list :dkim-signature:domainkey-signature; bh=/PPOy1QeIiEGrmkgdyk5lGihZwQHH2uEiyFV+yKC27I=; b=LoXQGXUkn4W/GNtwxDQ5eOlFFlUPhUMaCRw5ZHA/42rI95sRt38LKW4Ow20PR0sx+t rCl0vWhdLSAn0qi5pxn2hFYHfpSsvwY2u2yQOKWJW159xWDv8Zxz0rsA2mghnHOWmK7f 94qMYbAzRphzUxJdlJhfPcyogVjOpL7NxNDzBgikxNcOgXzjm/qJUQGpwhvH4OVJYUcE VgfcO8ZINjnJAD60M3lnh193dU6HxeTVWRwavVwAnJacRBoKA1jZ1J0GkYG9FGsD9+XJ loSm0LG6h8kvPAn9WGM70Io4S6CPDX/dpYSMGHklVoMsjUoudFQMU2HUpWw3VbSX4Mh9 5N5w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=mffRfENG; dkim=pass header.i=@linaro.org header.s=google header.b=ncborhC5; spf=pass (google.com: domain of libc-alpha-return-107560-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) smtp.mailfrom="libc-alpha-return-107560-patch=linaro.org@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id pg2si15077965ejb.216.2019.11.29.13.04.06 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 29 Nov 2019 13:04:07 -0800 (PST) Received-SPF: pass (google.com: domain of libc-alpha-return-107560-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=mffRfENG; dkim=pass header.i=@linaro.org header.s=google header.b=ncborhC5; spf=pass (google.com: domain of libc-alpha-return-107560-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) smtp.mailfrom="libc-alpha-return-107560-patch=linaro.org@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:in-reply-to :references; q=dns; s=default; b=pAdWuPcZRGRUU6GC9SuB3QLljclsOvb I+NLEnFgtkPsCvq3c3K/HGetS3eYgY/5i1rH5mFFGNMTxuC6EvpICTu3YL2mL/6x F+GqE+vtWj4jyAwp5vsCbVJRfeuqaoWf/t4LlQ6j3WN7Ayy4zCInP/N4VFT/DUpI ZQw3QXciAWU0= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:in-reply-to :references; s=default; bh=b8xzT2il0Vuz9LoW9kT/+FRr8o0=; b=mffRf ENGIVIWQXBGo3/vACg3Q0AqGWVgD+A+8JpANIIcr2/s0gQfDsRuM48qR1KDVZc81 8ZI4uvavHTVvQrxT5MjGqCEHWgwTRmpwa98wkQGn2OFaryiLLiK63di60gSoyAM5 u2V4tLRDwnvzeExgulK0esTUaYgHFJ6rmRIBl0= Received: (qmail 72005 invoked by alias); 29 Nov 2019 21:03:41 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 71957 invoked by uid 89); 29 Nov 2019 21:03:41 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-21.6 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.1 spammy=eof, HX-Spam-Relays-External:209.85.222.194, H*RU:209.85.222.194, o X-HELO: mail-qk1-f194.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references; bh=/PPOy1QeIiEGrmkgdyk5lGihZwQHH2uEiyFV+yKC27I=; b=ncborhC5LzBHo82lah5hwlTH+ggf78TGRbu3CHDneDynhdO0QFW5qzmDhFNR6Cu702 2tTGYKBeyC1KRgjF6HgXA76b688x4Eoo3c/pin1eTtQL+XZqLIR+Lu7v4wEvAm4USAM8 rVUJwCkOiBOSo7a/6jGRZBNZMTdw+kPsjHi7NzL8ewF5/X6bv2dbrbp2fVRXtaFQnoba 2zUmGGdvHoEerLTgDWZvZ1vZxPUX01o2EBu3nkUhc3yhxMcl3ti8wUNmZ/6O5+ADBw19 Jbs7+ByJ3w0Uf8eGLVLWWYU72+CdOl16w8ItGbJYBhMc48B6AdPLpZ/STijT7CoYNhUk P4Aw== Return-Path: From: Adhemerval Zanella To: libc-alpha@sourceware.org Subject: [PATCH 3/7] Remove vDSO support from make-syscall.sh Date: Fri, 29 Nov 2019 18:03:23 -0300 Message-Id: <20191129210327.26434-3-adhemerval.zanella@linaro.org> In-Reply-To: <20191129210327.26434-1-adhemerval.zanella@linaro.org> References: <20191129210327.26434-1-adhemerval.zanella@linaro.org> Currenty there is no usage of the vDSO, itt requires sync the auto-generated C file with current glibc implementation, it still uses still uses symbol redirections hacks where libc-symbols.h provide macros (for instance libc_ifunc_redirected), and it does not handle all required compiler handling (inhibit_stack_protector on resolver for instance). Checked with a build against all major ABIs. --- sysdeps/unix/make-syscalls.sh | 45 +---------------------------------- 1 file changed, 1 insertion(+), 44 deletions(-) -- 2.17.1 diff --git a/sysdeps/unix/make-syscalls.sh b/sysdeps/unix/make-syscalls.sh index fe24bbc78f..c07626677f 100644 --- a/sysdeps/unix/make-syscalls.sh +++ b/sysdeps/unix/make-syscalls.sh @@ -149,14 +149,6 @@ emit_weak_aliases() echo "$calls" | while read file srcfile caller syscall args strong weak; do - vdso_syscall= - case x"$syscall" in - *:*@*) - vdso_syscall="${syscall#*:}" - syscall="${syscall%:*}" - ;; - esac - case x"$syscall" in x-) callnum=_ ;; *) @@ -233,10 +225,9 @@ while read file srcfile caller syscall args strong weak; do if test $shared_only = t; then # The versioned symbols are only in the shared library. echo "shared-only-routines += $file" - test -n "$vdso_syscall" || echo "\$(objpfx)${file}.os: \\" + echo "\$(objpfx)${file}.os: \\" else object_suffixes='$(object-suffixes)' - test -z "$vdso_syscall" || object_suffixes='$(object-suffixes-noshared)' echo "\ \$(foreach p,\$(sysd-rules-targets),\ \$(foreach o,${object_suffixes},\$(objpfx)\$(patsubst %,\$p,$file)\$o)): \\" @@ -268,40 +259,6 @@ while read file srcfile caller syscall args strong weak; do echo ' ) | $(compile-syscall) '"\ \$(foreach p,\$(patsubst %$file,%,\$(basename \$(@F))),\$(\$(p)CPPFLAGS))" - if test -n "$vdso_syscall"; then - # In the shared library, we're going to emit an IFUNC using a vDSO function. - # $vdso_syscall looks like "name@KERNEL_X.Y" where "name" is the symbol - # name in the vDSO and KERNEL_X.Y is its symbol version. - vdso_symbol="${vdso_syscall%@*}" - vdso_symver="${vdso_syscall#*@}" - vdso_symver=`echo "$vdso_symver" | sed 's/\./_/g'` - cat <'; \\ - echo '#undef ${strong}'; \\ - echo '#define vdso_ifunc_init()'; \\ - echo '__ifunc (__redirect_${strong}, ${strong},'; \\ - echo ' get_vdso_symbol ("${vdso_symbol}"), void,'; \\ - echo ' vdso_ifunc_init)'; \\ -EOF - # This is doing "hidden_def (${strong})", but the compiler - # doesn't know that we've defined ${strong} in the same file, so - # we can't do it the normal way. - cat <