From patchwork Wed Oct 30 20:00:51 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella Netto X-Patchwork-Id: 178126 Delivered-To: patch@linaro.org Received: by 2002:a92:409a:0:0:0:0:0 with SMTP id d26csp1754649ill; Wed, 30 Oct 2019 13:01:53 -0700 (PDT) X-Google-Smtp-Source: APXvYqy0ydOBOZ9fXWD7t7eL6NkfCHbaf7B3V6yJM8NJHfRV+1lBLxK+XPr50Mvu4yK0R3tJpzRd X-Received: by 2002:a50:b634:: with SMTP id b49mr1691651ede.77.1572465713643; Wed, 30 Oct 2019 13:01:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1572465713; cv=none; d=google.com; s=arc-20160816; b=XIrr6mzvFh3iXwJFSq95zNk95M/RHWqmiMV1uNPnTpI3AA5cn9zMquBw9buOLjaK/2 bsbfWO8jYGx2Hi9x/j6Dmnys+fkScbe/M/fQZw+syu+jB4Wm6yMvFMm7PM2MXcRQ+J+l 3OVm9HKKLkMCvoKmgpBejINcfktXIxmZt9dHgfNfSFp2FPCW+NxP2VJfRwB6f58MggyH 8lQk6+BmWgAvLVYbx6LHRGomZUKmOV39urulKW3KdS9l+S3hguyOE8BhW9dz5IX85rTo f71ey/n4EUQ6wf/DY5kTRt2amdjotr56IFglO5G0iTuLY4sDg1SpVoUyAlra2QlTohKE HG5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:delivered-to:sender:list-help:list-post:list-archive :list-subscribe:list-unsubscribe:list-id:precedence:mailing-list :dkim-signature:domainkey-signature; bh=HMORJRzuUp22hpsBb0hH5UhVOgJg45YFpuVBvMQwtus=; b=zwCW77gs+3sJCRhftyU49JGOYvUioWEved0FVBfe7tCDkqH5rtStiiCN1NKub+ZJmQ sQCeKx5Ipbp/y8HYUEEcRPAEFf7oFPNsmmbVuxK5oBjgg4y1aFCwVywz/sAP4nFovCIZ oXLwDDb2oVPtbxPo7FGQr6kYrys9+Sclwdeduiyq2OIOX5TlzBLtNS0rf51ijbyZToOl lMehYZbQWTM8ZoIrIy91QRyWKk0auiKFIld7HHMhNO0gJu++2Ad4NrTUgK/h5feeAuAl 5mDYVjg049lOy0xZNITdQNjmpJ7tvV2utwd5hBJ4AEpGfzt9UG9qemyX8C1iIJILWi7M D0Dw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=WnRez6xZ; dkim=pass header.i=@linaro.org header.s=google header.b=AxnukSJ3; spf=pass (google.com: domain of libc-alpha-return-106478-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) smtp.mailfrom="libc-alpha-return-106478-patch=linaro.org@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id n19si1840779ejk.264.2019.10.30.13.01.52 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 Oct 2019 13:01:53 -0700 (PDT) Received-SPF: pass (google.com: domain of libc-alpha-return-106478-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=WnRez6xZ; dkim=pass header.i=@linaro.org header.s=google header.b=AxnukSJ3; spf=pass (google.com: domain of libc-alpha-return-106478-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) smtp.mailfrom="libc-alpha-return-106478-patch=linaro.org@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:date:message-id:in-reply-to :references; q=dns; s=default; b=lTeW32f6h5/DfgtOb3ArqwPl0wDJNzF yEnICJ+bIhzOsQXyvT8n4WerbUqOl2upYUCGWygEdsBL6TehMUEBo4xzP/tTe/JT HMsG078eolUHREoyEjoPQlUcyjXKXmL/2G4Hn3Spx332YtLvzKn58Hzd1ZsbRWub 1r9YzDvm9O7M= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:date:message-id:in-reply-to :references; s=default; bh=2yrUQWudG1ZinOAS2XtcCo39LgI=; b=WnRez 6xZj0OEpQR2Vl5goOqyI/liLjvj3gPLxfdX5o7+ighUehdjhEggGf8zDrFF5d2ss O05RmtEslDZejRv5xMeg36vJdv73MxM1poIiq4EuBExw4BE92aIX2yynqDKgXDg1 u6shJqil1mV4yr+/ZehAdHlxFpfb750G78MEjk= Received: (qmail 81883 invoked by alias); 30 Oct 2019 20:01:31 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 77050 invoked by uid 89); 30 Oct 2019 20:01:10 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-21.6 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mail-qk1-f195.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=HMORJRzuUp22hpsBb0hH5UhVOgJg45YFpuVBvMQwtus=; b=AxnukSJ3PAlycEhk6Jv+RbGMlL9NJdpYCo/udifCdsZ5MAnrV7e2PBX73GrchlnJyb bD3QEIyP+lB5T7FaIDdfAaoo5+5aqVTCrQjh9yxFr+w+rZzvt2Akg5MN81oyYUn+Q2Ae jd7WS110pgmWbn5CE/qfyONH6P6qVY2xI1ooTJsT/LL3PdjID9a0E+vLNtwlg6Hmq1fq RP5eQXRaXQwuB2z7gmV0u0srSQE+8qz8Q9lIaQzYYWapvOjCnpPM48/XNyEXiqWpYS2t MoN3egYUImu2hAtgyXAkPnDsxJPeQqGAxQM4pW323Oky0SrpERtwmExTBYQJjajSComz ds3Q== Return-Path: From: Adhemerval Zanella To: libc-alpha@sourceware.org Cc: Alistair Francis Subject: [PATCH 4/5] Remove pause and nanosleep not cancel wrappers Date: Wed, 30 Oct 2019 17:00:51 -0300 Message-Id: <20191030200052.497-4-adhemerval.zanella@linaro.org> In-Reply-To: <20191030200052.497-1-adhemerval.zanella@linaro.org> References: <20191030200052.497-1-adhemerval.zanella@linaro.org> Since they are not used any longer. --- sysdeps/generic/not-cancel.h | 4 --- sysdeps/unix/sysv/linux/Makefile | 4 +-- sysdeps/unix/sysv/linux/nanosleep_nocancel.c | 29 ----------------- sysdeps/unix/sysv/linux/not-cancel.h | 8 ----- sysdeps/unix/sysv/linux/pause_nocancel.c | 33 -------------------- 5 files changed, 2 insertions(+), 76 deletions(-) delete mode 100644 sysdeps/unix/sysv/linux/nanosleep_nocancel.c delete mode 100644 sysdeps/unix/sysv/linux/pause_nocancel.c -- 2.17.1 Reviewed-by: Carlos O'Donell diff --git a/sysdeps/generic/not-cancel.h b/sysdeps/generic/not-cancel.h index 5df48f3da7..d3b53e48cf 100644 --- a/sysdeps/generic/not-cancel.h +++ b/sysdeps/generic/not-cancel.h @@ -49,10 +49,6 @@ (void) __writev (fd, iov, n) # define __waitpid_nocancel(pid, stat_loc, options) \ __waitpid (pid, stat_loc, options) -#define __pause_nocancel() \ - __pause () -#define __nanosleep_nocancel(requested_time, remaining) \ - __nanosleep (requested_time, remaining) #define __fcntl64_nocancel(fd, cmd, ...) \ __fcntl64 (fd, cmd, __VA_ARGS__) diff --git a/sysdeps/unix/sysv/linux/Makefile b/sysdeps/unix/sysv/linux/Makefile index bbab8f8cc3..ad6821ecf6 100644 --- a/sysdeps/unix/sysv/linux/Makefile +++ b/sysdeps/unix/sysv/linux/Makefile @@ -212,10 +212,10 @@ endif ifeq ($(subdir),io) sysdep_routines += xstatconv internal_statvfs internal_statvfs64 \ sync_file_range fallocate fallocate64 \ - close_nocancel fcntl_nocancel nanosleep_nocancel \ + close_nocancel fcntl_nocancel \ open_nocancel open64_nocancel \ openat_nocancel openat64_nocancel \ - pause_nocancel read_nocancel pread64_nocancel \ + read_nocancel pread64_nocancel \ waitpid_nocancel write_nocancel statx_cp sysdep_headers += bits/fcntl-linux.h diff --git a/sysdeps/unix/sysv/linux/nanosleep_nocancel.c b/sysdeps/unix/sysv/linux/nanosleep_nocancel.c deleted file mode 100644 index d6442bf4f7..0000000000 --- a/sysdeps/unix/sysv/linux/nanosleep_nocancel.c +++ /dev/null @@ -1,29 +0,0 @@ -/* Linux nanosleep syscall implementation -- non-cancellable. - Copyright (C) 2018-2019 Free Software Foundation, Inc. - This file is part of the GNU C Library. - - The GNU C Library is free software; you can redistribute it and/or - modify it under the terms of the GNU Lesser General Public - License as published by the Free Software Foundation; either - version 2.1 of the License, or (at your option) any later version. - - The GNU C Library is distributed in the hope that it will be useful, - but WITHOUT ANY WARRANTY; without even the implied warranty of - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - Lesser General Public License for more details. - - You should have received a copy of the GNU Lesser General Public - License along with the GNU C Library; if not, see - . */ - -#include -#include -#include - -int -__nanosleep_nocancel (const struct timespec *requested_time, - struct timespec *remaining) -{ - return INLINE_SYSCALL_CALL (nanosleep, requested_time, remaining); -} -hidden_def (__nanosleep_nocancel) diff --git a/sysdeps/unix/sysv/linux/not-cancel.h b/sysdeps/unix/sysv/linux/not-cancel.h index 041fd00111..192a0a5195 100644 --- a/sysdeps/unix/sysv/linux/not-cancel.h +++ b/sysdeps/unix/sysv/linux/not-cancel.h @@ -72,12 +72,6 @@ __writev_nocancel_nostatus (int fd, const struct iovec *iov, int iovcnt) /* Uncancelable waitpid. */ __typeof (waitpid) __waitpid_nocancel; -/* Uncancelable pause. */ -__typeof (pause) __pause_nocancel; - -/* Uncancelable nanosleep. */ -__typeof (__nanosleep) __nanosleep_nocancel; - /* Uncancelable fcntl. */ __typeof (__fcntl) __fcntl64_nocancel; @@ -91,8 +85,6 @@ hidden_proto (__pread64_nocancel) hidden_proto (__write_nocancel) hidden_proto (__close_nocancel) hidden_proto (__waitpid_nocancel) -hidden_proto (__pause_nocancel) -hidden_proto (__nanosleep_nocancel) hidden_proto (__fcntl64_nocancel) #endif diff --git a/sysdeps/unix/sysv/linux/pause_nocancel.c b/sysdeps/unix/sysv/linux/pause_nocancel.c deleted file mode 100644 index 04f6fcf5e3..0000000000 --- a/sysdeps/unix/sysv/linux/pause_nocancel.c +++ /dev/null @@ -1,33 +0,0 @@ -/* Linux pause syscall implementation -- non-cancellable. - Copyright (C) 2018-2019 Free Software Foundation, Inc. - This file is part of the GNU C Library. - - The GNU C Library is free software; you can redistribute it and/or - modify it under the terms of the GNU Lesser General Public - License as published by the Free Software Foundation; either - version 2.1 of the License, or (at your option) any later version. - - The GNU C Library is distributed in the hope that it will be useful, - but WITHOUT ANY WARRANTY; without even the implied warranty of - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - Lesser General Public License for more details. - - You should have received a copy of the GNU Lesser General Public - License along with the GNU C Library. If not, see - . */ - -#include -#include -#include -#include - -int -__pause_nocancel (void) -{ -#ifdef __NR_pause - return INLINE_SYSCALL_CALL (pause); -#else - return INLINE_SYSCALL_CALL (ppoll, NULL, 0, NULL, NULL); -#endif -} -hidden_def (__pause_nocancel)