From patchwork Tue Nov 8 20:30:07 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella Netto X-Patchwork-Id: 81411 Delivered-To: patch@linaro.org Received: by 10.140.97.165 with SMTP id m34csp1743954qge; Tue, 8 Nov 2016 12:35:01 -0800 (PST) X-Received: by 10.99.119.9 with SMTP id s9mr21341479pgc.11.1478637301703; Tue, 08 Nov 2016 12:35:01 -0800 (PST) Return-Path: Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id mj3si32052763pab.275.2016.11.08.12.35.01 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 08 Nov 2016 12:35:01 -0800 (PST) Received-SPF: pass (google.com: domain of libc-alpha-return-74548-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org; spf=pass (google.com: domain of libc-alpha-return-74548-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) smtp.mailfrom=libc-alpha-return-74548-patch=linaro.org@sourceware.org; dmarc=fail (p=NONE dis=NONE) header.from=linaro.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:in-reply-to :references; q=dns; s=default; b=wPS7yDqe5++qA3e1LC3evwRGnxTWKlh dMQccwvNz2KPLHTuzYjxC2pcFuEeNuyKt2u3hJUltQg7/EctipcgdoWwX2Xx6QxE xxXKp6+ikB/B9iIKn33SwJnDzluFK0WEakMP7tlSBMJOcxQZLCAs7kygCwF9xUo3 +NOh3eIiRepY= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:in-reply-to :references; s=default; bh=dQ6NP5OQaaS/pEEY7JELduGQIYE=; b=kA6Eo fsjJVzVV5jyEgCcN6QCmrQ26pSohaRSRNiavFlC14gvZ7wYCzB3l9gYJgfkBazc9 6mGHj4DeyMZoWQuQUlsQxOTOSBn1ZEmZc79iWyRYtVptzGq6z0d+QVoR2VXOqOIz TjLJ5GbSbs77xKp/eKvtb/c8QgTF8axD4Z7Ig0= Received: (qmail 129025 invoked by alias); 8 Nov 2016 20:31:27 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 126219 invoked by uid 89); 8 Nov 2016 20:30:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, RCVD_IN_SORBS_SPAM, SPF_PASS autolearn=ham version=3.3.2 spammy=1130 X-HELO: mail-ua0-f176.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=bpFc5buOF22+NjxAi4Z2GDmPXXhWg+UG57StehDG/x8=; b=hK/8owbZGiROX2OrFKvA7EBrqQtlcfr5iFbhR+04O2biFPVLE6kE9SXjjg3nCJX5qw rfwixrOqFHZcSTLBe7cuWBVI/erBLni0AokjRulIlZAd2GDq+U+7if10HTltFUaXBmaS 8QziuzgITl2nrNcnvTsRDjwTzOJdS+N+zE1zcRpsWdy6YaMiyytGDE2iMG27Qb719cuu +ZSLWW0eFH2t2r6g2q3Tdm4azRr9HAliMWclxznvEKMPjGh3g4jHf51gHZNlRQ6gAac1 eINhof9ER9k3fLfalWvL4PtoCRGialEmdexyFfrUUXPzsL5ww04WbbHehGRJHiUHVGdl +VsQ== X-Gm-Message-State: ABUngvf1gzvM4Ft+DqstS0pPk0Em3O3mWhwX3AguSVWNXOpeiSVGiK2a8Yv3aDZu4Sv25Eqo X-Received: by 10.176.1.11 with SMTP id 11mr9686358uak.172.1478637041717; Tue, 08 Nov 2016 12:30:41 -0800 (PST) From: Adhemerval Zanella To: libc-alpha@sourceware.org Subject: [PATCH v3 17/17] Add SYSV shared memory test Date: Tue, 8 Nov 2016 18:30:07 -0200 Message-Id: <1478637007-31212-18-git-send-email-adhemerval.zanella@linaro.org> In-Reply-To: <1478637007-31212-1-git-send-email-adhemerval.zanella@linaro.org> References: <1478637007-31212-1-git-send-email-adhemerval.zanella@linaro.org> Changes from previous version: - Change some error strings (it was using message queue names). -- This patch adds a simple SYSV shared memory test to check for correct argument passing on kernel. The idea is neither to be an extensive testing nor to check for any specific Linux test. * sysvipc/Makefile (tests): Add test-sysvshm. * sysvipc/test-sysvshm.c: New file. --- ChangeLog | 3 ++ sysvipc/Makefile | 2 +- sysvipc/test-sysvshm.c | 130 +++++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 134 insertions(+), 1 deletion(-) create mode 100644 sysvipc/test-sysvshm.c -- 2.7.4 diff --git a/ChangeLog b/ChangeLog index 55c462b..0d51c50 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,8 @@ 2016-11-08 Adhemerval Zanella + * sysvipc/Makefile (tests): Add test-sysvshm. + * sysvipc/test-sysvshm.c: New file. + * sysdeps/unix/sysv/linux/alpha/syscalls.list (shmget): Remove. * sysdeps/unix/sysv/linux/arm/syscalls.list (shmget): Likewise. * sysdeps/unix/sysv/linux/generic/syscalls.list (shmget): Likewise. diff --git a/sysvipc/Makefile b/sysvipc/Makefile index 32d64dc..daede74 100644 --- a/sysvipc/Makefile +++ b/sysvipc/Makefile @@ -30,7 +30,7 @@ routines := ftok \ semop semget semctl semtimedop \ shmat shmdt shmget shmctl -tests := test-sysvmsg test-sysvsem +tests := test-sysvmsg test-sysvsem test-sysvshm include ../Rules diff --git a/sysvipc/test-sysvshm.c b/sysvipc/test-sysvshm.c new file mode 100644 index 0000000..b4cb7df --- /dev/null +++ b/sysvipc/test-sysvshm.c @@ -0,0 +1,130 @@ +/* Basic tests for SYSV shared memory functions. + Copyright (C) 2016 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +#include +#include +#include +#include +#include +#include +#include + +static void do_prepare (void); +#define PREPARE(argc, argv) do_prepare () +static int do_test (void); +#define TEST_FUNCTION do_test () + +/* This defines the `main' function and some more. */ +#include + +/* These are for the temporary file we generate. */ +static char *name; +static int shmid; + +static void +remove_shm (void) +{ + /* Enforce message queue removal in case o early test failure. + Ignore error since the shm maybe already being removed. */ + shmctl (shmid, IPC_RMID, 0); +} + +static void +do_prepare (void) +{ + int fd = create_temp_file ("tst-sysvshm.", &name); + if (fd == -1) + FAIL_EXIT1 ("cannot create temporary file (errno=%d)", errno); +} + +#define CHECK_EQ(v, k) \ + if ((v) != (k)) \ + FAIL_EXIT1("%d != %d", v, k) + +/* It is not an extensive test, but rather a functional one aimed to check + correct parameter passing on kernel. */ + +#define SHM_MODE 0666 + +static int +do_test (void) +{ + atexit (remove_shm); + + key_t key = ftok (name, 'G'); + if (key == -1) + FAIL_EXIT1 ("ftok failed"); + + long int pgsz = sysconf (_SC_PAGESIZE); + if (pgsz == -1) + FAIL_EXIT1 ("sysconf (_SC_PAGESIZE) failed (errno = %d)", errno); + + shmid = shmget(key, pgsz, IPC_CREAT | IPC_EXCL | SHM_MODE); + if (shmid == -1) + { + if (errno == ENOSYS) + FAIL_UNSUPPORTED ("shmget not supported"); + FAIL_EXIT1 ("shmget failed (errno=%d)", errno); + } + + /* Get shared memory kernel information and do some sanitiy checks. */ + struct shmid_ds shminfo; + if (shmctl (shmid, IPC_STAT, &shminfo) == -1) + FAIL_EXIT1 ("shmctl with IPC_STAT failed (errno=%d)", errno); + + if (shminfo.shm_perm.__key != key) + FAIL_EXIT1 ("shmid_ds::shm_perm::key (%d) != %d", + (int) shminfo.shm_perm.__key, (int) key); + if (shminfo.shm_perm.mode != SHM_MODE) + FAIL_EXIT1 ("shmid_ds::shm_perm::mode (%o) != %o", + shminfo.shm_perm.mode, SHM_MODE); + if (shminfo.shm_segsz != pgsz) + FAIL_EXIT1 ("shmid_ds::shm_segsz (%lu) != %lu", + (long unsigned) shminfo.shm_segsz, pgsz); + + /* Attach on shared memory and realize some operations. */ + int *shmem = shmat (shmid, NULL, 0); + if (shmem == (void*) -1) + FAIL_EXIT1 ("shmem failed (errno=%d)", errno); + + shmem[0] = 0x55555555; + shmem[32] = 0x44444444; + shmem[64] = 0x33333333; + shmem[128] = 0x22222222; + + if (shmdt (shmem) == -1) + FAIL_EXIT1 ("shmem failed (errno=%d)", errno); + + shmem = shmat (shmid, NULL, SHM_RDONLY); + if (shmem == (void*) -1) + FAIL_EXIT1 ("shmem failed (errno=%d)", errno); + + CHECK_EQ (shmem[0], 0x55555555); + CHECK_EQ (shmem[32], 0x44444444); + CHECK_EQ (shmem[64], 0x33333333); + CHECK_EQ (shmem[128], 0x22222222); + + if (shmdt (shmem) == -1) + FAIL_EXIT1 ("shmem failed (errno=%d)", errno); + + /* Finally free up the semnaphore resource. */ + if (shmctl (shmid, IPC_RMID, 0) == -1) + FAIL_EXIT1 ("semctl failed (errno=%d)", errno); + + return 0; +}