From patchwork Fri Jun 3 14:20:19 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella Netto X-Patchwork-Id: 69259 Delivered-To: patch@linaro.org Received: by 10.140.106.246 with SMTP id e109csp289559qgf; Fri, 3 Jun 2016 07:20:53 -0700 (PDT) X-Received: by 10.107.15.23 with SMTP id x23mr5727250ioi.36.1464963653765; Fri, 03 Jun 2016 07:20:53 -0700 (PDT) Return-Path: Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id m8si7809374pfa.242.2016.06.03.07.20.53 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 03 Jun 2016 07:20:53 -0700 (PDT) Received-SPF: pass (google.com: domain of libc-alpha-return-70159-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org; spf=pass (google.com: domain of libc-alpha-return-70159-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) smtp.mailfrom=libc-alpha-return-70159-patch=linaro.org@sourceware.org; dmarc=fail (p=NONE dis=NONE) header.from=linaro.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id; q=dns; s= default; b=LxUjZ7OuPHOdX1x8AY29mZXtLpSvDRNswswP7pNpZGQWIV2LvJmuH wS00+UWKJb3f0KW6hq+kS+3B6yowy0WEVJq2ZRHWR0Qg6bzLOrDb49uUP9jaFxpq eqPG0UpYuHvk9WsnlsMVeCQpJe/tyn99eSozomYngftgBifJIwfTn8= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id; s=default; bh=Si35rljL3XKq1qQPSHQFCuSrljU=; b=CI0I/6aTnsNpZF3Rb+osZd2O97BY JIBor1Vd9pyQgKlu0q0arVxy98l9E1WG884oxCnt6AXa8WnXncTw3I7ZZ0xvXtB4 2ndsx/E/DNAribV25lH7/U56NKtaZE05P6oqnbsPdfKQ5RYtKDvgSS8Rn7POIILL 5AmH2eoxu6BrHXE= Received: (qmail 9387 invoked by alias); 3 Jun 2016 14:20:43 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 9365 invoked by uid 89); 3 Jun 2016 14:20:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=rounds X-HELO: mail-yw0-f172.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id; bh=vaMO8iJBHTWYiYihvn+G1LkPXxqP8ReBFlVpPZ+5k6s=; b=CmZO8+rYf/09kZ8hhR965yIuDUEHWMv3/+nvD0kxGnDPfNcYmNYbuQ/Ug4+YyIZggM M+Y+z0wIvbz6R3OgEIYEcPmOS2uEQPDkQxsaFbnETdbTU+7llowD8iaMehLF4QkKQ6z9 YUAUqYJP+JOFrLVN7ViZkikEVFsrZ/49qDnA/DwMSTANEhZMSJzDV1dJSXkwBylYC9GN 78Nxmfb5lFhTbZAUp1602ssbW9dBiar4DdW4m4ecFbJ7PYfX6A8WS7BamGCIudZvAmcf dd56zrQ6PaR+P7v2TsMvG+U7tYP4tfa0nKOVeBDHvw8aVrxvWoeFW6XSVagExGuiBlYE RIZA== X-Gm-Message-State: ALyK8tIqEEYHVSLpwy5yJPUHdQ0y/e9TF0YZukSLYi0jfAFZYgXw2eq0us/iTkIw/LsRlppy X-Received: by 10.129.120.147 with SMTP id t141mr2516886ywc.51.1464963629825; Fri, 03 Jun 2016 07:20:29 -0700 (PDT) From: Adhemerval Zanella To: libc-alpha@sourceware.org Subject: [PATCH v2 1/2] Consolidate preadv/preadv64 implementation Date: Fri, 3 Jun 2016 11:20:19 -0300 Message-Id: <1464963620-24703-1-git-send-email-adhemerval.zanella@linaro.org> Changes from previous version: * Add preadv fallback implementation for architectures that do not define __ASSUME_PREADV (it was only on pread64 in previous iteration). * Add cancellation test on tst-cancel4.c. --- This patch consolidates all the preadv{64} implementation for Linux in only one (sysdeps/unix/sysv/linux/preadv{64}.c). It also removes the syscall from the auto-generation using assembly macros. It was based on previous pread/pread64 consolidation patch. The new macro SYSCALL_LL{64} is used to handle the offset argument and alias is created for __ASSUME_OFF_DIFF_OFF64 in case of pread64. Checked on x86_64, i386, aarch64, and powerpc64le. * misc/Makefile (CFLAGS-preadv.c): New variable: add cancellation required flags. (CFLAGS-preadv64.c): Likewise. * sysdeps/unix/sysv/linux/generic/wordsize-32/preadv.c: Remove file. * sysdeps/unix/sysv/linux/generic/wordsize-32/preadv64.c: Likewise. * sysdeps/unix/sysv/linux/mips/mips64/n64/preadv64.c: Likewise. * sysdeps/unix/sysv/linux/wordsize-64/preadv.c: Likewise. * sysdeps/unix/sysv/linux/wordsize-64/preadv64.: Likwise. * sysdeps/unix/sysv/linux/x86_64/x32/syscalls.list (preadv): Remove syscall from auto-generation. * sysdeps/unix/sysv/linux/preadv.c: Rewrite implementation. [WORDSIZE == 64] (preadv64): Remove macro. [!PREADV] (PREADV): Likewise. [!PREADV] (PREADV_REPLACEMENT): Likewise. [!PREADV] (PREAD): Likewise. [!PREADV] (OFF_T): Likewise. [!__ASSUME_PREADV] (PREADV_REPLACEMENT): Likewise. (LO_HI_LONG): Remove macro. [__WORDSIZE != 64 || __ASSUME_OFF_DIFF_OFF64] (preadv): Add function. * sysdeps/unix/sysv/linux/preadv64.c: Rewrite implementation. (PREADV): Remove macro. (PREADV_REPLACEMENTE): Likewise. (PREAD): Likewise. (OFF_T): Likewise. (preadv64): New function. * nptl/tst-cancel4.c (tf_preadv): Add test. --- ChangeLog | 29 ++++++++ misc/Makefile | 2 + nptl/tst-cancel4.c | 45 +++++++++++++ .../unix/sysv/linux/generic/wordsize-32/preadv.c | 38 ----------- .../unix/sysv/linux/generic/wordsize-32/preadv64.c | 38 ----------- sysdeps/unix/sysv/linux/mips/mips64/n64/preadv64.c | 1 - sysdeps/unix/sysv/linux/preadv.c | 77 +++++++--------------- sysdeps/unix/sysv/linux/preadv64.c | 59 +++++++++++++++-- sysdeps/unix/sysv/linux/wordsize-64/preadv.c | 64 ------------------ sysdeps/unix/sysv/linux/wordsize-64/preadv64.c | 1 - sysdeps/unix/sysv/linux/x86_64/x32/syscalls.list | 1 - 11 files changed, 155 insertions(+), 200 deletions(-) delete mode 100644 sysdeps/unix/sysv/linux/generic/wordsize-32/preadv.c delete mode 100644 sysdeps/unix/sysv/linux/generic/wordsize-32/preadv64.c delete mode 100644 sysdeps/unix/sysv/linux/mips/mips64/n64/preadv64.c delete mode 100644 sysdeps/unix/sysv/linux/wordsize-64/preadv.c delete mode 100644 sysdeps/unix/sysv/linux/wordsize-64/preadv64.c -- 2.7.4 diff --git a/misc/Makefile b/misc/Makefile index d7bbc85..658d4ba 100644 --- a/misc/Makefile +++ b/misc/Makefile @@ -88,6 +88,8 @@ CFLAGS-lsearch.c = $(uses-callbacks) CFLAGS-pselect.c = -fexceptions CFLAGS-readv.c = -fexceptions -fasynchronous-unwind-tables CFLAGS-writev.c = -fexceptions -fasynchronous-unwind-tables +CFLAGS-preadv.c = -fexceptions -fasynchronous-unwind-tables +CFLAGS-preadv64.c = -fexceptions -fasynchronous-unwind-tables CFLAGS-usleep.c = -fexceptions CFLAGS-syslog.c = -fexceptions CFLAGS-error.c = -fexceptions diff --git a/nptl/tst-cancel4.c b/nptl/tst-cancel4.c index 1478174..30c3850 100644 --- a/nptl/tst-cancel4.c +++ b/nptl/tst-cancel4.c @@ -1554,6 +1554,50 @@ tf_pwrite (void *arg) exit (1); } +static void * +tf_preadv (void *arg) +{ + int fd; + int r; + + if (arg == NULL) + // XXX If somebody can provide a portable test case in which pwrite() + // blocks we can enable this test to run in both rounds. + abort (); + + char fname[] = "/tmp/tst-cancel4-fd-XXXXXX"; + tempfd = fd = mkstemp (fname); + if (fd == -1) + printf ("%s: mkstemp failed\n", __FUNCTION__); + unlink (fname); + + r = pthread_barrier_wait (&b2); + if (r != 0 && r != PTHREAD_BARRIER_SERIAL_THREAD) + { + printf ("%s: barrier_wait failed\n", __FUNCTION__); + exit (1); + } + + r = pthread_barrier_wait (&b2); + if (r != 0 && r != PTHREAD_BARRIER_SERIAL_THREAD) + { + printf ("%s: barrier_wait failed\n", __FUNCTION__); + exit (1); + } + + ssize_t s; + pthread_cleanup_push (cl, NULL); + + char buf[100]; + struct iovec iov[1] = { [0] = { .iov_base = buf, .iov_len = sizeof (buf) } }; + s = preadv (fd, iov, 1, 0); + + pthread_cleanup_pop (0); + + printf ("%s: preadv returns with %zd\n", __FUNCTION__, s); + + exit (1); +} static void * tf_fsync (void *arg) @@ -2140,6 +2184,7 @@ static struct ADD_TEST (recv, 2, 0), ADD_TEST (recvfrom, 2, 0), ADD_TEST (recvmsg, 2, 0), + ADD_TEST (preadv, 2, 1), ADD_TEST (open, 2, 1), ADD_TEST (close, 2, 1), ADD_TEST (pread, 2, 1), diff --git a/sysdeps/unix/sysv/linux/generic/wordsize-32/preadv.c b/sysdeps/unix/sysv/linux/generic/wordsize-32/preadv.c deleted file mode 100644 index ec30d4c..0000000 --- a/sysdeps/unix/sysv/linux/generic/wordsize-32/preadv.c +++ /dev/null @@ -1,38 +0,0 @@ -/* Copyright (C) 2011-2016 Free Software Foundation, Inc. - This file is part of the GNU C Library. - Contributed by Chris Metcalf , 2011. - Based on work contributed by Ulrich Drepper , 1997. - - The GNU C Library is free software; you can redistribute it and/or - modify it under the terms of the GNU Lesser General Public - License as published by the Free Software Foundation; either - version 2.1 of the License, or (at your option) any later version. - - The GNU C Library is distributed in the hope that it will be useful, - but WITHOUT ANY WARRANTY; without even the implied warranty of - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - Lesser General Public License for more details. - - You should have received a copy of the GNU Lesser General Public - License along with the GNU C Library. If not, see - . */ - -#include -#include -#include -#include -#include - -#include -#include - -ssize_t -__libc_preadv (int fd, const struct iovec *vector, int count, off_t offset) -{ - assert (sizeof (offset) == 4); - return SYSCALL_CANCEL (preadv, fd, - vector, count, __ALIGNMENT_ARG - __LONG_LONG_PAIR (offset >> 31, offset)); -} -strong_alias (__libc_preadv, __preadv) -weak_alias (__libc_preadv, preadv) diff --git a/sysdeps/unix/sysv/linux/generic/wordsize-32/preadv64.c b/sysdeps/unix/sysv/linux/generic/wordsize-32/preadv64.c deleted file mode 100644 index fc008c6..0000000 --- a/sysdeps/unix/sysv/linux/generic/wordsize-32/preadv64.c +++ /dev/null @@ -1,38 +0,0 @@ -/* Copyright (C) 2011-2016 Free Software Foundation, Inc. - This file is part of the GNU C Library. - Contributed by Chris Metcalf , 2011. - Based on work contributed by Ulrich Drepper , 1997. - - The GNU C Library is free software; you can redistribute it and/or - modify it under the terms of the GNU Lesser General Public - License as published by the Free Software Foundation; either - version 2.1 of the License, or (at your option) any later version. - - The GNU C Library is distributed in the hope that it will be useful, - but WITHOUT ANY WARRANTY; without even the implied warranty of - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - Lesser General Public License for more details. - - You should have received a copy of the GNU Lesser General Public - License along with the GNU C Library. If not, see - . */ - -#include -#include -#include -#include - -#include -#include - -ssize_t -__libc_preadv64 (int fd, const struct iovec *vector, int count, off64_t offset) -{ - return SYSCALL_CANCEL (preadv, fd, - vector, count, __ALIGNMENT_ARG - __LONG_LONG_PAIR ((off_t) (offset >> 32), - (off_t) (offset & 0xffffffff))); -} - -strong_alias (__libc_preadv64, __preadv64) -weak_alias (__libc_preadv64, preadv64) diff --git a/sysdeps/unix/sysv/linux/mips/mips64/n64/preadv64.c b/sysdeps/unix/sysv/linux/mips/mips64/n64/preadv64.c deleted file mode 100644 index fd9320c..0000000 --- a/sysdeps/unix/sysv/linux/mips/mips64/n64/preadv64.c +++ /dev/null @@ -1 +0,0 @@ -/* Empty since the preadv syscall is equivalent. */ diff --git a/sysdeps/unix/sysv/linux/preadv.c b/sysdeps/unix/sysv/linux/preadv.c index ca8da33..f6958c3 100644 --- a/sysdeps/unix/sysv/linux/preadv.c +++ b/sysdeps/unix/sysv/linux/preadv.c @@ -15,67 +15,40 @@ License along with the GNU C Library; if not, see . */ -#include -#include -#include -#include -#if __WORDSIZE == 64 -/* Hide the preadv64 declaration. */ -# define preadv64 __redirect_preadv64 -#endif #include - #include -#include -#include - - -#ifndef PREADV -# define PREADV preadv -# define PREADV_REPLACEMENT __atomic_preadv_replacement -# define PREAD __pread -# define OFF_T off_t -#endif -#define LO_HI_LONG(val) \ - (off_t) val, \ - (off_t) ((((uint64_t) (val)) >> (sizeof (long) * 4)) >> (sizeof (long) * 4)) +#if __WORDSIZE != 64 || defined (__ASSUME_OFF_DIFF_OFF64) -#ifndef __ASSUME_PREADV -static ssize_t PREADV_REPLACEMENT (int, const struct iovec *, - int, OFF_T) internal_function; -#endif +# ifdef __ASSUME_PREADV +# ifndef __NR_preadv +# define __NR_preadv __NR_preadv64 +# endif ssize_t -PREADV (int fd, const struct iovec *vector, int count, OFF_T offset) +preadv (int fd, const struct iovec *vector, int count, off_t offset) { -#ifdef __NR_preadv - ssize_t result; - - result = SYSCALL_CANCEL (preadv, fd, vector, count, LO_HI_LONG (offset)); - -# ifdef __ASSUME_PREADV - return result; -# endif -#endif - -#ifndef __ASSUME_PREADV -# ifdef __NR_preadv + return SYSCALL_CANCEL (preadv, fd, vector, count, + __ALIGNMENT_ARG SYSCALL_LL (offset)); +} +# else +static ssize_t __atomic_preadv_replacement (int, const struct iovec *, + int, off_t) internal_function; +ssize_t +preadv (int fd, const struct iovec *vector, int count, off_t offset) +{ +# ifdef __NR_preadv + ssize_t result = SYSCALL_CANCEL (preadv, fd, vector, count, + __ALIGNMENT_ARG SYSCALL_LL (offset)); if (result >= 0 || errno != ENOSYS) return result; -# endif - - return PREADV_REPLACEMENT (fd, vector, count, offset); -#endif +# endif + return __atomic_preadv_replacement (fd, vector, count, offset); } -#if __WORDSIZE == 64 -# undef preadv64 -strong_alias (preadv, preadv64) -#endif - -#ifndef __ASSUME_PREADV -# undef PREADV -# define PREADV static internal_function PREADV_REPLACEMENT -# include +# define PREADV static internal_function __atomic_preadv_replacement +# define PREAD __pread +# define OFF_T off_t +# include +# endif /* __ASSUME_PREADV */ #endif diff --git a/sysdeps/unix/sysv/linux/preadv64.c b/sysdeps/unix/sysv/linux/preadv64.c index 936ff14..18f5550 100644 --- a/sysdeps/unix/sysv/linux/preadv64.c +++ b/sysdeps/unix/sysv/linux/preadv64.c @@ -1,6 +1,55 @@ -#define PREADV preadv64 -#define PREADV_REPLACEMENT __atomic_preadv64_replacement -#define PREAD __libc_pread64 -#define OFF_T off64_t +/* Copyright (C) 2016 Free Software Foundation, Inc. + This file is part of the GNU C Library. -#include "preadv.c" + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +#include +#include + +#ifdef __ASSUME_PREADV + +# ifndef __NR_preadv64 +# define __NR_preadv64 __NR_preadv +# endif + +ssize_t +preadv64 (int fd, const struct iovec *vector, int count, off64_t offset) +{ + return SYSCALL_CANCEL (preadv64, fd, vector, count, + __ALIGNMENT_ARG SYSCALL_LL64 (offset)); +} +#else +static ssize_t __atomic_preadv64_replacement (int, const struct iovec *, + int, off64_t) internal_function; +ssize_t +preadv64 (int fd, const struct iovec *vector, int count, off64_t offset) +{ +#ifdef __NR_preadv64 + ssize_t result = SYSCALL_CANCEL (preadv64, fd, vector, count, + __ALIGNMENT_ARG SYSCALL_LL64 (offset)); + if (result >= 0 || errno != ENOSYS) + return result; +#endif + return __atomic_preadv64_replacement (fd, vector, count, offset); +} +# define PREADV static internal_function __atomic_preadv64_replacement +# define PREAD __pread64 +# define OFF_T off64_t +# include +#endif + +#if __WORDSIZE == 64 && !defined (__ASSUME_OFF_DIFF_OFF64) +strong_alias (preadv64, preadv) +#endif diff --git a/sysdeps/unix/sysv/linux/wordsize-64/preadv.c b/sysdeps/unix/sysv/linux/wordsize-64/preadv.c deleted file mode 100644 index e2924ac..0000000 --- a/sysdeps/unix/sysv/linux/wordsize-64/preadv.c +++ /dev/null @@ -1,64 +0,0 @@ -/* 64-bit preadv. - Copyright (C) 2012-2016 Free Software Foundation, Inc. - This file is part of the GNU C Library. - - The GNU C Library is free software; you can redistribute it and/or - modify it under the terms of the GNU Lesser General Public - License as published by the Free Software Foundation; either - version 2.1 of the License, or (at your option) any later version. - - The GNU C Library is distributed in the hope that it will be useful, - but WITHOUT ANY WARRANTY; without even the implied warranty of - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - Lesser General Public License for more details. - - You should have received a copy of the GNU Lesser General Public - License along with the GNU C Library; if not, see - . */ - -#include -#include -#include -/* Hide the preadv64 declaration. */ -#define preadv64 __redirect_preadv64 -#include - -#include -#include -#include - -#ifndef __ASSUME_PREADV -static ssize_t __atomic_preadv_replacement (int, const struct iovec *, - int, off_t) internal_function; -#endif - -ssize_t -preadv (int fd, const struct iovec *vector, int count, off_t offset) -{ -#ifdef __NR_preadv - ssize_t result; - - result = SYSCALL_CANCEL (preadv, fd, vector, count, offset); -# ifdef __ASSUME_PREADV - return result; -# endif -#endif - -#ifndef __ASSUME_PREADV -# ifdef __NR_preadv - if (result >= 0 || errno != ENOSYS) - return result; -# endif - - return __atomic_preadv_replacement (fd, vector, count, offset); -#endif -} -#undef preadv64 -strong_alias (preadv, preadv64) - -#ifndef __ASSUME_PREADV -# define PREADV static internal_function __atomic_preadv_replacement -# define PREAD __pread -# define OFF_T off_t -# include -#endif diff --git a/sysdeps/unix/sysv/linux/wordsize-64/preadv64.c b/sysdeps/unix/sysv/linux/wordsize-64/preadv64.c deleted file mode 100644 index fd9320c..0000000 --- a/sysdeps/unix/sysv/linux/wordsize-64/preadv64.c +++ /dev/null @@ -1 +0,0 @@ -/* Empty since the preadv syscall is equivalent. */ diff --git a/sysdeps/unix/sysv/linux/x86_64/x32/syscalls.list b/sysdeps/unix/sysv/linux/x86_64/x32/syscalls.list index c98ac74..58cd7fc 100644 --- a/sysdeps/unix/sysv/linux/x86_64/x32/syscalls.list +++ b/sysdeps/unix/sysv/linux/x86_64/x32/syscalls.list @@ -4,6 +4,5 @@ fallocate - fallocate Ci:iiii fallocate fallocate64 gettimeofday - gettimeofday:__vdso_gettimeofday@LINUX_2.6 i:pP __gettimeofday gettimeofday personality EXTRA personality Ei:i __personality personality posix_fadvise - fadvise64 Vi:iiii posix_fadvise posix_fadvise64 -preadv - preadv Ci:ipii preadv preadv64 pwritev - pwritev Ci:ipii pwritev pwritev64 time - time:__vdso_time@LINUX_2.6 Ei:P time