mbox series

[0/4] Consolidation patches for bz12683

Message ID 1485784926-2172-1-git-send-email-adhemerval.zanella@linaro.org
Headers show
Series Consolidation patches for bz12683 | expand

Message

Adhemerval Zanella Jan. 30, 2017, 2:02 p.m. UTC
Hi all,

This patchset is the initial one I am proposing for upcoming BZ#12683
(Race conditions in pthread cancellation) [1].  General idea is to remove
all the auto-generation cancellation syscall from syscalls.list for
all architectures to simplifiy bz12683 fix.

These patches consolidates the accept, connect, recv, recvfrom, send,
and sendto Linux implementation on default ones.  I have tested
a full build/run on x86_64, i686, x32, powerpc64le, aarch64, and
armhf and a build/check for all other supported architectures
(with run-built-tests=no).  Besides the already broken hppa
build (due the new pthread condition) I saw no regressions.

[1] https://sourceware.org/bugzilla/show_bug.cgi?id=12683

Adhemerval Zanella (4):
  Consolidate Linux accept implementation
  Consolidate Linux connect implementation
  Consolidate Linux recv and recvfrom implementation
  Consolidate Linux send and sendto implementation

 ChangeLog                                          | 158 +++++++++++++++++++++
 sysdeps/unix/sysv/linux/aarch64/sysdep.h           |   4 +
 sysdeps/unix/sysv/linux/accept.c                   |   7 +-
 sysdeps/unix/sysv/linux/alpha/kernel-features.h    |   3 +
 sysdeps/unix/sysv/linux/alpha/syscalls.list        |   6 -
 sysdeps/unix/sysv/linux/arm/kernel-features.h      |   3 +
 sysdeps/unix/sysv/linux/arm/syscalls.list          |   6 -
 sysdeps/unix/sysv/linux/connect.c                  |   5 -
 sysdeps/unix/sysv/linux/generic/recv.c             |  32 -----
 sysdeps/unix/sysv/linux/generic/send.c             |  30 ----
 sysdeps/unix/sysv/linux/generic/syscalls.list      |   4 -
 sysdeps/unix/sysv/linux/hppa/kernel-features.h     |   3 +
 sysdeps/unix/sysv/linux/hppa/syscalls.list         |   6 -
 sysdeps/unix/sysv/linux/i386/kernel-features.h     |  11 +-
 sysdeps/unix/sysv/linux/ia64/kernel-features.h     |   3 +
 sysdeps/unix/sysv/linux/ia64/syscalls.list         |   6 -
 sysdeps/unix/sysv/linux/kernel-features.h          |   4 +
 sysdeps/unix/sysv/linux/m68k/kernel-features.h     |  12 +-
 .../unix/sysv/linux/microblaze/kernel-features.h   |   4 +-
 sysdeps/unix/sysv/linux/mips/kernel-features.h     |   3 +
 sysdeps/unix/sysv/linux/mips/mips64/recv.c         |   1 -
 sysdeps/unix/sysv/linux/mips/mips64/send.c         |   1 -
 sysdeps/unix/sysv/linux/mips/syscalls.list         |   6 -
 sysdeps/unix/sysv/linux/nios2/sysdep.h             |   4 +
 sysdeps/unix/sysv/linux/powerpc/kernel-features.h  |   2 -
 sysdeps/unix/sysv/linux/recv.c                     |   7 +-
 sysdeps/unix/sysv/linux/recvfrom.c                 |   5 -
 sysdeps/unix/sysv/linux/s390/kernel-features.h     |  11 +-
 sysdeps/unix/sysv/linux/send.c                     |   9 +-
 sysdeps/unix/sysv/linux/sendto.c                   |   5 -
 sysdeps/unix/sysv/linux/sh/kernel-features.h       |   4 -
 sysdeps/unix/sysv/linux/sparc/kernel-features.h    |   6 +
 .../unix/sysv/linux/sparc/sparc64/syscalls.list    |   6 -
 sysdeps/unix/sysv/linux/sysdep.h                   |   4 +
 sysdeps/unix/sysv/linux/tile/sysdep.h              |   4 +
 sysdeps/unix/sysv/linux/x86_64/recv.c              |  33 -----
 sysdeps/unix/sysv/linux/x86_64/send.c              |  31 ----
 sysdeps/unix/sysv/linux/x86_64/syscalls.list       |   4 -
 38 files changed, 221 insertions(+), 232 deletions(-)
 delete mode 100644 sysdeps/unix/sysv/linux/generic/recv.c
 delete mode 100644 sysdeps/unix/sysv/linux/generic/send.c
 delete mode 100644 sysdeps/unix/sysv/linux/mips/mips64/recv.c
 delete mode 100644 sysdeps/unix/sysv/linux/mips/mips64/send.c
 delete mode 100644 sysdeps/unix/sysv/linux/x86_64/recv.c
 delete mode 100644 sysdeps/unix/sysv/linux/x86_64/send.c

-- 
2.7.4

Comments

Adhemerval Zanella Feb. 20, 2017, 2:18 p.m. UTC | #1
Ping.

On 30/01/2017 12:02, Adhemerval Zanella wrote:
> Hi all,

> 

> This patchset is the initial one I am proposing for upcoming BZ#12683

> (Race conditions in pthread cancellation) [1].  General idea is to remove

> all the auto-generation cancellation syscall from syscalls.list for

> all architectures to simplifiy bz12683 fix.

> 

> These patches consolidates the accept, connect, recv, recvfrom, send,

> and sendto Linux implementation on default ones.  I have tested

> a full build/run on x86_64, i686, x32, powerpc64le, aarch64, and

> armhf and a build/check for all other supported architectures

> (with run-built-tests=no).  Besides the already broken hppa

> build (due the new pthread condition) I saw no regressions.

> 

> [1] https://sourceware.org/bugzilla/show_bug.cgi?id=12683

> 

> Adhemerval Zanella (4):

>   Consolidate Linux accept implementation

>   Consolidate Linux connect implementation

>   Consolidate Linux recv and recvfrom implementation

>   Consolidate Linux send and sendto implementation

> 

>  ChangeLog                                          | 158 +++++++++++++++++++++

>  sysdeps/unix/sysv/linux/aarch64/sysdep.h           |   4 +

>  sysdeps/unix/sysv/linux/accept.c                   |   7 +-

>  sysdeps/unix/sysv/linux/alpha/kernel-features.h    |   3 +

>  sysdeps/unix/sysv/linux/alpha/syscalls.list        |   6 -

>  sysdeps/unix/sysv/linux/arm/kernel-features.h      |   3 +

>  sysdeps/unix/sysv/linux/arm/syscalls.list          |   6 -

>  sysdeps/unix/sysv/linux/connect.c                  |   5 -

>  sysdeps/unix/sysv/linux/generic/recv.c             |  32 -----

>  sysdeps/unix/sysv/linux/generic/send.c             |  30 ----

>  sysdeps/unix/sysv/linux/generic/syscalls.list      |   4 -

>  sysdeps/unix/sysv/linux/hppa/kernel-features.h     |   3 +

>  sysdeps/unix/sysv/linux/hppa/syscalls.list         |   6 -

>  sysdeps/unix/sysv/linux/i386/kernel-features.h     |  11 +-

>  sysdeps/unix/sysv/linux/ia64/kernel-features.h     |   3 +

>  sysdeps/unix/sysv/linux/ia64/syscalls.list         |   6 -

>  sysdeps/unix/sysv/linux/kernel-features.h          |   4 +

>  sysdeps/unix/sysv/linux/m68k/kernel-features.h     |  12 +-

>  .../unix/sysv/linux/microblaze/kernel-features.h   |   4 +-

>  sysdeps/unix/sysv/linux/mips/kernel-features.h     |   3 +

>  sysdeps/unix/sysv/linux/mips/mips64/recv.c         |   1 -

>  sysdeps/unix/sysv/linux/mips/mips64/send.c         |   1 -

>  sysdeps/unix/sysv/linux/mips/syscalls.list         |   6 -

>  sysdeps/unix/sysv/linux/nios2/sysdep.h             |   4 +

>  sysdeps/unix/sysv/linux/powerpc/kernel-features.h  |   2 -

>  sysdeps/unix/sysv/linux/recv.c                     |   7 +-

>  sysdeps/unix/sysv/linux/recvfrom.c                 |   5 -

>  sysdeps/unix/sysv/linux/s390/kernel-features.h     |  11 +-

>  sysdeps/unix/sysv/linux/send.c                     |   9 +-

>  sysdeps/unix/sysv/linux/sendto.c                   |   5 -

>  sysdeps/unix/sysv/linux/sh/kernel-features.h       |   4 -

>  sysdeps/unix/sysv/linux/sparc/kernel-features.h    |   6 +

>  .../unix/sysv/linux/sparc/sparc64/syscalls.list    |   6 -

>  sysdeps/unix/sysv/linux/sysdep.h                   |   4 +

>  sysdeps/unix/sysv/linux/tile/sysdep.h              |   4 +

>  sysdeps/unix/sysv/linux/x86_64/recv.c              |  33 -----

>  sysdeps/unix/sysv/linux/x86_64/send.c              |  31 ----

>  sysdeps/unix/sysv/linux/x86_64/syscalls.list       |   4 -

>  38 files changed, 221 insertions(+), 232 deletions(-)

>  delete mode 100644 sysdeps/unix/sysv/linux/generic/recv.c

>  delete mode 100644 sysdeps/unix/sysv/linux/generic/send.c

>  delete mode 100644 sysdeps/unix/sysv/linux/mips/mips64/recv.c

>  delete mode 100644 sysdeps/unix/sysv/linux/mips/mips64/send.c

>  delete mode 100644 sysdeps/unix/sysv/linux/x86_64/recv.c

>  delete mode 100644 sysdeps/unix/sysv/linux/x86_64/send.c

>
Adhemerval Zanella March 6, 2017, 9:52 a.m. UTC | #2
If no one opposes it I would like to check this in.  I will check run
a full make check on alpha, sparc{v9,64}, and powerpc first.

On 20/02/2017 15:18, Adhemerval Zanella wrote:
> Ping.

> 

> On 30/01/2017 12:02, Adhemerval Zanella wrote:

>> Hi all,

>>

>> This patchset is the initial one I am proposing for upcoming BZ#12683

>> (Race conditions in pthread cancellation) [1].  General idea is to remove

>> all the auto-generation cancellation syscall from syscalls.list for

>> all architectures to simplifiy bz12683 fix.

>>

>> These patches consolidates the accept, connect, recv, recvfrom, send,

>> and sendto Linux implementation on default ones.  I have tested

>> a full build/run on x86_64, i686, x32, powerpc64le, aarch64, and

>> armhf and a build/check for all other supported architectures

>> (with run-built-tests=no).  Besides the already broken hppa

>> build (due the new pthread condition) I saw no regressions.

>>

>> [1] https://sourceware.org/bugzilla/show_bug.cgi?id=12683

>>

>> Adhemerval Zanella (4):

>>   Consolidate Linux accept implementation

>>   Consolidate Linux connect implementation

>>   Consolidate Linux recv and recvfrom implementation

>>   Consolidate Linux send and sendto implementation

>>

>>  ChangeLog                                          | 158 +++++++++++++++++++++

>>  sysdeps/unix/sysv/linux/aarch64/sysdep.h           |   4 +

>>  sysdeps/unix/sysv/linux/accept.c                   |   7 +-

>>  sysdeps/unix/sysv/linux/alpha/kernel-features.h    |   3 +

>>  sysdeps/unix/sysv/linux/alpha/syscalls.list        |   6 -

>>  sysdeps/unix/sysv/linux/arm/kernel-features.h      |   3 +

>>  sysdeps/unix/sysv/linux/arm/syscalls.list          |   6 -

>>  sysdeps/unix/sysv/linux/connect.c                  |   5 -

>>  sysdeps/unix/sysv/linux/generic/recv.c             |  32 -----

>>  sysdeps/unix/sysv/linux/generic/send.c             |  30 ----

>>  sysdeps/unix/sysv/linux/generic/syscalls.list      |   4 -

>>  sysdeps/unix/sysv/linux/hppa/kernel-features.h     |   3 +

>>  sysdeps/unix/sysv/linux/hppa/syscalls.list         |   6 -

>>  sysdeps/unix/sysv/linux/i386/kernel-features.h     |  11 +-

>>  sysdeps/unix/sysv/linux/ia64/kernel-features.h     |   3 +

>>  sysdeps/unix/sysv/linux/ia64/syscalls.list         |   6 -

>>  sysdeps/unix/sysv/linux/kernel-features.h          |   4 +

>>  sysdeps/unix/sysv/linux/m68k/kernel-features.h     |  12 +-

>>  .../unix/sysv/linux/microblaze/kernel-features.h   |   4 +-

>>  sysdeps/unix/sysv/linux/mips/kernel-features.h     |   3 +

>>  sysdeps/unix/sysv/linux/mips/mips64/recv.c         |   1 -

>>  sysdeps/unix/sysv/linux/mips/mips64/send.c         |   1 -

>>  sysdeps/unix/sysv/linux/mips/syscalls.list         |   6 -

>>  sysdeps/unix/sysv/linux/nios2/sysdep.h             |   4 +

>>  sysdeps/unix/sysv/linux/powerpc/kernel-features.h  |   2 -

>>  sysdeps/unix/sysv/linux/recv.c                     |   7 +-

>>  sysdeps/unix/sysv/linux/recvfrom.c                 |   5 -

>>  sysdeps/unix/sysv/linux/s390/kernel-features.h     |  11 +-

>>  sysdeps/unix/sysv/linux/send.c                     |   9 +-

>>  sysdeps/unix/sysv/linux/sendto.c                   |   5 -

>>  sysdeps/unix/sysv/linux/sh/kernel-features.h       |   4 -

>>  sysdeps/unix/sysv/linux/sparc/kernel-features.h    |   6 +

>>  .../unix/sysv/linux/sparc/sparc64/syscalls.list    |   6 -

>>  sysdeps/unix/sysv/linux/sysdep.h                   |   4 +

>>  sysdeps/unix/sysv/linux/tile/sysdep.h              |   4 +

>>  sysdeps/unix/sysv/linux/x86_64/recv.c              |  33 -----

>>  sysdeps/unix/sysv/linux/x86_64/send.c              |  31 ----

>>  sysdeps/unix/sysv/linux/x86_64/syscalls.list       |   4 -

>>  38 files changed, 221 insertions(+), 232 deletions(-)

>>  delete mode 100644 sysdeps/unix/sysv/linux/generic/recv.c

>>  delete mode 100644 sysdeps/unix/sysv/linux/generic/send.c

>>  delete mode 100644 sysdeps/unix/sysv/linux/mips/mips64/recv.c

>>  delete mode 100644 sysdeps/unix/sysv/linux/mips/mips64/send.c

>>  delete mode 100644 sysdeps/unix/sysv/linux/x86_64/recv.c

>>  delete mode 100644 sysdeps/unix/sysv/linux/x86_64/send.c

>>