From patchwork Wed Jun 19 08:33:16 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Stevan Radakovic X-Patchwork-Id: 17965 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-vb0-f70.google.com (mail-vb0-f70.google.com [209.85.212.70]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 5DD1E2397B for ; Wed, 19 Jun 2013 08:33:20 +0000 (UTC) Received: by mail-vb0-f70.google.com with SMTP id q12sf6649345vbe.9 for ; Wed, 19 Jun 2013 01:33:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-beenthere:x-forwarded-to:x-forwarded-for:delivered-to :mime-version:x-launchpad-project:x-launchpad-branch :x-launchpad-message-rationale:x-launchpad-branch-revision-number :x-launchpad-notification-type:to:from:subject:message-id:date :reply-to:sender:errors-to:precedence:x-generated-by :x-launchpad-hash:x-gm-message-state:x-original-sender :x-original-authentication-results:mailing-list:list-id :x-google-group-id:list-post:list-help:list-archive:list-unsubscribe :content-type; bh=CZjGrgtbBWmJ3uJl5YRG3YuRyjDXJ2DkkDLh8JIBOMo=; b=F103A4DC+gnaj3C8raSOAGd4ZE9k3xNvGGvaOXA2sexydwkBaX7SnMmXnXiT0ou6nY ZAqMsV/BEfRfJ7yja7wHbE1gCdEDxktBm4RaYr81uAJjlh4AuTOOleq4ATaVAWfSclmz r1VRcTlFELQuQu7LQVyOc7625fCJKA77E/iZH/6TPCYsArA5eijeIdpvNlxCm8xI2puB r3JdLj6RdeTxtleuxYmSVnzgs/z+v0pQl/cMZyhnue3Z+bNVJpXrhMld96H627NpjDtd OK3Ued3Pq4+9ASKyUku/MjuQwfyPle8e2IcZj1XZ8ezfGxTJDECpeK7IUYhBqxQT62cB PrCA== X-Received: by 10.236.78.198 with SMTP id g46mr1028159yhe.56.1371630799651; Wed, 19 Jun 2013 01:33:19 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.94.212 with SMTP id de20ls196220qeb.44.gmail; Wed, 19 Jun 2013 01:33:19 -0700 (PDT) X-Received: by 10.220.67.81 with SMTP id q17mr293931vci.64.1371630799477; Wed, 19 Jun 2013 01:33:19 -0700 (PDT) Received: from mail-vc0-f170.google.com (mail-vc0-f170.google.com [209.85.220.170]) by mx.google.com with ESMTPS id 6si2644823vca.87.2013.06.19.01.33.19 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 19 Jun 2013 01:33:19 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.220.170 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.170; Received: by mail-vc0-f170.google.com with SMTP id hf12so3627685vcb.29 for ; Wed, 19 Jun 2013 01:33:19 -0700 (PDT) X-Received: by 10.220.110.78 with SMTP id m14mr295921vcp.53.1371630799343; Wed, 19 Jun 2013 01:33:19 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.58.165.8 with SMTP id yu8csp99811veb; Wed, 19 Jun 2013 01:33:18 -0700 (PDT) X-Received: by 10.180.198.175 with SMTP id jd15mr1226948wic.28.1371630797726; Wed, 19 Jun 2013 01:33:17 -0700 (PDT) Received: from indium.canonical.com (indium.canonical.com. [91.189.90.7]) by mx.google.com with ESMTPS id m7si2181578wiz.65.2013.06.19.01.33.17 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Wed, 19 Jun 2013 01:33:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of bounces@canonical.com designates 91.189.90.7 as permitted sender) client-ip=91.189.90.7; Received: from ackee.canonical.com ([91.189.89.26]) by indium.canonical.com with esmtp (Exim 4.71 #1 (Debian)) id 1UpDpM-0005Lz-Sk for ; Wed, 19 Jun 2013 08:33:16 +0000 Received: from ackee.canonical.com (localhost [127.0.0.1]) by ackee.canonical.com (Postfix) with ESMTP id C64AFE1AC9 for ; Wed, 19 Jun 2013 08:33:16 +0000 (UTC) MIME-Version: 1.0 X-Launchpad-Project: lava-dashboard X-Launchpad-Branch: ~linaro-validation/lava-dashboard/trunk X-Launchpad-Message-Rationale: Subscriber X-Launchpad-Branch-Revision-Number: 409 X-Launchpad-Notification-Type: branch-revision To: Linaro Patch Tracker From: noreply@launchpad.net Subject: [Branch ~linaro-validation/lava-dashboard/trunk] Rev 409: Fix broken target goal validation on image reports page. Reviewed by stylesen. Message-Id: <20130619083316.6638.26034.launchpad@ackee.canonical.com> Date: Wed, 19 Jun 2013 08:33:16 -0000 Reply-To: noreply@launchpad.net Sender: bounces@canonical.com Errors-To: bounces@canonical.com Precedence: list X-Generated-By: Launchpad (canonical.com); Revision="16667"; Instance="launchpad-lazr.conf" X-Launchpad-Hash: f7eca7e4f788c3b438517e425506a59e50355032 X-Gm-Message-State: ALoCoQlt3TxWl3Qn/D46sfjqo+ghsYGWDV7zBZux4+YqS76RmQ/JkFkkx4MlBGbT65uUzIiGyRSl X-Original-Sender: noreply@launchpad.net X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.170 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Merge authors: Stevan Radaković (stevanr) Related merge proposals: https://code.launchpad.net/~stevanr/lava-dashboard/image-reports-fix3/+merge/170263 proposed by: Stevan Radaković (stevanr) review: Approve - Senthil Kumaran S (stylesen) ------------------------------------------------------------ revno: 409 [merge] committer: Stevan Radakovic branch nick: trunk timestamp: Wed 2013-06-19 10:32:36 +0200 message: Fix broken target goal validation on image reports page. Reviewed by stylesen. modified: dashboard_app/static/dashboard_app/js/image-report.js --- lp:lava-dashboard https://code.launchpad.net/~linaro-validation/lava-dashboard/trunk You are subscribed to branch lp:lava-dashboard. To unsubscribe from this branch go to https://code.launchpad.net/~linaro-validation/lava-dashboard/trunk/+edit-subscription === modified file 'dashboard_app/static/dashboard_app/js/image-report.js' --- dashboard_app/static/dashboard_app/js/image-report.js 2013-06-18 13:50:02 +0000 +++ dashboard_app/static/dashboard_app/js/image-report.js 2013-06-19 08:20:44 +0000 @@ -81,7 +81,7 @@ return false; } - if (!isNumeric($("#target_goal").val())) { + if ($("#target_goal").val() && !isNumeric($("#target_goal").val())) { alert("Target goal must be a numeric value."); return false; }