From patchwork Fri Jun 14 10:09:15 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Stevan Radakovic X-Patchwork-Id: 17924 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-qa0-f71.google.com (mail-qa0-f71.google.com [209.85.216.71]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 87CB125E08 for ; Fri, 14 Jun 2013 10:09:19 +0000 (UTC) Received: by mail-qa0-f71.google.com with SMTP id bv4sf120296qab.6 for ; Fri, 14 Jun 2013 03:09:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-beenthere:x-forwarded-to:x-forwarded-for:delivered-to :mime-version:x-launchpad-project:x-launchpad-branch :x-launchpad-message-rationale:x-launchpad-branch-revision-number :x-launchpad-notification-type:to:from:subject:message-id:date :reply-to:sender:errors-to:precedence:x-generated-by :x-launchpad-hash:x-gm-message-state:x-original-sender :x-original-authentication-results:mailing-list:list-id :x-google-group-id:list-post:list-help:list-archive:list-unsubscribe :content-type; bh=RA50jXv998deH3le7qmdEnlVG3RtMrqaPxK8Dm97Tkw=; b=mduB+9zzxLs0Sp33Qg2QJ4DTuX3edadimTqCmGysnMSJBpDQZXcexIy19PPrRxuAJz VQwkD0ycjChoOM4lfFLKPD+oqG6YTJVNa3cRLMwe1UQ4Cgfav1vnwWS1dQJkL7Js4dgK vykkMW9+HQwdpCqDJF7qesmB4HgsWicJgpInblBkcsbdGtfmJSiWGVLSw8BMLNASmzVU H9PcZes/Vv0rmOeQRGZqqejIP9VG6gkUiDLLovtd1+dLEgA+bITMf13Arpb5Ysa26Z1j kWr/LuVyswcWAkHm3PUxXbQR2oLzjT4pX1140zQ2P5y8ZeLZERBVmWrmoNrUpwMM9LQI EORQ== X-Received: by 10.236.137.99 with SMTP id x63mr826122yhi.39.1371204559127; Fri, 14 Jun 2013 03:09:19 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.94.84 with SMTP id da20ls141137qeb.46.gmail; Fri, 14 Jun 2013 03:09:18 -0700 (PDT) X-Received: by 10.52.249.41 with SMTP id yr9mr575318vdc.17.1371204558854; Fri, 14 Jun 2013 03:09:18 -0700 (PDT) Received: from mail-ve0-x22a.google.com (mail-ve0-x22a.google.com [2607:f8b0:400c:c01::22a]) by mx.google.com with ESMTPS id tn5si653679vdc.130.2013.06.14.03.09.18 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 14 Jun 2013 03:09:18 -0700 (PDT) Received-SPF: neutral (google.com: 2607:f8b0:400c:c01::22a is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=2607:f8b0:400c:c01::22a; Received: by mail-ve0-f170.google.com with SMTP id 14so310088vea.15 for ; Fri, 14 Jun 2013 03:09:18 -0700 (PDT) X-Received: by 10.52.36.115 with SMTP id p19mr570641vdj.8.1371204558751; Fri, 14 Jun 2013 03:09:18 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.58.191.99 with SMTP id gx3csp56303vec; Fri, 14 Jun 2013 03:09:17 -0700 (PDT) X-Received: by 10.14.7.133 with SMTP id 5mr2165617eep.115.1371204556745; Fri, 14 Jun 2013 03:09:16 -0700 (PDT) Received: from indium.canonical.com (indium.canonical.com. [91.189.90.7]) by mx.google.com with ESMTPS id w7si1264425eeg.78.2013.06.14.03.09.15 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Fri, 14 Jun 2013 03:09:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of bounces@canonical.com designates 91.189.90.7 as permitted sender) client-ip=91.189.90.7; Received: from ackee.canonical.com ([91.189.89.26]) by indium.canonical.com with esmtp (Exim 4.71 #1 (Debian)) id 1UnQwV-0007v4-AO for ; Fri, 14 Jun 2013 10:09:15 +0000 Received: from ackee.canonical.com (localhost [127.0.0.1]) by ackee.canonical.com (Postfix) with ESMTP id 3DB6BE07C5 for ; Fri, 14 Jun 2013 10:09:15 +0000 (UTC) MIME-Version: 1.0 X-Launchpad-Project: lava-dashboard X-Launchpad-Branch: ~linaro-validation/lava-dashboard/trunk X-Launchpad-Message-Rationale: Subscriber X-Launchpad-Branch-Revision-Number: 407 X-Launchpad-Notification-Type: branch-revision To: Linaro Patch Tracker From: noreply@launchpad.net Subject: [Branch ~linaro-validation/lava-dashboard/trunk] Rev 407: Fix couple of problems when build numbers are presented and not the build dates. Reviewed by styl... Message-Id: <20130614100915.849.3682.launchpad@ackee.canonical.com> Date: Fri, 14 Jun 2013 10:09:15 -0000 Reply-To: noreply@launchpad.net Sender: bounces@canonical.com Errors-To: bounces@canonical.com Precedence: list X-Generated-By: Launchpad (canonical.com); Revision="16667"; Instance="launchpad-lazr.conf" X-Launchpad-Hash: 38e94f66b4f740edb793cfd184fa166301205d92 X-Gm-Message-State: ALoCoQnomiwl6CV/3eq2fy1aYts0kHmNzCiKsA50xR+1V+MMEqdHomAEnejfZ93mSnKIWG/3uMA9 X-Original-Sender: noreply@launchpad.net X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 2607:f8b0:400c:c01::22a is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Merge authors: Stevan Radaković (stevanr) Related merge proposals: https://code.launchpad.net/~stevanr/lava-dashboard/image-reports-fix2/+merge/169370 proposed by: Stevan Radaković (stevanr) review: Approve - Senthil Kumaran S (stylesen) ------------------------------------------------------------ revno: 407 [merge] committer: Stevan Radakovic branch nick: trunk timestamp: Fri 2013-06-14 12:08:19 +0200 message: Fix couple of problems when build numbers are presented and not the build dates. Reviewed by stylesen. modified: dashboard_app/static/dashboard_app/js/image-report.js --- lp:lava-dashboard https://code.launchpad.net/~linaro-validation/lava-dashboard/trunk You are subscribed to branch lp:lava-dashboard. To unsubscribe from this branch go to https://code.launchpad.net/~linaro-validation/lava-dashboard/trunk/+edit-subscription === modified file 'dashboard_app/static/dashboard_app/js/image-report.js' --- dashboard_app/static/dashboard_app/js/image-report.js 2013-06-13 08:26:40 +0000 +++ dashboard_app/static/dashboard_app/js/image-report.js 2013-06-14 09:11:32 +0000 @@ -69,7 +69,7 @@ build_number_end = parseInt(build_number_end); } - if (build_number_start > build_number_end) { + if (build_number_start >= build_number_end) { alert("End build number must be greater then the start build number."); return false; } @@ -218,8 +218,8 @@ row = table_data[test]; for (iter in row) { - build_number = column_data[iter]["number"].split('.')[0]; - if (build_number <= $("#build_number_end").val() && build_number >= $("#build_number_start").val()) { + + if (test_build_number(column_data, iter)) { if (row[iter]["cls"]) { if ($('input:radio[name=graph_type]:checked').val() == "number") { row_data.push([iter, row[iter]["passes"]]); @@ -242,8 +242,7 @@ row_data = []; row = table_data[test_run_names[0]]; for (iter in row) { - build_number = column_data[iter]["number"].split('.')[0]; - if (build_number <= $("#build_number_end").val() && build_number >= $("#build_number_start").val()) { + if (test_build_number(column_data, iter)) { row_data.push([iter, $("#target_goal").val()]); } }