From patchwork Thu May 11 15:13:23 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leif Lindholm X-Patchwork-Id: 99661 Delivered-To: patch@linaro.org Received: by 10.182.142.97 with SMTP id rv1csp734925obb; Thu, 11 May 2017 08:34:18 -0700 (PDT) X-Received: by 10.55.150.71 with SMTP id y68mr966627qkd.193.1494516858058; Thu, 11 May 2017 08:34:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1494516858; cv=none; d=google.com; s=arc-20160816; b=mI4pmeBLSvbGT66W8N9YEyt8Ub2+P96dLB0Xve1P/YXegRUaZ1tdzr9PmRKUMHCU95 /RVTTmJpblyLee3MrGRcXiKoHnTu3EaMyZHIsoFV0f+KrHWTZBPoBsxql141wDfBkY/i T74peFv52tkU0eyPOASGQkp2PDGlZRNUH1ZZwAVUvcWrFGXBr9cBrylPj6a6BNFw5OSu 839e67ngkOWnhuLUVLwKkiDrKJ0qfVUZY3ZTAbFrsFCPv+nPTd86Y2MLxWnmM0syOG6/ 3bBh/T7bbQa4NBSeLbfwIBht3O3amWDGaY+PK5DoO99OwX2oxHk+0iYoOIiHI+KNUHlK CnxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:reply-to:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:to:subject:message-id:date:from:mime-version :dkim-signature:arc-authentication-results; bh=nmffu8SoLwVmnmPE3s7JlRALYxFCtFp8+4TjWQwsA84=; b=O6aMi+K6pPwzXJgVw7qcBADCvqC5r/CNEaNebOL+ahlS6kOkQSFs4LYE4rFN0tR2um OmDy2XR6OTdlShDOdkZuu2BxLFjNrVmG7lw4CUyJ6raidKAPkZ1zou6C3ajhqTBuKUeP d4M/1KUn5mGmmfMkTdNNHyZolS5xHgxgoVHzx4NkLO6PRifYRYuzJoyIFzZ0ez12+eLr E61P7342DytSvhAX/siY0LBFkEoDNoSIg6HmOYdKX31wfyd6RzTrxoeXViigbt14UphE xk9mwl3i8VkrFZlGEh5KcJDO0dEg7/jz7mk6yhHdPyktJKvpStpSYnbz+aBcIXjAlu4z t85Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org; spf=pass (google.com: domain of grub-devel-bounces+patch=linaro.org@gnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=grub-devel-bounces+patch=linaro.org@gnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id w202si433423qka.93.2017.05.11.08.34.17 for (version=TLS1 cipher=AES128-SHA bits=128/128); Thu, 11 May 2017 08:34:18 -0700 (PDT) Received-SPF: pass (google.com: domain of grub-devel-bounces+patch=linaro.org@gnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org; spf=pass (google.com: domain of grub-devel-bounces+patch=linaro.org@gnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=grub-devel-bounces+patch=linaro.org@gnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:48876 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8q6b-0007OS-Kg for patch@linaro.org; Thu, 11 May 2017 11:34:17 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54811) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d8pmQ-0005Cs-9H for grub-devel@gnu.org; Thu, 11 May 2017 11:13:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d8pmP-0007C4-CR for grub-devel@gnu.org; Thu, 11 May 2017 11:13:26 -0400 Received: from mail-qk0-x22c.google.com ([2607:f8b0:400d:c09::22c]:33089) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d8pmP-0007Bc-6i for grub-devel@gnu.org; Thu, 11 May 2017 11:13:25 -0400 Received: by mail-qk0-x22c.google.com with SMTP id y201so25112456qka.0 for ; Thu, 11 May 2017 08:13:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:from:date:message-id:subject:to; bh=GeTbBfntoeF0/zO4KKulPuAcRIXPKYhsWJIYvyvA8eA=; b=V9Xw/ZKkngl5vU8aZMB+13818l/j+45o0Q4ODbbLVsErk52nXyi/UUuBNdBwyBfkW5 2SL/t11Aa1TgP0r8W/19ZcCx3xcPBMz68IAGfEDwIJGz/ad77b2c/peL1QPzY0nIVWP6 q4BqMnuTm6X4L/YkBL79iKoRKNelpd9+lWpc4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=GeTbBfntoeF0/zO4KKulPuAcRIXPKYhsWJIYvyvA8eA=; b=g2/+iEJ73nJpfQIb5gHIzCDFg/5AP154SNtun9a1c9JQeSkFZdBO4/ASQXg5i9V/uD pe5sYtckkMGgECL3fvlqwfoQIBDyIEFETxwLhERaY7vBaGSVUtZ7oj8ASJ08k4K3V3J/ 2iTTW1gb23i6L5fVbtLUH+MywB4tZL2ZIHQIE2rSRbczKiGrVT/6Y8Oa9Jh1Zvt9U4ld 3KHM9Gq7St5PGv8LvbO99MKX6wld4f09F3UCYVXMabdOW6l1pE2NLZBvjSWRTDTL77a3 IOFdULqIeytkMLBX/TPl5DOEMbkHHhVBAqjKQNxaj9w7IXgz9S9rmAr2fk5Pa3h0yJhc Tb9Q== X-Gm-Message-State: AODbwcB3VQKR87LNow6eTTozMQRqryc+Vx+7dwjvn/mpCl8a3prUQ8jQ 4gSDAlN7fTPQd90HkWg1uEIYIAG0LBBxmCX9oA== X-Received: by 10.55.188.5 with SMTP id m5mr843984qkf.195.1494515604299; Thu, 11 May 2017 08:13:24 -0700 (PDT) MIME-Version: 1.0 Received: by 10.200.54.119 with HTTP; Thu, 11 May 2017 08:13:23 -0700 (PDT) From: Leif Lindholm Date: Thu, 11 May 2017 16:13:23 +0100 Message-ID: Subject: "arm_coreboot: Support DMA" breaks arm64 To: The development of GNU GRUB X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::22c X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: The development of GNU GRUB Errors-To: grub-devel-bounces+patch=linaro.org@gnu.org Sender: "Grub-devel" Commit 265292f ("arm_coreboot: Support DMA") breaks arm64 grub-mkimage with: /work/local/bin/grub-mkimage: error: undefined symbol grub_arch_sync_dma_caches. This appears to be caused purely by the false symbol dependency created by the non-x86 version being an EXPORT_FUNC, in order to be usable by modules. A not very pretty but functional workaround is: #endif #endif Thoughts? / Leif _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel diff --git a/include/grub/cache.h b/include/grub/cache.h index 1c98ce2..cc4c833 100644 --- a/include/grub/cache.h +++ b/include/grub/cache.h @@ -40,7 +40,7 @@ grub_arch_sync_dma_caches (volatile void *address __attribute__ ((unused)), grub_size_t len __attribute__ ((unused))) { } -#else +#elif !defined (__aarch64__) void EXPORT_FUNC(grub_arch_sync_dma_caches) (volatile void *address, grub_size_t len);