From patchwork Tue Jun 2 14:55:31 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leif Lindholm X-Patchwork-Id: 49408 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-la0-f69.google.com (mail-la0-f69.google.com [209.85.215.69]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id D9E2020BD1 for ; Tue, 2 Jun 2015 14:55:47 +0000 (UTC) Received: by lani11 with SMTP id i11sf46106664lan.3 for ; Tue, 02 Jun 2015 07:55:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:date:from:to:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent :precedence:reply-to:list-id:list-unsubscribe:list-archive:list-post :list-help:list-subscribe:content-type:content-transfer-encoding :errors-to:sender:x-original-sender :x-original-authentication-results:mailing-list; bh=YmK3KlrMGq5EYk68yIvLLVf/Bpp7Nbp/1wetsV23ilY=; b=aMGAYDqqx9AMULetFirUizrJ1FHpd06Yijcf/j9LD9xCT7g/XnGyEuq+X1Qu7Q+U5O nYApvp9tQ9WoJnHuwBiPWP2kve+t/4dOI62OPhCcPkMUDleV4nS9lNX7ZPrMWB+qUyUk pHNJ2mwwo+TmyHHZ37A8Ah1hQJ53q35BnlfYMvZKH3+4gKT0/tU+fVetLueoHVdjq/c7 xjTZ1CUpU8qxgvRbR7WfuijpnGZKd9UVp/pVQnv8NIjAUyy9XjsWTLpBv9otI6AVHoCs HI0XXUFuf9pxe+1Nb3EXobg+XYT/oYeD/tvFgHQPiEByDddfb6019vpOYMkUuU2TqpDT sseA== X-Gm-Message-State: ALoCoQn2jV3XwVZt14IPIDsn7V2CKVlYyglqf+j9gZVayBc7ceZSIOci5SLbQ4/yd4d7arTwOkoG X-Received: by 10.112.171.41 with SMTP id ar9mr26224470lbc.24.1433256946682; Tue, 02 Jun 2015 07:55:46 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.5.1 with SMTP id o1ls829335lao.12.gmail; Tue, 02 Jun 2015 07:55:46 -0700 (PDT) X-Received: by 10.112.156.231 with SMTP id wh7mr22224250lbb.118.1433256946529; Tue, 02 Jun 2015 07:55:46 -0700 (PDT) Received: from mail-lb0-f178.google.com (mail-lb0-f178.google.com. [209.85.217.178]) by mx.google.com with ESMTPS id wo9si15267346lbb.170.2015.06.02.07.55.46 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 Jun 2015 07:55:46 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.178 as permitted sender) client-ip=209.85.217.178; Received: by lbbuc2 with SMTP id uc2so106261178lbb.2 for ; Tue, 02 Jun 2015 07:55:46 -0700 (PDT) X-Received: by 10.112.182.4 with SMTP id ea4mr21602042lbc.35.1433256946430; Tue, 02 Jun 2015 07:55:46 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.108.230 with SMTP id hn6csp3132560lbb; Tue, 2 Jun 2015 07:55:45 -0700 (PDT) X-Received: by 10.140.101.97 with SMTP id t88mr29622205qge.9.1433256945023; Tue, 02 Jun 2015 07:55:45 -0700 (PDT) Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id q5si16015663qce.7.2015.06.02.07.55.44 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 02 Jun 2015 07:55:45 -0700 (PDT) Received-SPF: pass (google.com: domain of grub-devel-bounces+patch=linaro.org@gnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Received: from localhost ([::1]:58927 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YznbU-0003g3-4S for patch@linaro.org; Tue, 02 Jun 2015 10:55:44 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38601) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YznbP-0003ft-Pu for grub-devel@gnu.org; Tue, 02 Jun 2015 10:55:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YznbL-0005Wj-KB for grub-devel@gnu.org; Tue, 02 Jun 2015 10:55:39 -0400 Received: from mail-wi0-f180.google.com ([209.85.212.180]:35939) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YznbL-0005Us-EW for grub-devel@gnu.org; Tue, 02 Jun 2015 10:55:35 -0400 Received: by wibdq8 with SMTP id dq8so61803974wib.1 for ; Tue, 02 Jun 2015 07:55:34 -0700 (PDT) X-Received: by 10.194.235.100 with SMTP id ul4mr50292149wjc.33.1433256934066; Tue, 02 Jun 2015 07:55:34 -0700 (PDT) Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by mx.google.com with ESMTPSA id k2sm22038092wif.3.2015.06.02.07.55.33 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 02 Jun 2015 07:55:33 -0700 (PDT) Date: Tue, 2 Jun 2015 15:55:31 +0100 From: Leif Lindholm To: The development of GNU GRUB Subject: Re: arm64 softfloat Message-ID: <20150602145531.GK8790@bivouac.eciton.net> References: <20150602120917.GI8790@bivouac.eciton.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.212.180 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Errors-To: grub-devel-bounces+patch=linaro.org@gnu.org Sender: grub-devel-bounces+patch=linaro.org@gnu.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: leif.lindholm@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.178 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 On Tue, Jun 02, 2015 at 02:25:15PM +0200, Vladimir 'phcoder' Serbinenko wrote: > Please give more details as to where we have floats. We shouldn't have any Ok, seems I was tripping over myself with the internal compiler error workaround (-mgeneral-regs-only), and applying it on the host tools as well, where +nofp was (correctly) not being enforced, causing a clash. So, rewinding a bit - in order to work around the gcc 5.1 build issue (which is not Fedora specific), we can use -mgeneral-regs-only instead of -march=armv8-a+nofp. If we do this, we can also get rid of the arm64-specific twiddling that drops the +nosimd. Like so: >From 43d4231432838821cabe4f6aea4f0f50e87af9c4 Mon Sep 17 00:00:00 2001 From: Leif Lindholm Date: Tue, 2 Jun 2015 15:41:09 +0100 Subject: [PATCH] configure.ac: clean up arm64 soft-float handling Fix compilation with gcc 5.1 (avoid internal compiler error), by replacing explicit -march +nofp+nosimd options with -mgeneral-regs-only. This also enables the removal of some further conditional build flag setting. --- configure.ac | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/configure.ac b/configure.ac index 891c14f..fd8a62e 100644 --- a/configure.ac +++ b/configure.ac @@ -686,9 +686,9 @@ if test x"$platform" != xemu ; then AC_CACHE_CHECK([for options to get soft-float], grub_cv_target_cc_soft_float, [ grub_cv_target_cc_soft_float=no if test "x$target_cpu" = xarm64; then - CFLAGS="$TARGET_CFLAGS -march=armv8-a+nofp+nosimd -Werror" + CFLAGS="$TARGET_CFLAGS -mgeneral-regs-only -Werror" AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[]], [[]])], - [grub_cv_target_cc_soft_float="-march=armv8-a+nofp+nosimd"], []) + [grub_cv_target_cc_soft_float="-mgeneral-regs-only"], []) fi if test "x$target_cpu" = xia64; then CFLAGS="$TARGET_CFLAGS -mno-inline-float-divide -mno-inline-sqrt -Werror" @@ -720,15 +720,7 @@ if test x"$platform" != xemu ; then TARGET_CFLAGS="$TARGET_CFLAGS $grub_cv_target_cc_soft_float" ;; esac - case x"$grub_cv_target_cc_soft_float" in - x"-march=armv8-a+nofp+nosimd") - # +nosimd disables also the cache opcodes that we need in asm. - TARGET_CCASFLAGS="$TARGET_CCASFLAGS -march=armv8-a+nofp" - ;; - *) - TARGET_CCASFLAGS="$TARGET_CCASFLAGS $grub_cv_target_cc_soft_float" - ;; - esac + TARGET_CCASFLAGS="$TARGET_CCASFLAGS $grub_cv_target_cc_soft_float" fi