From patchwork Fri May 23 08:03:55 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ramana Radhakrishnan X-Patchwork-Id: 30680 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-vc0-f197.google.com (mail-vc0-f197.google.com [209.85.220.197]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id C5A902066E for ; Fri, 23 May 2014 08:04:13 +0000 (UTC) Received: by mail-vc0-f197.google.com with SMTP id id10sf6900406vcb.4 for ; Fri, 23 May 2014 01:04:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:mailing-list:precedence:list-id :list-unsubscribe:list-subscribe:list-archive:list-post:list-help :sender:delivered-to:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:x-original-sender :x-original-authentication-results:content-type; bh=W7akHpB8cLphQw5bGsMgm6y8/gZtwtEwspS27dybf2g=; b=GpJPIwBKCf2bZ2VEs+oQAFacS1/i849GrbNShrO8NmjWICbD1zI2EfyxNZiPdhzMbl QoFYvUtXKhcf8659eS/mOrbwJ6Nfq+8XPSRm0hmlortsxLiTor2AzbWJZi9Y2MNxodTQ odY8cw6hFKwMJXPTFQX/0z/NBzkla7n/vknLvtMJ37DpLVT8Ve37Btq/omfl+NWCjEbX CP99mE6SQrRdi5Vdkqyi1OPJEJhXMkBdjJt/H7eRnOpPCqp387GEBxrPNnG4YlnrYtUb D3wrPzvEYyZwzF7mSo9AZ5Oq+tQ2tXnQpMTR/mWcplhd0Zd9EF5H0WsLtMe/aULRAUL5 U7BQ== X-Gm-Message-State: ALoCoQmOErDrvaqBZmRqwcLyk7sWASMOGgDFdjpg8NtTsi2fZzj31SnmZS82fN5W3BrNgq6C2FpK X-Received: by 10.58.41.39 with SMTP id c7mr1030322vel.25.1400832253335; Fri, 23 May 2014 01:04:13 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.82.231 with SMTP id h94ls1672340qgd.49.gmail; Fri, 23 May 2014 01:04:13 -0700 (PDT) X-Received: by 10.220.159.4 with SMTP id h4mr2831996vcx.1.1400832253098; Fri, 23 May 2014 01:04:13 -0700 (PDT) Received: from mail-ve0-x232.google.com (mail-ve0-x232.google.com [2607:f8b0:400c:c01::232]) by mx.google.com with ESMTPS id rl9si1242232vec.18.2014.05.23.01.04.13 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 23 May 2014 01:04:13 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 2607:f8b0:400c:c01::232 as permitted sender) client-ip=2607:f8b0:400c:c01::232; Received: by mail-ve0-f178.google.com with SMTP id sa20so5857813veb.37 for ; Fri, 23 May 2014 01:04:13 -0700 (PDT) X-Received: by 10.58.246.132 with SMTP id xw4mr2922405vec.2.1400832253009; Fri, 23 May 2014 01:04:13 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.221.72 with SMTP id ib8csp11177vcb; Fri, 23 May 2014 01:04:12 -0700 (PDT) X-Received: by 10.69.25.69 with SMTP id io5mr3972748pbd.22.1400832251899; Fri, 23 May 2014 01:04:11 -0700 (PDT) Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id ws7si2727923pab.233.2014.05.23.01.04.11 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 May 2014 01:04:11 -0700 (PDT) Received-SPF: pass (google.com: domain of gdb-patches-return-112744-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Received: (qmail 28823 invoked by alias); 23 May 2014 08:04:05 -0000 Mailing-List: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org Precedence: list List-Id: List-Unsubscribe: , List-Subscribe: List-Archive: List-Post: , List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 28804 invoked by uid 89); 23 May 2014 08:04:04 -0000 X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL, BAYES_00, RP_MATCHES_RCVD, SPF_PASS autolearn=ham version=3.3.2 X-HELO: collaborate-mta1.arm.com Received: from fw-tnat.austin.arm.com (HELO collaborate-mta1.arm.com) (217.140.110.23) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 23 May 2014 08:04:03 +0000 Received: from [10.1.209.147] (e104577-lin.cambridge.arm.com [10.1.209.147]) by collaborate-mta1.arm.com (Postfix) with ESMTPS id 335FE13F64F; Fri, 23 May 2014 03:03:56 -0500 (CDT) Message-ID: <537F00EB.5090601@arm.com> Date: Fri, 23 May 2014 09:03:55 +0100 From: Ramana Radhakrishnan User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:14.0) Gecko/20120713 Thunderbird/14.0 MIME-Version: 1.0 To: Joel Brobecker CC: "gdb-patches@sourceware.org" , Marcus Shawcroft Subject: Re: [Patch AArch64] Include asm/ptrace.h in aarch64-linux-nat.c References: <537DBDF3.1080907@arm.com> <20140522124927.GR22822@adacore.com> In-Reply-To: <20140522124927.GR22822@adacore.com> X-Original-Sender: ramana.radhakrishnan@arm.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 2607:f8b0:400c:c01::232 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org; dkim=pass header.i=@sourceware.org X-Google-Group-Id: 836684582541 On 05/22/14 13:49, Joel Brobecker wrote: >> A recent change to glibc removed asm/ptrace.h from user.h for >> AArch64. This meant that cross-native builds of gdb using trunk >> glibc broke because aarch64-linux-nat.c because user_hwdebug_state >> couldn't be found. >> >> Fixed by including asm/ptrace.h like other ports. > > Thanks for the explanation. Can you make sure you include that > in the revision history of your commit? > >> 2014-05-22 Ramana Radhakrishnan >> >> * aarch64-linux-nat.c (asm/ptrace.h): Include. >> > > OK to push. Thank you. > > Thanks - I've got a similar one in gdbserver which I somehow managed to miss yesterday. Ok to push ? regards Ramana commit e9dae05e9c32efda9724330c6d5ade3ca848591d Author: Ramana Radhakrishnan Date: Fri May 23 09:01:14 2014 +0100 Include asm/ptrace.h for linux-aarch64-low.c A recent change to glibc removed asm/ptrace.h from user.h for AArch64. This meant that cross-native builds of gdbserver using trunk glibc broke because linux-aarch64-low.c because user_hwdebug_state couldn't be found. This is like commit #036cd38182bde32d8297b630cd5c861d53b8949e 2014-05-23 Ramana Radhakrishnan * linux-aarch64-low.c (asm/ptrace.h): Include. diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog index 81bd30e..e591108 100644 --- a/gdb/gdbserver/ChangeLog +++ b/gdb/gdbserver/ChangeLog @@ -1,3 +1,7 @@ +2014-05-23 Ramana Radhakrishnan + + * linux-aarch64-low.c (asm/ptrace.h): Include. + 2014-05-21 Jan Kratochvil Fix TLS access for -static -pthread. diff --git a/gdb/gdbserver/linux-aarch64-low.c b/gdb/gdbserver/linux-aarch64-low.c index 033e79e..6066e15 100644 --- a/gdb/gdbserver/linux-aarch64-low.c +++ b/gdb/gdbserver/linux-aarch64-low.c @@ -26,6 +26,7 @@ #include #include #include +#include #include #include "gdb_proc_service.h"