From patchwork Sun Nov 24 23:48:40 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Omair Javaid X-Patchwork-Id: 21729 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ie0-f197.google.com (mail-ie0-f197.google.com [209.85.223.197]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id DB6E123FCB for ; Sun, 24 Nov 2013 23:48:49 +0000 (UTC) Received: by mail-ie0-f197.google.com with SMTP id e14sf12404233iej.0 for ; Sun, 24 Nov 2013 15:48:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:message-id:date:from:user-agent :mime-version:to:cc:subject:references:in-reply-to:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe:content-type :content-transfer-encoding; bh=N/InXlvnr6Ha+L5l90LCb5gJAlIYevigf/4xQ2Cf2Lc=; b=SaPdszboY5PZA/i+Efva6fzDHXAGrnrqEDBMSUhKOpVj00cGLgaQg8O25aspXW9JJ7 XNET5U1D2I2+p3oHue1iRU7tWW+uZtBCqNUv5fm+X2ULNS7DAEDIL9eF5MXNdiCejwMe kDn/yeAhgDbd9ySrWQaVdf30TOAaYCeCwtzVjKyAJ/l9/sTqJvrTgJS6f8yKt27Yi/gI PypO6i74KDSxKh4jzQKUA7vLc1F3HuU4DMoZDiOBU2qBLl6eOtccODpQRnRSMxXJqk/N sgNgL9hvGL0zQ5bEQNgRgWykp82gWGgfMQGmUWZ98conO03bgwpzvxrBToKxxOT9Kz+l Xujw== X-Gm-Message-State: ALoCoQnpjQDXiFqtXpdLdIiJLgE0w6K0DX8sK0BrDE+RJHVB5h2EQZUqogf5ZvJXLQhICjaaVZK3 X-Received: by 10.42.136.136 with SMTP id u8mr6755224ict.16.1385336929253; Sun, 24 Nov 2013 15:48:49 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.128.138 with SMTP id no10ls1754002qeb.18.gmail; Sun, 24 Nov 2013 15:48:49 -0800 (PST) X-Received: by 10.58.133.77 with SMTP id pa13mr145716veb.21.1385336929144; Sun, 24 Nov 2013 15:48:49 -0800 (PST) Received: from mail-vc0-f177.google.com (mail-vc0-f177.google.com [209.85.220.177]) by mx.google.com with ESMTPS id sl9si1944913vdc.99.2013.11.24.15.48.48 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 24 Nov 2013 15:48:48 -0800 (PST) Received-SPF: neutral (google.com: 209.85.220.177 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.177; Received: by mail-vc0-f177.google.com with SMTP id hv10so2237398vcb.36 for ; Sun, 24 Nov 2013 15:48:48 -0800 (PST) X-Received: by 10.52.182.39 with SMTP id eb7mr18968505vdc.6.1385336928617; Sun, 24 Nov 2013 15:48:48 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.174.196 with SMTP id u4csp96071vcz; Sun, 24 Nov 2013 15:48:48 -0800 (PST) X-Received: by 10.180.211.71 with SMTP id na7mr11448723wic.5.1385336927559; Sun, 24 Nov 2013 15:48:47 -0800 (PST) Received: from mail-wg0-f41.google.com (mail-wg0-f41.google.com [74.125.82.41]) by mx.google.com with ESMTPS id gk3si6364693wic.52.2013.11.24.15.48.47 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 24 Nov 2013 15:48:47 -0800 (PST) Received-SPF: neutral (google.com: 74.125.82.41 is neither permitted nor denied by best guess record for domain of omair.javaid@linaro.org) client-ip=74.125.82.41; Received: by mail-wg0-f41.google.com with SMTP id y10so570437wgg.2 for ; Sun, 24 Nov 2013 15:48:47 -0800 (PST) X-Received: by 10.194.121.133 with SMTP id lk5mr33304wjb.77.1385336927138; Sun, 24 Nov 2013 15:48:47 -0800 (PST) Received: from [192.168.1.2] ([182.185.192.168]) by mx.google.com with ESMTPSA id nb16sm41835184wic.0.2013.11.24.15.48.44 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 24 Nov 2013 15:48:46 -0800 (PST) Message-ID: <52929058.1050202@linaro.org> Date: Mon, 25 Nov 2013 04:48:40 +0500 From: Omair Javaid User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.1 MIME-Version: 1.0 To: oza Pawandeep CC: Yao Qi , "gdb-patches@sourceware.org" , patches , Eli Zaretskii Subject: Re: [PATCH 0/2] GDB process record and reverse debugging improvements for arm*-linux* References: <52687B1A.2050003@codesourcery.com> <527C580B.5020100@linaro.org> <83k3gj5p9t.fsf@gnu.org> <52809426.40405@linaro.org> In-Reply-To: <52809426.40405@linaro.org> X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: omair.javaid@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.177 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , On Mon 11 Nov 2013 01:24:06 PM PKT, Omair Javaid wrote: > On Fri 08 Nov 2013 01:18:45 PM PKT, oza Pawandeep wrote: >> Hi, >> >> The previous support for arm instruction and thumb instruction for >> record and reply was added by me. >> but there some reverse test case failing... >> I had issues with employer disclaimer, so could not proceed. >> I have got the disclaimer now and is up-to date with FSF. >> >> some of the queries to you regarding thumb2 support ? >> >> 1) did you bring in co processor and dsp instruction support for thumb2 ? >> >> 2) can you please run gdb-rever test suite and see if your code passes >> the same ? >> >> >> Regards, >> Oza. >> >> >> On Fri, Nov 8, 2013 at 12:55 PM, Eli Zaretskii wrote: >>> >>>> Date: Fri, 08 Nov 2013 08:18:35 +0500 >>>> From: Omair Javaid >>>> CC: gdb-patches@sourceware.org, Patch Tracking >>>> >>>> --- gdb/NEWS 11 Oct 2013 13:51:26 -0000 1.622 >>>> +++ gdb/NEWS 7 Nov 2013 23:58:26 -0000 >>>> @@ -3,6 +3,10 @@ >>> >>> This part is OK, but please make sure to have 2 spaces between >>> sentences >>> >>>> +* Improved support of process record-replay and reverse debugging on >>>> + arm*-linux* targets. Support for thumb32 and syscall instructions >>> ^^ >>> here. >>> >>> Thanks. >> > > Hello Oza, > > I really appreciate your work on arm process record and I am trying to > improve on the work you have done previously. I have sent 3 patches > upstream which include basic support for Thumb32 instructions and > system call instructions along with some fixes. > > There were around 1500 failures in gdb.reverse on arm that have been > significantly reduced. Here is a current status of gdb.reverse test > suite on arm targets: > > arm-native configuration: > # of expected passes 2253 > # of unexpected failures 71 > > arm-remote configuration: > # of expected passes 2142 > # of unexpected failures 122 > > I am currently working on patches to fix above unexpected failures and > also working on supporting co-processor and other unsupported > instruction types. > > -- > Omair. After incorporating all suggestions I am posting a final version of all three patches posted earlier. Looking for a go ahead for commit. == PATCH 0 == This patch adds a news entry about improved process record-replay on arm*-linux* targets. It also adds linux-record.o to gdb_target_obs in configure.tgt and enables gdb.reverse testsuite for arm*-linux* targets. gdb: 2013-11-08 Omair Javaid * NEWS: Add note on improved process record-replay on arm*-linux* targets. * configure.tgt: Add linux-record.o to gdb_target_obs. gdb/testsuite: 2013-10-24 Omair Javaid * lib/gdb.exp: Enable gdb.reverse testsuite for arm*-linux* targets. --- gdb/NEWS | 4 ++++ gdb/configure.tgt | 2 +- gdb/testsuite/lib/gdb.exp | 6 ++++-- 3 files changed, 9 insertions(+), 3 deletions(-) -- diff --git a/gdb/NEWS b/gdb/NEWS index 10834df..bcf3e09 100644 --- a/gdb/NEWS +++ b/gdb/NEWS @@ -3,6 +3,10 @@ *** Changes since GDB 7.6 +* Improved support of process record-replay and reverse debugging on + arm*-linux* targets. Support for thumb32 and syscall instructions + recording has been added. + * GDB now supports Fission DWP file format version 2. http://gcc.gnu.org/wiki/DebugFission diff --git a/gdb/configure.tgt b/gdb/configure.tgt index ea0faf1..5410f72 100644 --- a/gdb/configure.tgt +++ b/gdb/configure.tgt @@ -89,7 +89,7 @@ arm*-wince-pe | arm*-*-mingw32ce*) arm*-*-linux*) # Target: ARM based machine running GNU/Linux gdb_target_obs="arm-tdep.o arm-linux-tdep.o glibc-tdep.o \ - solib-svr4.o symfile-mem.o linux-tdep.o" + solib-svr4.o symfile-mem.o linux-tdep.o linux-record.o" build_gdbserver=yes ;; arm*-*-netbsd* | arm*-*-knetbsd*-gnu) diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index bde4e48..047aefb 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -1774,7 +1774,8 @@ proc supports_process_record {} { return [target_info gdb,use_precord] } - if { [istarget "x86_64-*-linux*"] || [istarget "i\[34567\]86-*-linux*"] } { + if { [istarget "arm*-*-linux*"] || [istarget "x86_64-*-linux*"] + || [istarget "i\[34567\]86-*-linux*"] } { return 1 } @@ -1789,7 +1790,8 @@ proc supports_reverse {} { return [target_info gdb,can_reverse] } - if { [istarget "x86_64-*-linux*"] || [istarget "i\[34567\]86-*-linux*"] } { + if { [istarget "arm*-*-linux*"] || [istarget "x86_64-*-linux*"] + || [istarget "i\[34567\]86-*-linux*"] } { return 1 }