From patchwork Mon Jan 13 17:25:24 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Machado X-Patchwork-Id: 182806 Delivered-To: patch@linaro.org Received: by 2002:a92:1f12:0:0:0:0:0 with SMTP id i18csp4390403ile; Mon, 13 Jan 2020 09:25:53 -0800 (PST) X-Google-Smtp-Source: APXvYqwlqj+SEOVz6CXc167VfK1oCSb9LBhFrQMH/tcfWXDBSon8pUm4Qb6u8xxaFx0IHf2Dhg15 X-Received: by 2002:aca:1011:: with SMTP id 17mr13772019oiq.72.1578936353030; Mon, 13 Jan 2020 09:25:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578936353; cv=none; d=google.com; s=arc-20160816; b=o9s5hCdZV2Ouv0IQ588aDYrZjCjjKHu+LSUx1aBjbNgFif1MCLhEqHo3EyEujVvwOl 2Vq2/BCmffq0KSIamm54yIqzdDgj6heLwF1dLMk9ZHjeSnk+9kWQg9WT/lcnN40CDShY PGT0M4OypqH1stU9T1VsTgI5aOqZLddfBbwAH2KoSxT/V+EGYqrUKLix7DkmPsX3KP3+ 5/KDKCBPJnxzOIAEEwoAkQOqgmWNH7WggMLw6SVW1jKv67UE7zXFMqVerUD5xjX8riHN B0dXBLkNMw/pDP7tAsuEVL9dB16OoleizzteGyN+RGEZCTmDAjGOHKF1mrX0fkZCOLoP WPpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:delivered-to:sender:list-help:list-post:list-archive :list-subscribe:list-unsubscribe:list-id:precedence:mailing-list :dkim-signature:domainkey-signature; bh=WOPh4DRQhh8T7Yhxqxd1FwDs7xn3TNs1RgiDJMiBFls=; b=p1AVBAmeWm4Og9cf2POjKVZW5qgpr5PIzWtINaISsnvF9L6vatozyluwaN4ZANvRTS OYGvs4d5nPn95S/7UeoOxIiT3n9HzfTPY+Pn1O20H38oXHun1IgcsDDSl/aYHCgtGVBI PHZrhpg8yLT8V1FwTB+r1WngV87ulcNrBrX2XQHanYortwWgxJYg5AO+5VFiVJceM9dX uFd88MkcPj3nLanFZMlNRlsYWkw6bR/IporecG7EvObmTn1JgAoraYhEkSvC9tr0Dbx4 laz4q2Th5oBStJ8XW+5ZSLTOV6L9VZ9towzLR9J3w7h61ToZhdMAP1H0+iaqm/tL94Rv PQQA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=o0Nkv954; dkim=pass header.i=@linaro.org header.s=google header.b=BrOyLsik; spf=pass (google.com: domain of gdb-patches-return-163022-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) smtp.mailfrom="gdb-patches-return-163022-patch=linaro.org@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id e5si7035890oti.104.2020.01.13.09.25.52 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 Jan 2020 09:25:53 -0800 (PST) Received-SPF: pass (google.com: domain of gdb-patches-return-163022-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b=o0Nkv954; dkim=pass header.i=@linaro.org header.s=google header.b=BrOyLsik; spf=pass (google.com: domain of gdb-patches-return-163022-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) smtp.mailfrom="gdb-patches-return-163022-patch=linaro.org@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:date:message-id:in-reply-to :references; q=dns; s=default; b=uYvgYAPBRzso7u2mnD2jHsuIHfyL9c3 qPt2EHumfpZT7GlXnDhyCHXt6knZPxKKbEJRnClh4B1cbyiyFo4TDZfrSjWqqzpL xm6kXZDMPUXs6n9zZ5UqYVXriGV9CJ6xYDbNRaztPoVLPE3QJZ8Ipid1ZW+m+97T PwKKZh/FweyY= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:date:message-id:in-reply-to :references; s=default; bh=g4NngKnGkpzgpzddPVJlwQYiXdg=; b=o0Nkv 954DC6Y6giFCBx7NoGRAjmPgROSpPTyPrZPa5DD675jU+Ea7jeMvHSOhTudemIgT eFzcsHzsNEQkO49gsP/czixYbpmQXvYmC5JhK2EEaEmrI0WXv/ZFA5hSGKbCmd9s xV+j62N4K3Pg5HoUBrO7amgCGs17GOur3sePio= Received: (qmail 40723 invoked by alias); 13 Jan 2020 17:25:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 40642 invoked by uid 89); 13 Jan 2020 17:25:41 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.6 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mail-qt1-f173.google.com Received: from mail-qt1-f173.google.com (HELO mail-qt1-f173.google.com) (209.85.160.173) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 13 Jan 2020 17:25:39 +0000 Received: by mail-qt1-f173.google.com with SMTP id e12so9784577qto.2 for ; Mon, 13 Jan 2020 09:25:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=WOPh4DRQhh8T7Yhxqxd1FwDs7xn3TNs1RgiDJMiBFls=; b=BrOyLsikmLc4LrPL/VH7+ufl+W50OYH2aYOIp0KlyO8OgQuqhw+VNbbSlW/Q7ABMhU lmHdgELX2gC9FkgxdNV/JxeGkAZ1UykdIoWi937uq86qz3tgMaqBiDQyF+iM6SQbqCaK h6li74RlwtcWBSn6HQceheZbGZeK8IbdKrnAy3WvuWk/mkvscvYaTzeuO4e8Vnz0Z3vu mbGAhiiLd44GHhRbiktTIWQxt2iK6vWt3U29DEjPWT64aS5m71HhjHiGL8n44LlegPwq OPiJSqMdaoejN1tO/kTHfUCeygOH/XkxbrzBkbyTsik3qToeY5H/PXVRn2kwtKeA5jaM Fm+Q== Return-Path: Received: from localhost.localdomain ([179.183.9.215]) by smtp.gmail.com with ESMTPSA id n1sm5189622qkk.122.2020.01.13.09.25.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Jan 2020 09:25:36 -0800 (PST) From: Luis Machado To: gdb-patches@sourceware.org Cc: alan.hayward@arm.com, tankut.baris.aktemur@intel.com Subject: [PATCH 2/2][AArch64] Test handling of additional brk instruction patterns Date: Mon, 13 Jan 2020 14:25:24 -0300 Message-Id: <20200113172524.7201-3-luis.machado@linaro.org> In-Reply-To: <20200113172524.7201-1-luis.machado@linaro.org> References: <20200113172524.7201-1-luis.machado@linaro.org> X-IsSubscribed: yes This test exercises the previous patch's code and makes sure GDB can properly get a SIGTRAP from various brk instruction patterns. GDB needs to be able to see the program exiting normally. If GDB doesn't support the additional brk instructions, we will see timeouts. We bail out with the first timeout since we won't be able to step through the program breakpoint anyway, so it is no use carrying on. gdb/testsuite/ChangeLog: 2020-01-13 Luis Machado * gdb.arch/aarch64-brk-patterns.c: New source file. * gdb.arch/aarch64-brk-patterns.exp: New test. --- gdb/testsuite/gdb.arch/aarch64-brk-patterns.c | 30 +++++++++ .../gdb.arch/aarch64-brk-patterns.exp | 67 +++++++++++++++++++ 2 files changed, 97 insertions(+) create mode 100644 gdb/testsuite/gdb.arch/aarch64-brk-patterns.c create mode 100644 gdb/testsuite/gdb.arch/aarch64-brk-patterns.exp -- 2.17.1 diff --git a/gdb/testsuite/gdb.arch/aarch64-brk-patterns.c b/gdb/testsuite/gdb.arch/aarch64-brk-patterns.c new file mode 100644 index 0000000000..ccf9a35a94 --- /dev/null +++ b/gdb/testsuite/gdb.arch/aarch64-brk-patterns.c @@ -0,0 +1,30 @@ +/* This file is part of GDB, the GNU debugger. + + Copyright 2020 Free Software Foundation, Inc. + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 3 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program. If not, see . */ + +int main(void) +{ + /* Dummy instruction just so GDB doesn't stop at the first breakpoint + instruction. */ + __asm __volatile ("nop\n\t"); + + /* Multiple BRK instruction patterns. */ + __asm __volatile ("brk %0\n\t" ::"n"(0x0)); + __asm __volatile ("brk %0\n\t" ::"n"(0x900 + 0xf)); + __asm __volatile ("brk %0\n\t" ::"n"(0xf000)); + + return 0; +} diff --git a/gdb/testsuite/gdb.arch/aarch64-brk-patterns.exp b/gdb/testsuite/gdb.arch/aarch64-brk-patterns.exp new file mode 100644 index 0000000000..3532a0df95 --- /dev/null +++ b/gdb/testsuite/gdb.arch/aarch64-brk-patterns.exp @@ -0,0 +1,67 @@ +# Copyright 2020 Free Software Foundation, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . +# +# This file is part of the gdb testsuite. + +# Test if GDB stops at various BRK instruction patterns inserted into +# the code. + +if {![is_aarch64_target]} { + verbose "Skipping ${gdb_test_file_name}." + return +} + +standard_testfile +if { [prepare_for_testing "failed to prepare" ${testfile} ${srcfile}] } { + return -1 +} + +if ![runto_main] { + untested "could not run to main" + return -1 +} + +set keep_going 1 +set count 0 +set old_timeout $timeout +set timeout 10 + +while { $keep_going } { + + set test "brk instruction $count causes SIGTRAP" + + # Continue to next program breakpoint instruction. + gdb_test_multiple "continue" $test { + -re "Program received signal SIGTRAP, Trace/breakpoint trap.*$gdb_prompt $" { + pass $test + + # Insert a breakpoint at the program breakpoint instruction so GDB + # can step over it. + gdb_test "break" \ + "Breakpoint $decimal at $hex: file .*$srcfile, line $decimal.*" \ + "insert breakpoint at brk instruction $count" + } + -re "exited normally.*$gdb_prompt $" { + set keep_going 0 + } + timeout { + fail $test + set keep_going 0 + } + } + set count [expr "$count + 1"] +} + +set timeout $old_timeout