From patchwork Fri Aug 29 13:41:31 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Omair Javaid X-Patchwork-Id: 36287 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-pa0-f70.google.com (mail-pa0-f70.google.com [209.85.220.70]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id E371C2054D for ; Fri, 29 Aug 2014 13:42:06 +0000 (UTC) Received: by mail-pa0-f70.google.com with SMTP id lf10sf35535186pab.5 for ; Fri, 29 Aug 2014 06:42:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:mailing-list :precedence:list-id:list-unsubscribe:list-subscribe:list-archive :list-post:list-help:sender:delivered-to:from:to:subject:date :message-id:in-reply-to:references:x-original-sender :x-original-authentication-results; bh=v39aTz5MxSB53HNqgu2QDsYcRojh4zTk7KXbTLGcWlI=; b=G4Ul5uGLN+2hKRKKiKRLHHlYgSgDqSZp7KNV42BXjCJNzXWQST//qfGguGffTNSXC+ j1Rf0CVK7dzjdAAEsL6eCWw+UBVdTDU2tDKcQWOxOZt32wbtTiZ5xKKnCitpfM7fIx0e CaLp1INsvFjI1b1luEVHR9W73S4e1JPkpnc32hSZQdCm5WCAQ3+71s8TCudsnnBvtFjL 2NZMX5XPlXVVJvw0CYAWLcU2ckB2exfduYz7bUkJ4qHS36mkSbvGufd4z85ubtHjC+qw 1UOLUgjgUfFvroLwq39+pDvxhkL69pHURzjsPBMyB0OmA8yLnLmFZRzyJ5wU5HLZzCnJ SxvA== X-Gm-Message-State: ALoCoQnPG5uN0Io9oNPCVpgsTJoc29WHj4ehPxfrxUbpHQORMVmmRW9Fy4r73lEBSvcEEj4oW7cg X-Received: by 10.66.241.104 with SMTP id wh8mr5818463pac.33.1409319725014; Fri, 29 Aug 2014 06:42:05 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.102.202 with SMTP id w68ls1031431qge.4.gmail; Fri, 29 Aug 2014 06:42:04 -0700 (PDT) X-Received: by 10.52.165.116 with SMTP id yx20mr8642043vdb.13.1409319724855; Fri, 29 Aug 2014 06:42:04 -0700 (PDT) Received: from mail-vc0-x231.google.com (mail-vc0-x231.google.com [2607:f8b0:400c:c03::231]) by mx.google.com with ESMTPS id eq5si146227vdd.7.2014.08.29.06.42.04 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 29 Aug 2014 06:42:04 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 2607:f8b0:400c:c03::231 as permitted sender) client-ip=2607:f8b0:400c:c03::231; Received: by mail-vc0-f177.google.com with SMTP id hq11so2402822vcb.8 for ; Fri, 29 Aug 2014 06:42:04 -0700 (PDT) X-Received: by 10.220.97.138 with SMTP id l10mr10161992vcn.25.1409319724730; Fri, 29 Aug 2014 06:42:04 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.45.67 with SMTP id uj3csp18236vcb; Fri, 29 Aug 2014 06:42:04 -0700 (PDT) X-Received: by 10.66.138.46 with SMTP id qn14mr2342657pab.77.1409319723775; Fri, 29 Aug 2014 06:42:03 -0700 (PDT) Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id tp7si56241pbc.191.2014.08.29.06.42.03 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 29 Aug 2014 06:42:03 -0700 (PDT) Received-SPF: pass (google.com: domain of gdb-patches-return-115380-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Received: (qmail 15770 invoked by alias); 29 Aug 2014 13:41:57 -0000 Mailing-List: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org Precedence: list List-Id: List-Unsubscribe: , List-Subscribe: List-Archive: List-Post: , List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 15759 invoked by uid 89); 29 Aug 2014 13:41:56 -0000 X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-we0-f180.google.com Received: from mail-we0-f180.google.com (HELO mail-we0-f180.google.com) (74.125.82.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 29 Aug 2014 13:41:54 +0000 Received: by mail-we0-f180.google.com with SMTP id w61so2171524wes.25 for ; Fri, 29 Aug 2014 06:41:51 -0700 (PDT) X-Received: by 10.194.77.212 with SMTP id u20mr13609743wjw.27.1409319711392; Fri, 29 Aug 2014 06:41:51 -0700 (PDT) Received: from localhost.localdomain ([182.185.142.20]) by mx.google.com with ESMTPSA id gl10sm1638654wib.1.2014.08.29.06.41.49 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 29 Aug 2014 06:41:50 -0700 (PDT) From: Omair Javaid To: gdb-patches@sourceware.org Subject: Re: [PATCH 6/7] Support for recording aarch64 advanced SIMD instructions Date: Fri, 29 Aug 2014 18:41:31 +0500 Message-Id: <1409319691-25642-1-git-send-email-omair.javaid@linaro.org> In-Reply-To: References: X-IsSubscribed: yes X-Original-Sender: omair.javaid@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 2607:f8b0:400c:c03::231 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org; dkim=pass header.i=@sourceware.org X-Google-Group-Id: 836684582541 Updated patch after incorporating suggestions. gdb: 2014-08-28 Omair Javaid * aarch64-tdep.c (aarch64_record_data_proc_simd_fp): Add handler for data processing SIMD and floating point insns. (aarch64_record_asimd_load_store): Add handler to record ASIMD load store insns. (aarch64_record_load_store): Install record handler aarch64_record_asimd_load_store. (aarch64_record_decode_insn_handler): Install record handler aarch64_record_data_proc_simd_fp. --- gdb/aarch64-tdep.c | 228 ++++++++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 226 insertions(+), 2 deletions(-) diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c index c6da25a..9437280 100644 --- a/gdb/aarch64-tdep.c +++ b/gdb/aarch64-tdep.c @@ -2986,6 +2986,144 @@ aarch64_record_branch_except_sys (insn_decode_record *aarch64_insn_r) return AARCH64_RECORD_SUCCESS; } +/* Record handler for advanced SIMD load and store instructions. */ +static unsigned int +aarch64_record_asimd_load_store (insn_decode_record *aarch64_insn_r) +{ + CORE_ADDR address; + uint64_t addr_offset = 0; + uint32_t record_buf[24]; + uint64_t record_buf_mem[24]; + uint32_t reg_rn, reg_rt, reg_rm; + uint32_t reg_index = 0, mem_index = 0; + uint8_t eindex, rindex, sindex, reg_tt, replicate; + uint8_t elements, esize, rpt, selem, single, scale; + uint8_t opcode_bits, size_bits, ld_flag, data_size, wback; + + reg_rt = bits (aarch64_insn_r->aarch64_insn, 0, 4); + reg_rn = bits (aarch64_insn_r->aarch64_insn, 5, 9); + reg_rm = bits (aarch64_insn_r->aarch64_insn, 16, 20); + + wback = bit (aarch64_insn_r->aarch64_insn, 23); + single = bit (aarch64_insn_r->aarch64_insn, 24); + ld_flag = bit (aarch64_insn_r->aarch64_insn, 22); + size_bits = bits (aarch64_insn_r->aarch64_insn, 10, 11); + opcode_bits = bits (aarch64_insn_r->aarch64_insn, 12, 15); + regcache_raw_read_unsigned (aarch64_insn_r->regcache, reg_rn, &address); + + if (single) + { + scale = opcode_bits >> 2; + selem = ((opcode_bits & 0x02) | + bit (aarch64_insn_r->aarch64_insn, 21)) + 1; + replicate = 0; + switch (scale) + { + case 2: + if (!(size_bits & 0x01) && ((size_bits >> 1) & 0x01)) + scale = 3; + break; + case 3: + scale = size_bits; + replicate = 1; + break; + default: + break; + } + esize = 8 << scale; + if (replicate) + for (sindex = 0; sindex < selem; sindex++) + { + record_buf[reg_index++] = reg_rt + AARCH64_V0_REGNUM; + reg_rt = (reg_rt + 1) % 32; + } + else + { + for (sindex = 0; sindex < selem; sindex++) + if (ld_flag) + record_buf[reg_index++] = reg_rt + AARCH64_V0_REGNUM; + else + { + record_buf_mem[mem_index++] = esize / 8; + record_buf_mem[mem_index++] = address + addr_offset; + } + addr_offset = addr_offset + (esize / 8); + reg_rt = (reg_rt + 1) % 32; + } + } + else + { + esize = 8 << size_bits; + if (bit (aarch64_insn_r->aarch64_insn, 30)) + elements = 128 / esize; + else + elements = 64 / esize; + + switch (opcode_bits) + { + case 0: + rpt = 1; + selem = 4; + break; + case 2: + rpt = 4; + selem = 1; + break; + case 4: + rpt = 1; + selem = 3; + break; + case 6: + rpt = 3; + selem = 1; + break; + case 7: + rpt = 1; + selem = 1; + break; + case 8: + rpt = 1; + selem = 2; + break; + case 10: + rpt = 2; + selem = 1; + break; + default: + return AARCH64_RECORD_UNSUPPORTED; + break; + } + for (rindex = 0; rindex < rpt; rindex++) + for (eindex = 0; eindex < elements; eindex++) + { + reg_tt = (reg_rt + rindex) % 32; + for (sindex = 0; sindex < selem; sindex++) + { + if (ld_flag) + record_buf[reg_index++] = reg_tt + AARCH64_V0_REGNUM; + else + { + record_buf_mem[mem_index++] = esize / 8; + record_buf_mem[mem_index++] = address + addr_offset; + } + addr_offset = addr_offset + (esize / 8); + reg_tt = (reg_tt + 1) % 32; + } + } + } + + if (wback) + record_buf[reg_index++] = reg_rn; + + aarch64_insn_r->reg_rec_count = reg_index; + aarch64_insn_r->mem_rec_count = mem_index / 2; + MEM_ALLOC (aarch64_insn_r->aarch64_mems, aarch64_insn_r->mem_rec_count, + record_buf_mem); + REG_ALLOC (aarch64_insn_r->aarch64_regs, aarch64_insn_r->reg_rec_count, + record_buf); + return AARCH64_RECORD_SUCCESS; +} + /* Record handler for load and store instructions. */ static unsigned int aarch64_record_load_store (insn_decode_record *aarch64_insn_r) @@ -3224,7 +3362,7 @@ aarch64_record_load_store (insn_decode_record *aarch64_insn_r) } /* Advanced SIMD load/store instructions. */ else - return AARCH64_RECORD_UNSUPPORTED; + return aarch64_record_asimd_load_store (aarch64_insn_r); MEM_ALLOC (aarch64_insn_r->aarch64_mems, aarch64_insn_r->mem_rec_count, record_buf_mem); @@ -3232,6 +3370,92 @@ aarch64_record_load_store (insn_decode_record *aarch64_insn_r) record_buf); return AARCH64_RECORD_SUCCESS; } + +/* Record handler for data processing SIMD and floating point instructions. */ + +static unsigned int +aarch64_record_data_proc_simd_fp (insn_decode_record *aarch64_insn_r) +{ + uint8_t insn_bit21, opcode, rmode, reg_rd; + uint8_t insn_bits24_27, insn_bits28_31, insn_bits10_11, insn_bits12_15; + uint8_t insn_bits11_14; + uint32_t record_buf[2]; + + insn_bits24_27 = bits (aarch64_insn_r->aarch64_insn, 24, 27); + insn_bits28_31 = bits (aarch64_insn_r->aarch64_insn, 28, 31); + insn_bits10_11 = bits (aarch64_insn_r->aarch64_insn, 10, 11); + insn_bits12_15 = bits (aarch64_insn_r->aarch64_insn, 12, 15); + insn_bits11_14 = bits (aarch64_insn_r->aarch64_insn, 11, 14); + opcode = bits (aarch64_insn_r->aarch64_insn, 16, 18); + rmode = bits (aarch64_insn_r->aarch64_insn, 19, 20); + reg_rd = bits (aarch64_insn_r->aarch64_insn, 0, 4); + insn_bit21 = bit (aarch64_insn_r->aarch64_insn, 21); + + if ((insn_bits28_31 & 0x05) == 0x01 && insn_bits24_27 == 0x0e) + { + /* Floating point - fixed point conversion instructions. */ + if (!insn_bit21) + if ((opcode >> 1) == 0x0 && rmode == 0x03) + record_buf[0] = reg_rd; + else + record_buf[0] = reg_rd + AARCH64_V0_REGNUM; + /* Floating point - conditional compare instructions. */ + else if (insn_bits10_11 == 0x01) + record_buf[0] = AARCH64_CPSR_REGNUM; + /* Floating point - data processing (2-source) and + conditional select instructions. */ + else if (insn_bits10_11 == 0x02 || insn_bits10_11 == 0x03) + record_buf[0] = reg_rd + AARCH64_V0_REGNUM; + else if (insn_bits10_11 == 0x00) + { + /* Floating point - immediate instructions. */ + if ((insn_bits12_15 & 0x01) == 0x01 || (insn_bits12_15 & 0x07) == 0x04) + record_buf[0] = reg_rd + AARCH64_V0_REGNUM; + /* Floating point - compare instructions. */ + else if ((insn_bits12_15 & 0x03) == 0x02) + record_buf[0] = AARCH64_CPSR_REGNUM; + /* Floating point - integer conversions instructions. */ + if (insn_bits12_15 == 0x00) + { + /* Convert float to integer instruction. */ + if (!(opcode >> 1) || ((opcode >> 1) == 0x02 && !rmode)) + record_buf[0] = reg_rd + AARCH64_X0_REGNUM; + /* Convert integer to float instruction. */ + else if ((opcode >> 1) == 0x01 && !rmode) + record_buf[0] = reg_rd + AARCH64_V0_REGNUM; + /* Move float to integer instruction. */ + else if ((opcode >> 1) == 0x03) + { + if (!(opcode & 0x01)) + record_buf[0] = reg_rd + AARCH64_X0_REGNUM; + else + record_buf[0] = reg_rd + AARCH64_V0_REGNUM; + } + } + } + } + else if ((insn_bits28_31 & 0x09) == 0x00 && insn_bits24_27 == 0x0E) + { + /* Advanced SIMD copy instructions. */ + if (!bits (aarch64_insn_r->aarch64_insn, 21, 23) && + !bit (aarch64_insn_r->aarch64_insn, 15) && + bit (aarch64_insn_r->aarch64_insn, 10)) + if (insn_bits11_14 == 0x05 || insn_bits11_14 == 0x07) + record_buf[0] = reg_rd + AARCH64_X0_REGNUM; + else + record_buf[0] = reg_rd + AARCH64_V0_REGNUM; + else + record_buf[0] = reg_rd + AARCH64_V0_REGNUM; + } + /* All remaining floating point or advanced SIMD instructions. */ + else + record_buf[0] = reg_rd + AARCH64_V0_REGNUM; + + REG_ALLOC (aarch64_insn_r->aarch64_regs, aarch64_insn_r->reg_rec_count, + record_buf); + return AARCH64_RECORD_SUCCESS; +} + /* Decodes insns type and invokes its record handler. */ static unsigned int @@ -3262,7 +3486,7 @@ aarch64_record_decode_insn_handler (insn_decode_record *aarch64_insn_r) /* Data processing - SIMD and floating point instructions. */ if (ins_bit25 && ins_bit26 && ins_bit27) - return AARCH64_RECORD_UNSUPPORTED; + return aarch64_record_data_proc_simd_fp (aarch64_insn_r); return AARCH64_RECORD_UNSUPPORTED; }