From patchwork Thu Oct 20 07:55:17 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe Lyon X-Patchwork-Id: 78432 Delivered-To: patch@linaro.org Received: by 10.140.97.247 with SMTP id m110csp648990qge; Thu, 20 Oct 2016 00:55:55 -0700 (PDT) X-Received: by 10.99.237.69 with SMTP id m5mr15609545pgk.113.1476950155103; Thu, 20 Oct 2016 00:55:55 -0700 (PDT) Return-Path: Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id i65si42837489pfc.13.2016.10.20.00.55.54 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 20 Oct 2016 00:55:55 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-return-439080-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org; spf=pass (google.com: domain of gcc-patches-return-439080-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) smtp.mailfrom=gcc-patches-return-439080-patch=linaro.org@gcc.gnu.org; dmarc=fail (p=NONE dis=NONE) header.from=linaro.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:from:date:message-id:subject:to:content-type; q= dns; s=default; b=EZc1o4fxrPQO2yVLaaWqFiqw6BAXGzvDfMJ+bADMB8Upqk giR7WYkxM6yTpTpqdMwBIbxNMCv9J25ieFTMTyeNlqIkbnq/kaHs9s5zWxN2Mzwo 4ogB7ipLhqbl856HQksW8guFgQx8D3Lez6r+gOvJdsXVQWPJaqe2sA8sXd51A= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:from:date:message-id:subject:to:content-type; s= default; bh=AFJ07ZmSdiVcryKCa0ng4yhO8AY=; b=IViN+NOBcF6EwKg8/cOS YoIndVP74rOrf+dKFQ0u0tcZjZqLlRUs6gUiIF7t3CTJtk+dzPEyc65nukVf1bKn QWD9ZbCeDW3+tnGmBNUyfOaZ1PfnEStkgURe9QK1b+/0AwfKYHz856QhAN4iiKsj N+QecDye3qGZG6Te/DQPq9I= Received: (qmail 15643 invoked by alias); 20 Oct 2016 07:55:31 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 15523 invoked by uid 89); 20 Oct 2016 07:55:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 spammy=18_support, Hx-languages-length:1704, HX-Received:Thu X-HELO: mail-qt0-f174.google.com Received: from mail-qt0-f174.google.com (HELO mail-qt0-f174.google.com) (209.85.216.174) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 20 Oct 2016 07:55:20 +0000 Received: by mail-qt0-f174.google.com with SMTP id q7so43554793qtq.1 for ; Thu, 20 Oct 2016 00:55:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=2cGOpRtg2nzMaIBk4gFtyVUAevuEx5lLQzUaaj73nlI=; b=ACkIATSzlUEhiuGcqW7JMeGdffFjK2FWKV9L4gPIUt/KMjgGR7wItfkP+plMBSashW SR2rYa4cQdzrQV/24Vyt5svPGawP3qezXHka2wBYjTG8sA2dkyYuafQm3CpYqF4IprD9 StkgWoU0P2/WFIGdakdyH01M3n37gqdvCYgbjy5VjpYpClfmue77Iqro7/hS0wngWvRb NuGsQg2weRJifBH5WlxVJRXBrv34CnMqkHXEA1jr5lIVdfkByO5cJJ802AXAGPLzDFK/ 50Blu/VyBvfeyDyUfPonwR8RJRJ8elWJGgq6Mni2d4TmFdqMBSl+CRUaMj6WyT/Y56Oy OWKw== X-Gm-Message-State: AA6/9RlYwM/faXIRr34BYJ+G9iJyQgfMKA7gCnCQ1JpLjx4NzSypdGwHA7/bi8NNzE7KnORQj4u+0dCKg/q7kert X-Received: by 10.200.47.198 with SMTP id m6mr10644777qta.5.1476950118590; Thu, 20 Oct 2016 00:55:18 -0700 (PDT) MIME-Version: 1.0 Received: by 10.140.43.116 with HTTP; Thu, 20 Oct 2016 00:55:17 -0700 (PDT) From: Christophe Lyon Date: Thu, 20 Oct 2016 09:55:17 +0200 Message-ID: Subject: [libstdc++, testsuite] Add dg-require-thread-fence To: Jonathan Wakely , "gcc-patches@gcc.gnu.org" X-IsSubscribed: yes Hi, Several times I have noticed/reported test failures because some test cases wouldn't link on arm-none-eabi using the default 'old' cpu target: __sync_synchronize cannot be resolved by the linker. The attached long patch adds +// { dg-require-thread-fence "" } to all the tests that require it according to the error messages I get. The change is mechanical: - insert this line below dg-do if present - insert this line at the top of the file otherwise For instance: If that's OK, I'm not sure how to write the ChangeLog entry: it modifies 3287 files. In my testing, it replaces 3287 FAILs by 3287 UNSUPPORTED. OK? Other question: I've noticed similar errors in the g++ validation, but I'm not sure what is the corresponding dg-require directive? Thanks, Christophe diff --git a/libstdc++-v3/testsuite/18_support/bad_typeid/what.cc b/libstdc++-v3/testsuite/18_support/bad_typeid/what.cc index 633175b..a048250 100644 --- a/libstdc++-v3/testsuite/18_support/bad_typeid/what.cc +++ b/libstdc++-v3/testsuite/18_support/bad_typeid/what.cc @@ -1,3 +1,4 @@ +// { dg-require-thread-fence "" } // 2007-01-30 Paolo Carlini // Copyright (C) 2007-2016 Free Software Foundation, Inc. diff --git a/libstdc++-v3/testsuite/18_support/cxa_vec.cc b/libstdc++-v3/testsuite/18_support/cxa_vec.cc index e712655..f2a6c5a 100644 --- a/libstdc++-v3/testsuite/18_support/cxa_vec.cc +++ b/libstdc++-v3/testsuite/18_support/cxa_vec.cc @@ -1,4 +1,5 @@ // { dg-do run } +// { dg-require-thread-fence "" } // Avoid use of non-overridable new/delete operators in shared // { dg-options "-static" { target *-*-mingw* } } // Test __cxa_vec routines