From patchwork Tue Mar 22 09:24:58 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe Lyon X-Patchwork-Id: 64152 Delivered-To: patch@linaro.org Received: by 10.112.199.169 with SMTP id jl9csp1938624lbc; Tue, 22 Mar 2016 02:25:16 -0700 (PDT) X-Received: by 10.98.70.27 with SMTP id t27mr51597826pfa.107.1458638716147; Tue, 22 Mar 2016 02:25:16 -0700 (PDT) Return-Path: Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id o4si4722191pap.178.2016.03.22.02.25.15 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 Mar 2016 02:25:16 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-return-423660-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Authentication-Results: mx.google.com; spf=pass (google.com: domain of gcc-patches-return-423660-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) smtp.mailfrom=gcc-patches-return-423660-patch=linaro.org@gcc.gnu.org; dkim=pass header.i=@gcc.gnu.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; q=dns; s=default; b=wogMKG6w1YpgQ7In9+ 2OvGKgoSdmQO8Ugqp1VhejPH85IrxSKyO2OCd5Z1awfOMva2ozAWkbsfOY1kNZAa TFXIKyvBgpIcUNsmXqLMBUsYfM08L79ju7FZ4lpYaIOWRRb1iEtCPpzZr+viXx3v EpAS3Bwj0AEVLGPwAHE1LWcN0= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; s=default; bh=9JpdrX2xo3NJ31uOo/nDg5z2 +eY=; b=J+uXZtiwDqDfoWA9npq+WIS2/0aJDeYS74p1W2YeaIcyF/LVZ0a9PJgC fztnK2kp2LbaCFOv1liz+ljAzZcLr4D/iX87KZRQXsPR7BDIpxrXITTtHAT6iQEl dwcn5tvzpUB2pRreXavkX3p78YCOW2Qot6r4kXv19mRDEQVpEu8= Received: (qmail 68110 invoked by alias); 22 Mar 2016 09:25:03 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 68086 invoked by uid 89); 22 Mar 2016 09:25:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 spammy=Christophe, christophe, safest, HX-Envelope-From:sk:christo X-HELO: mail-qk0-f173.google.com Received: from mail-qk0-f173.google.com (HELO mail-qk0-f173.google.com) (209.85.220.173) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 22 Mar 2016 09:25:00 +0000 Received: by mail-qk0-f173.google.com with SMTP id p130so35801300qke.1 for ; Tue, 22 Mar 2016 02:25:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=HnTZ6+qa3NzHom/uLOPZvqfxMaGJMl0ItKd6N2PochU=; b=ehtqJh6skkPIa3cwq5aYKqXhOEoKtrDkBLoJ1Plpjdpf3gf5RQasaMR+oCpYwWfjl7 KdmlxO6LpPb1pJJDQxja3Nz+rlfQrP2mTmCv9Qq0c7mAHyY4roYrHyOCb8qXNMCjMOfA dMCUUEyjf8k5BT2RE3n3b6huwieBHxC/S38EcqWNSPVkLbCWpncD+P7mnvI18gemq/Ah y5+GdyQ1uRLOPjbSuAz+1H59ENMqmGLNJy4T/lJS/gXprCkTC8CGY5bi2NHu4wWEPXLy mIgaTrmtvSGplPKZcUFRKZooGkO7ErmqlFIYbQp1AgwpmdC8Xf1IS5WnqChu+kMGnBFt gCsA== X-Gm-Message-State: AD7BkJK7+4Xjx9DI5ii5y1UWF5GssNRgsDdrpabvnr39hVy4sYwckimeshoCDPDl5u3f9gXSVWDJqSwC/kbSInDa MIME-Version: 1.0 X-Received: by 10.55.215.83 with SMTP id m80mr45195927qki.84.1458638698890; Tue, 22 Mar 2016 02:24:58 -0700 (PDT) Received: by 10.140.22.164 with HTTP; Tue, 22 Mar 2016 02:24:58 -0700 (PDT) In-Reply-To: <56EC322E.5080900@redhat.com> References: <56EBF12B.40701@t-online.de> <56EBF3B9.5050005@redhat.com> <56EC322E.5080900@redhat.com> Date: Tue, 22 Mar 2016 10:24:58 +0100 Message-ID: Subject: Re: Fix 70278 (LRA split_regs followup patch) From: Christophe Lyon To: Jeff Law Cc: Bernd Schmidt , GCC Patches , Vladimir Makarov X-IsSubscribed: yes On 18 March 2016 at 17:51, Jeff Law wrote: > On 03/18/2016 06:25 AM, Bernd Schmidt wrote: >> >> This fixes an oversight in my previous patch here. I used biggest_mode >> in the assumption that if the reg was used in the function, it would be >> set to something other than VOIDmode, but that fails if we have a >> multiword access - only the first hard reg gets its biggest_mode >> assigned in that case. >> >> Bootstrapped and tested on x86_64-linux, ran (just) the new arm testcase >> manually with arm-eabi. Ok? >> >> (The testcase seems to be from glibc. Do we keep the copyright notices >> on the reduced form)? > > I don't recall specific guidance on including the copyright notice on a > reduced/derived test. > > Given the actual copyright on the original code, ISTM the safest thing to do > is keep the notice intact. > > A long long time ago I receive guidance from the FSF WRT what could be > included in the testsuite -- unfortunately I didn't keep that message. I > probably should have. > >> >> Bernd >> >> 70278.diff >> >> >> PR rtl-optimization/70278 >> * lra-constraints.c (split_reg): Handle the case where >> biggest_mode is >> VOIDmode. >> >> testsuite/ >> * gcc.dg/torture/pr70278.c: New test. >> * gcc.target/arm/pr70278.c: New test. > The ARM test isn't sufficiently protected against non-compliant configurations, and fails if GCC is configured for arm*linux-gnueabihf for instance (see http://people.linaro.org/~christophe.lyon/cross-validation/gcc/trunk/234342/report-build-info.html) The attached small patch fixes that by requiring arm_arch_v4t_multilib effective target. I used arm_arch_v4t_multilib instead of arm_arch_v4t because, as I reported a long time ago the later does not complain in some unsupported configuration because the sample effective target test does not contain actual code. In particular it's not sufficient to reject thumb-1 with hard-float. OK? Thanks, Christophe. > OK. > jeff > 2016-03-22 Christophe Lyon * gcc.target/arm/pr70278.c: Require arm_arch_v4t_multilib effective target. diff --git a/gcc/testsuite/gcc.target/arm/pr70278.c b/gcc/testsuite/gcc.target/arm/pr70278.c index c44c07b..889f626 100644 --- a/gcc/testsuite/gcc.target/arm/pr70278.c +++ b/gcc/testsuite/gcc.target/arm/pr70278.c @@ -2,6 +2,7 @@ /* { dg-skip-if "avoid conflicting multilib options" { *-*-* } { "-march=*" } { "-march=armv4t" } } */ /* { dg-skip-if "avoid conflicting multilib options" { *-*-* } { "-marm" } { "" } } */ /* { dg-options "-mthumb" } */ +/* { dg-require-effective-target arm_arch_v4t_multilib } */ /* { dg-add-options arm_arch_v4t } */ /* * ====================================================