From patchwork Tue Jan 20 15:35:39 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe Lyon X-Patchwork-Id: 43384 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-la0-f70.google.com (mail-la0-f70.google.com [209.85.215.70]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id D2615218DB for ; Tue, 20 Jan 2015 15:36:07 +0000 (UTC) Received: by mail-la0-f70.google.com with SMTP id hs14sf20693797lab.1 for ; Tue, 20 Jan 2015 07:36:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:mailing-list:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:sender :delivered-to:mime-version:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:x-original-sender :x-original-authentication-results; bh=jVLI0kFKqXFbFMTkZKKlaxbIfQMv/R9ux+z8ecqbLiY=; b=WhVU5Tfk6wX0B5IwgjsKnDZFKimeZKkXvche04BN5zk5or1H08jjUSpfRWRmuUUArC EL3n4ErOTbtLretg4hF7uEFT4lwulkzN60sAp3bcxpIAgq4e1GcrbL0JYQekGozKSmIU 9p63anVIuZHTSQ0vzJZf7P4IMwfui43bZBTF99g6PfL68NcaKuFmkdV0TrI+p8y8Iz5V 2ogs/4i4EVyqqILnL5IyPeiwTHXbtXizO4UUiELOO5yICvfcvnD3lxUvdhP4dWeNP9/T 2/vVYlksY7UB8m/Uwsy65Gul69c6Bsc9fzPYM9fb+KD+M2BvxjipTp68DjHnGaLBdXyb 7xWQ== X-Gm-Message-State: ALoCoQk3z9MvZFlraxmWmUCMNyipj9Abbcz7u5XFLynMFpRytcIXNqB1zFKTa6x3QbjtRHzwPHQZ X-Received: by 10.180.13.83 with SMTP id f19mr1220724wic.7.1421768166803; Tue, 20 Jan 2015 07:36:06 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.245.43 with SMTP id xl11ls313297lac.54.gmail; Tue, 20 Jan 2015 07:36:06 -0800 (PST) X-Received: by 10.112.54.167 with SMTP id k7mr13716886lbp.72.1421768166422; Tue, 20 Jan 2015 07:36:06 -0800 (PST) Received: from mail-la0-x22b.google.com (mail-la0-x22b.google.com. [2a00:1450:4010:c03::22b]) by mx.google.com with ESMTPS id o5si15546347lbs.43.2015.01.20.07.36.06 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 20 Jan 2015 07:36:06 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 2a00:1450:4010:c03::22b as permitted sender) client-ip=2a00:1450:4010:c03::22b; Received: by mail-la0-f43.google.com with SMTP id q1so19710415lam.2 for ; Tue, 20 Jan 2015 07:36:06 -0800 (PST) X-Received: by 10.152.6.132 with SMTP id b4mr39586602laa.59.1421768166320; Tue, 20 Jan 2015 07:36:06 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.9.200 with SMTP id c8csp1457417lbb; Tue, 20 Jan 2015 07:36:05 -0800 (PST) X-Received: by 10.68.223.196 with SMTP id qw4mr55148518pbc.26.1421768164006; Tue, 20 Jan 2015 07:36:04 -0800 (PST) Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id g6si5381242pat.30.2015.01.20.07.36.03 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Jan 2015 07:36:03 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-return-390017-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Received: (qmail 31110 invoked by alias); 20 Jan 2015 15:35:47 -0000 Mailing-List: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 31013 invoked by uid 89); 20 Jan 2015 15:35:44 -0000 X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-qc0-f170.google.com Received: from mail-qc0-f170.google.com (HELO mail-qc0-f170.google.com) (209.85.216.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 20 Jan 2015 15:35:42 +0000 Received: by mail-qc0-f170.google.com with SMTP id p6so6222683qcv.1 for ; Tue, 20 Jan 2015 07:35:40 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.224.131.4 with SMTP id v4mr32678152qas.99.1421768139852; Tue, 20 Jan 2015 07:35:39 -0800 (PST) Received: by 10.140.84.176 with HTTP; Tue, 20 Jan 2015 07:35:39 -0800 (PST) In-Reply-To: References: <1421162314-25779-1-git-send-email-christophe.lyon@linaro.org> <1421162314-25779-31-git-send-email-christophe.lyon@linaro.org> <54B9597D.9060409@arm.com> Date: Tue, 20 Jan 2015 16:35:39 +0100 Message-ID: Subject: Re: [[ARM/AArch64][testsuite] 30/36] Add vpaddl tests. From: Christophe Lyon To: Tejas Belagod Cc: "gcc-patches@gcc.gnu.org" X-IsSubscribed: yes X-Original-Sender: christophe.lyon@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 2a00:1450:4010:c03::22b as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org; dkim=pass header.i=@gcc.gnu.org X-Google-Group-Id: 836684582541 On 16 January 2015 at 20:41, Christophe Lyon wrote: > On 16 January 2015 at 19:49, Christophe Lyon wrote: >> On 16 January 2015 at 19:33, Tejas Belagod wrote: >>> >>>> +VECT_VAR_DECL(expected,poly,8,16) [] = { 0x33, 0x33, 0x33, 0x33, >>>> + 0x33, 0x33, 0x33, 0x33, >>>> + 0x33, 0x33, 0x33, 0x33, >>>> + 0x33, 0x33, 0x33, 0x33 }; >>>> +VECT_VAR_DECL(expected,poly,16,8) [] = { 0x3333, 0x3333, 0x3333, 0x3333, >>>> + 0x3333, 0x3333, 0x3333, 0x3333 }; >>>> +VECT_VAR_DECL(expected,hfloat,32,4) [] = { 0x33333333, 0x33333333, >>>> + 0x33333333, 0x33333333 }; >>>> + >>> >>> >>> No poly or float ops. >>> >>>> +#define INSN_NAME vpaddl >>>> +#define TEST_MSG "VPADDL/VPADDLQ" >>>> + >>>> +#define FNNAME1(NAME) void exec_ ## NAME (void) >>>> +#define FNNAME(NAME) FNNAME1(NAME) >>>> + >>>> +FNNAME (INSN_NAME) >>>> +{ >>>> + /* Basic test: y=OP(x), then store the result. */ >>>> +#define TEST_VPADDL1(INSN, Q, T1, T2, W, N, W2, N2) \ >>>> + VECT_VAR(vector_res, T1, W2, N2) = \ >>>> + INSN##Q##_##T2##W(VECT_VAR(vector, T1, W, N)); \ >>>> + vst1##Q##_##T2##W2(VECT_VAR(result, T1, W2, N2), \ >>>> + VECT_VAR(vector_res, T1, W2, N2)) >>>> + >>>> +#define TEST_VPADDL(INSN, Q, T1, T2, W, N, W2, N2) \ >>>> + TEST_VPADDL1(INSN, Q, T1, T2, W, N, W2, N2) >>>> + >>>> + /* No need for 64 bits variants. */ >>> >>> >>> These look like 64-bit variants. >>> >> I mean no vector element of 64 bits. >> >>>> + DECL_VARIABLE(vector, int, 8, 8); >>>> + DECL_VARIABLE(vector, int, 16, 4); >>>> + DECL_VARIABLE(vector, int, 32, 2); >>>> + DECL_VARIABLE(vector, uint, 8, 8); >>>> + DECL_VARIABLE(vector, uint, 16, 4); >>>> + DECL_VARIABLE(vector, uint, 32, 2); >>>> + DECL_VARIABLE(vector, int, 8, 16); >>>> + DECL_VARIABLE(vector, int, 16, 8); >>>> + DECL_VARIABLE(vector, int, 32, 4); >>>> + DECL_VARIABLE(vector, uint, 8, 16); >>>> + DECL_VARIABLE(vector, uint, 16, 8); >>>> + DECL_VARIABLE(vector, uint, 32, 4); >>>> + >>> >>> >>>> + /* Apply a unary operator named INSN_NAME. */ >>> >>> Unary op? >> >> Cut & paste error, again. >> > Hmm changed my mind: vpaddl takes only one vector as input, although > it does add 2 vector elements. > Here is an updated version, removing poly, float and int8 variants. > >>> >>>> + TEST_VPADDL(INSN_NAME, , int, s, 8, 8, 16, 4); >>>> + TEST_VPADDL(INSN_NAME, , int, s, 16, 4, 32, 2); >>>> + TEST_VPADDL(INSN_NAME, , int, s, 32, 2, 64, 1); >>>> + TEST_VPADDL(INSN_NAME, , uint, u, 8, 8, 16, 4); >>>> + TEST_VPADDL(INSN_NAME, , uint, u, 16, 4, 32, 2); >>>> + TEST_VPADDL(INSN_NAME, , uint, u, 32, 2, 64, 1); >>>> + TEST_VPADDL(INSN_NAME, q, int, s, 8, 16, 16, 8); >>>> + TEST_VPADDL(INSN_NAME, q, int, s, 16, 8, 32, 4); >>>> + TEST_VPADDL(INSN_NAME, q, int, s, 32, 4, 64, 2); >>>> + TEST_VPADDL(INSN_NAME, q, uint, u, 8, 16, 16, 8); >>>> + TEST_VPADDL(INSN_NAME, q, uint, u, 16, 8, 32, 4); >>>> + TEST_VPADDL(INSN_NAME, q, uint, u, 32, 4, 64, 2); >>>> + >>>> + CHECK_RESULTS (TEST_MSG, ""); >>>> +} >>>> + >>>> +int main (void) >>>> +{ >>>> + exec_vpaddl (); >>>> + return 0; >>>> +} >>>> >>> >>> >>> Otherwise, LGTM. >>> >>> Tejas. >>> >From 394f2023994b56413e3fc40412e9cc36ed0e05a7 Mon Sep 17 00:00:00 2001 From: Christophe Lyon Date: Wed, 10 Dec 2014 23:31:29 +0100 Subject: [[ARM/AArch64][testsuite] 30/36] Add vpaddl tests. diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vpaddl.c b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vpaddl.c new file mode 100644 index 0000000..8dc768d --- /dev/null +++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vpaddl.c @@ -0,0 +1,116 @@ +#include +#include "arm-neon-ref.h" +#include "compute-ref-data.h" + +/* Expected results. */ +VECT_VAR_DECL(expected,int,16,4) [] = { 0xffe1, 0xffe5, 0xffe9, 0xffed }; +VECT_VAR_DECL(expected,int,32,2) [] = { 0xffffffe1, 0xffffffe5 }; +VECT_VAR_DECL(expected,int,64,1) [] = { 0xffffffffffffffe1 }; +VECT_VAR_DECL(expected,uint,16,4) [] = { 0x1e1, 0x1e5, 0x1e9, 0x1ed }; +VECT_VAR_DECL(expected,uint,32,2) [] = { 0x1ffe1, 0x1ffe5 }; +VECT_VAR_DECL(expected,uint,64,1) [] = { 0x1ffffffe1 }; +VECT_VAR_DECL(expected,int,16,8) [] = { 0xffe1, 0xffe5, 0xffe9, 0xffed, + 0xfff1, 0xfff5, 0xfff9, 0xfffd }; +VECT_VAR_DECL(expected,int,32,4) [] = { 0xffffffe1, 0xffffffe5, + 0xffffffe9, 0xffffffed }; +VECT_VAR_DECL(expected,int,64,2) [] = { 0xffffffffffffffe1, + 0xffffffffffffffe5 }; +VECT_VAR_DECL(expected,uint,16,8) [] = { 0x1e1, 0x1e5, 0x1e9, 0x1ed, + 0x1f1, 0x1f5, 0x1f9, 0x1fd }; +VECT_VAR_DECL(expected,uint,32,4) [] = { 0x1ffe1, 0x1ffe5, 0x1ffe9, 0x1ffed }; +VECT_VAR_DECL(expected,uint,64,2) [] = { 0x1ffffffe1, 0x1ffffffe5 }; + +#define INSN_NAME vpaddl +#define TEST_MSG "VPADDL/VPADDLQ" + +#define FNNAME1(NAME) void exec_ ## NAME (void) +#define FNNAME(NAME) FNNAME1(NAME) + +FNNAME (INSN_NAME) +{ + /* Basic test: y=OP(x), then store the result. */ +#define TEST_VPADDL1(INSN, Q, T1, T2, W, N, W2, N2) \ + VECT_VAR(vector_res, T1, W2, N2) = \ + INSN##Q##_##T2##W(VECT_VAR(vector, T1, W, N)); \ + vst1##Q##_##T2##W2(VECT_VAR(result, T1, W2, N2), \ + VECT_VAR(vector_res, T1, W2, N2)) + +#define TEST_VPADDL(INSN, Q, T1, T2, W, N, W2, N2) \ + TEST_VPADDL1(INSN, Q, T1, T2, W, N, W2, N2) + + /* No need for 64 bits elements variants. */ + DECL_VARIABLE(vector, int, 8, 8); + DECL_VARIABLE(vector, int, 16, 4); + DECL_VARIABLE(vector, int, 32, 2); + DECL_VARIABLE(vector, uint, 8, 8); + DECL_VARIABLE(vector, uint, 16, 4); + DECL_VARIABLE(vector, uint, 32, 2); + DECL_VARIABLE(vector, int, 8, 16); + DECL_VARIABLE(vector, int, 16, 8); + DECL_VARIABLE(vector, int, 32, 4); + DECL_VARIABLE(vector, uint, 8, 16); + DECL_VARIABLE(vector, uint, 16, 8); + DECL_VARIABLE(vector, uint, 32, 4); + + DECL_VARIABLE(vector_res, int, 16, 4); + DECL_VARIABLE(vector_res, int, 32, 2); + DECL_VARIABLE(vector_res, int, 64, 1); + DECL_VARIABLE(vector_res, uint, 16, 4); + DECL_VARIABLE(vector_res, uint, 32, 2); + DECL_VARIABLE(vector_res, uint, 64, 1); + DECL_VARIABLE(vector_res, int, 16, 8); + DECL_VARIABLE(vector_res, int, 32, 4); + DECL_VARIABLE(vector_res, int, 64, 2); + DECL_VARIABLE(vector_res, uint, 16, 8); + DECL_VARIABLE(vector_res, uint, 32, 4); + DECL_VARIABLE(vector_res, uint, 64, 2); + + clean_results (); + + /* Initialize input "vector" from "buffer". */ + VLOAD(vector, buffer, , int, s, 8, 8); + VLOAD(vector, buffer, , int, s, 16, 4); + VLOAD(vector, buffer, , int, s, 32, 2); + VLOAD(vector, buffer, , uint, u, 8, 8); + VLOAD(vector, buffer, , uint, u, 16, 4); + VLOAD(vector, buffer, , uint, u, 32, 2); + VLOAD(vector, buffer, q, int, s, 8, 16); + VLOAD(vector, buffer, q, int, s, 16, 8); + VLOAD(vector, buffer, q, int, s, 32, 4); + VLOAD(vector, buffer, q, uint, u, 8, 16); + VLOAD(vector, buffer, q, uint, u, 16, 8); + VLOAD(vector, buffer, q, uint, u, 32, 4); + + /* Apply a unary operator named INSN_NAME. */ + TEST_VPADDL(INSN_NAME, , int, s, 8, 8, 16, 4); + TEST_VPADDL(INSN_NAME, , int, s, 16, 4, 32, 2); + TEST_VPADDL(INSN_NAME, , int, s, 32, 2, 64, 1); + TEST_VPADDL(INSN_NAME, , uint, u, 8, 8, 16, 4); + TEST_VPADDL(INSN_NAME, , uint, u, 16, 4, 32, 2); + TEST_VPADDL(INSN_NAME, , uint, u, 32, 2, 64, 1); + TEST_VPADDL(INSN_NAME, q, int, s, 8, 16, 16, 8); + TEST_VPADDL(INSN_NAME, q, int, s, 16, 8, 32, 4); + TEST_VPADDL(INSN_NAME, q, int, s, 32, 4, 64, 2); + TEST_VPADDL(INSN_NAME, q, uint, u, 8, 16, 16, 8); + TEST_VPADDL(INSN_NAME, q, uint, u, 16, 8, 32, 4); + TEST_VPADDL(INSN_NAME, q, uint, u, 32, 4, 64, 2); + + CHECK(TEST_MSG, int, 16, 4, PRIx16, expected, ""); + CHECK(TEST_MSG, int, 32, 2, PRIx32, expected, ""); + CHECK(TEST_MSG, int, 64, 1, PRIx64, expected, ""); + CHECK(TEST_MSG, uint, 16, 4, PRIx16, expected, ""); + CHECK(TEST_MSG, uint, 32, 2, PRIx32, expected, ""); + CHECK(TEST_MSG, uint, 64, 1, PRIx64, expected, ""); + CHECK(TEST_MSG, int, 16, 8, PRIx16, expected, ""); + CHECK(TEST_MSG, int, 32, 4, PRIx32, expected, ""); + CHECK(TEST_MSG, int, 64, 2, PRIx64, expected, ""); + CHECK(TEST_MSG, uint, 16, 8, PRIx16, expected, ""); + CHECK(TEST_MSG, uint, 32, 4, PRIx32, expected, ""); + CHECK(TEST_MSG, uint, 64, 2, PRIx64, expected, ""); +} + +int main (void) +{ + exec_vpaddl (); + return 0; +} -- 2.1.0