From patchwork Tue Aug 23 12:50:01 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe Lyon X-Patchwork-Id: 74500 Delivered-To: patch@linaro.org Received: by 10.140.29.52 with SMTP id a49csp2080897qga; Tue, 23 Aug 2016 05:50:27 -0700 (PDT) X-Received: by 10.98.31.219 with SMTP id l88mr52972223pfj.155.1471956627245; Tue, 23 Aug 2016 05:50:27 -0700 (PDT) Return-Path: Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id a6si3879419pfb.49.2016.08.23.05.50.26 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 23 Aug 2016 05:50:27 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-return-434503-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org; spf=pass (google.com: domain of gcc-patches-return-434503-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) smtp.mailfrom=gcc-patches-return-434503-patch=linaro.org@gcc.gnu.org; dmarc=fail (p=NONE dis=NONE) header.from=linaro.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:from:date:message-id:subject:to:content-type; q= dns; s=default; b=kR3CBCW+/4hqwOfLpZhxcDfy/4jpXg2CSpCQSz/7ekbh/t WFvw5aKwOkv0lWXvTpImexx/hD/E8bmIp6dKl65ndLT6kdkhxDpfCGMmPQcsdnBf qMkwEmAu9goLJMwXJUn2pucg+SoMnS3VpE177hOJ+B5rcxE7BXIbyudA24zmA= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :mime-version:from:date:message-id:subject:to:content-type; s= default; bh=Lur5z/kEUFMW8Wsbg1s+R3xCMmw=; b=bpAQIi5KPo0f7gaJ6dif hhnb7M9GX6ucgOKwR7hcwHf8/9gDZW77ZhJQTeayE0i5wVujHLiSzAwpIaIji4AR RkbuRpRynFdTON4mvOiQCOeZ4OkrHdpc/BCLUEDUW4wmKR2xDsTpy6XgmrPUBWY/ G496KNvJ/pz2cuBZuWkDL9I= Received: (qmail 57906 invoked by alias); 23 Aug 2016 12:50:15 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 57158 invoked by uid 89); 23 Aug 2016 12:50:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1321, 2016-08-23, 20160823 X-HELO: mail-qk0-f180.google.com Received: from mail-qk0-f180.google.com (HELO mail-qk0-f180.google.com) (209.85.220.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 23 Aug 2016 12:50:04 +0000 Received: by mail-qk0-f180.google.com with SMTP id t7so105031513qkh.1 for ; Tue, 23 Aug 2016 05:50:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=p/tYQhp7BDv7zWkF/qb6jxbnYBOfFyQLLoGDsuNpGG4=; b=Wk8m1QPwUzyn5KMmX7/oU3CnIasnoQsIJqD3NISQ5xZzL0X2wVl6bkZbYudl3BvIk7 9s9aQrxVJ7yMKc72cRy1PgPAgUJ2rjAJdg2YqAhUN7X3E9JBwBa8fDbgBoRFszRedfdC S4oZ9MrREtNyzSrRO+9q5tpF5Ff9Z5e6EDrBVTt4+TzZhjrIe9ET0G3keugbIMW3gSd3 I2Nut56kjBamrk1GjrAngFCXxz8vM2iyNtl/qFBDSR8yPK1FViBYLVGx+wga0wqIkfqt Vl0gChZiKQUlq75N0ToH8y//Byg0oIFW1CbE/BXqDM3UauzlYEgcaVJ3pv20QxoUOaMX h56A== X-Gm-Message-State: AE9vXwNZTlOc/AUQUmWMvCFHxpGojzpeedrvbYTLAi9jsSWkji7IInweqSzoBJevmT0Wg5jwIPvcJuEUvOC9FqFW X-Received: by 10.55.42.99 with SMTP id q96mr30333509qkh.246.1471956602304; Tue, 23 Aug 2016 05:50:02 -0700 (PDT) MIME-Version: 1.0 Received: by 10.140.21.9 with HTTP; Tue, 23 Aug 2016 05:50:01 -0700 (PDT) From: Christophe Lyon Date: Tue, 23 Aug 2016 14:50:01 +0200 Message-ID: Subject: [ARM] Fix predicable_short_it attribute for arm_movqi_insn To: "gcc-patches@gcc.gnu.org" X-IsSubscribed: yes Hi, While working on a larger patch for PR 67591 (ARM v8 Thumb IT blocks deprecated), I have noticed that the predicable_short_it attribute for arm_movqi_insn is incorrect: the values for alternatives 3 and 4 should be swapped. This is what this small patch does. Validated on several arm* configurations, with improvements on: c-c++-common/torture/builtin-arith-overflow-18.c c-c++-common/torture/builtin-arith-overflow-p-18.c c-c++-common/torture/builtin-arith-overflow-p-19.c for configurations involving armv8 and thumb mode. OK for trunk? Thanks, Christophe 2016-08-23 Christophe Lyon * config/arm/arm.md (arm_movqi_insn): Swap predicable_short_it attribute for alternatives 3 and 4. diff --git a/gcc/config/arm/arm.md b/gcc/config/arm/arm.md index 04714a1..219b664 100644 --- a/gcc/config/arm/arm.md +++ b/gcc/config/arm/arm.md @@ -6518,7 +6518,7 @@ strb%?\\t%1, %0" [(set_attr "type" "mov_reg,mov_reg,mov_imm,mov_imm,mvn_imm,load1,store1,load1,store1") (set_attr "predicable" "yes") - (set_attr "predicable_short_it" "yes,yes,yes,no,no,no,no,no,no") + (set_attr "predicable_short_it" "yes,yes,no,yes,no,no,no,no,no") (set_attr "arch" "t2,any,any,t2,any,t2,t2,any,any") (set_attr "length" "2,4,4,2,4,2,2,4,4")] )