From patchwork Fri Dec 5 13:14:53 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christophe Lyon X-Patchwork-Id: 41974 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ee0-f72.google.com (mail-ee0-f72.google.com [74.125.83.72]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 4301526669 for ; Fri, 5 Dec 2014 13:15:18 +0000 (UTC) Received: by mail-ee0-f72.google.com with SMTP id e53sf491514eek.3 for ; Fri, 05 Dec 2014 05:15:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:mailing-list:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:sender :delivered-to:mime-version:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:x-original-sender :x-original-authentication-results; bh=UE8XxBzMXFPx+sEOEiBtoc6c6EXvMpNGRl0ez25AbVQ=; b=MZTUO2ogzOaqoLd4xcDKFgI1t+UeZW5KVUuwEpv6dSfbwqdY9m9OLygc2T4CmHLJEa Aull94DhOPX0sHFVSiWqbal9QMLjMsscTJ7rqTxQzAfX9wnGiWtRkOy6WDGaeFCUP5tE M4nY5TsfySbLpl6Fa9nJo32x7EjGfTfrLlqE8jF5mP8dGlPswcxiX0R5nUiI1wVAKV7k jP+1wnsNYAuV8UZ5NX+qvNYeKtCzcbUwHXRYQW6jrF4reliipNN5ojqejqoQi2zcBXkb VXLH4qYZlEL1L5G8MRntAZsFBImmVLvzio9he04IYKYQALseof7b0vxIdIhC5O3MQR93 Wx1A== X-Gm-Message-State: ALoCoQkePDHfM2Os0z1UJjV/73372G6BDeCqBnnntcoSvxrZpfBupPEFi4vPblHlgmHHyJtRu2Gk X-Received: by 10.194.176.106 with SMTP id ch10mr38604wjc.6.1417785317166; Fri, 05 Dec 2014 05:15:17 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.5.74 with SMTP id q10ls385107laq.43.gmail; Fri, 05 Dec 2014 05:15:17 -0800 (PST) X-Received: by 10.152.120.167 with SMTP id ld7mr2767169lab.77.1417785317008; Fri, 05 Dec 2014 05:15:17 -0800 (PST) Received: from mail-lb0-x22f.google.com (mail-lb0-x22f.google.com. [2a00:1450:4010:c04::22f]) by mx.google.com with ESMTPS id m2si20584141lbs.81.2014.12.05.05.15.16 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 05 Dec 2014 05:15:16 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 2a00:1450:4010:c04::22f as permitted sender) client-ip=2a00:1450:4010:c04::22f; Received: by mail-lb0-f175.google.com with SMTP id u10so502442lbd.20 for ; Fri, 05 Dec 2014 05:15:16 -0800 (PST) X-Received: by 10.112.52.37 with SMTP id q5mr2856295lbo.32.1417785316888; Fri, 05 Dec 2014 05:15:16 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.184.201 with SMTP id ew9csp206918lbc; Fri, 5 Dec 2014 05:15:15 -0800 (PST) X-Received: by 10.66.157.196 with SMTP id wo4mr28514530pab.156.1417785314676; Fri, 05 Dec 2014 05:15:14 -0800 (PST) Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id kd8si47387483pbc.239.2014.12.05.05.15.13 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Dec 2014 05:15:14 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-return-386667-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Received: (qmail 5834 invoked by alias); 5 Dec 2014 13:15:00 -0000 Mailing-List: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 5806 invoked by uid 89); 5 Dec 2014 13:14:58 -0000 X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-qc0-f181.google.com Received: from mail-qc0-f181.google.com (HELO mail-qc0-f181.google.com) (209.85.216.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 05 Dec 2014 13:14:56 +0000 Received: by mail-qc0-f181.google.com with SMTP id m20so412048qcx.12 for ; Fri, 05 Dec 2014 05:14:54 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.224.46.131 with SMTP id j3mr24837450qaf.86.1417785293996; Fri, 05 Dec 2014 05:14:53 -0800 (PST) Received: by 10.140.21.234 with HTTP; Fri, 5 Dec 2014 05:14:53 -0800 (PST) In-Reply-To: References: Date: Fri, 5 Dec 2014 14:14:53 +0100 Message-ID: Subject: Re: [ARM,AArch64][testsuite] Fix vaddl and vaddw tests From: Christophe Lyon To: "gcc-patches@gcc.gnu.org" Cc: Ramana Radhakrishnan , Marcus Shawcroft X-IsSubscribed: yes X-Original-Sender: christophe.lyon@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 2a00:1450:4010:c04::22f as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org; dkim=pass header.i=@gcc.gnu.org X-Google-Group-Id: 836684582541 On 3 December 2014 at 17:12, Christophe Lyon wrote: > On 3 December 2014 at 15:22, Christophe Lyon wrote: >> Hi, >> >> Here is a fix for typos in the AdvSimd intrinsic tests, where vaddl >> and vaddw didn't actually execute the tests. (The function was >> declared in main, instead of called). >> >> This patch also fixes the expected output for these tests. > > And it looks like I'll have to apply the same obvious fix to vaddhn.c > Here is the patch to fix the 3 test cases (vaddl, vaddw, vaddhn). OK? 2014-12-05 Christophe Lyon testsuite/ * gcc.target/aarch64/advsimd-intrinsics/vaddhn.c: Actually execute the test. * gcc.target/aarch64/advsimd-intrinsics/vaddl.c: Actually execute the test. Fix expected output. * gcc.target/aarch64/advsimd-intrinsics/vaddw.c: Likewise. >> >> OK? >> >> Thanks >> Christophe. >> >> 2014-12-03 Christophe Lyon >> >> testsuite/ >> * gcc.target/aarch64/advsimd-intrinsics/vaddl.c: Actually execute >> the test. Fix expected output. >> * gcc.target/aarch64/advsimd-intrinsics/vaddw.c: Likewise. diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vaddhn.c b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vaddhn.c index 74b4b4d..58fd5ea 100644 --- a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vaddhn.c +++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vaddhn.c @@ -52,15 +52,13 @@ VECT_VAR_DECL(expected,poly,16,8) [] = { 0x3333, 0x3333, 0x3333, 0x3333, VECT_VAR_DECL(expected,hfloat,32,4) [] = { 0x33333333, 0x33333333, 0x33333333, 0x33333333 }; -#ifndef INSN_NAME #define INSN_NAME vaddhn #define TEST_MSG "VADDHN" -#endif -#define FNNAME1(NAME) void exec_ ## NAME (void) +#define FNNAME1(NAME) exec_ ## NAME #define FNNAME(NAME) FNNAME1(NAME) -FNNAME (INSN_NAME) +void FNNAME (INSN_NAME) (void) { /* Basic test: vec64=vaddhn(vec128_a, vec128_b), then store the result. */ #define TEST_VADDHN1(INSN, T1, T2, W, W2, N) \ @@ -104,6 +102,6 @@ FNNAME (INSN_NAME) int main (void) { - FNNAME (INSN_NAME); + FNNAME (INSN_NAME) (); return 0; } diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vaddl.c b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vaddl.c index 861abec..030785d 100644 --- a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vaddl.c +++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vaddl.c @@ -5,13 +5,13 @@ /* Expected results. */ VECT_VAR_DECL(expected,int,8,8) [] = { 0x33, 0x33, 0x33, 0x33, 0x33, 0x33, 0x33, 0x33 }; -VECT_VAR_DECL(expected,int,16,4) [] = { 0x33, 0x33, 0x33, 0x33 }; -VECT_VAR_DECL(expected,int,32,2) [] = { 0x33, 0x33 }; +VECT_VAR_DECL(expected,int,16,4) [] = { 0x3333, 0x3333, 0x3333, 0x3333 }; +VECT_VAR_DECL(expected,int,32,2) [] = { 0x33333333, 0x33333333 }; VECT_VAR_DECL(expected,int,64,1) [] = { 0x3333333333333333 }; -VECT_VAR_DECL(expected,uint,8,8) [] = { 0x3, 0x3, 0x3, 0x3, - 0x3, 0x3, 0x3, 0x3 }; -VECT_VAR_DECL(expected,uint,16,4) [] = { 0x37, 0x37, 0x37, 0x37 }; -VECT_VAR_DECL(expected,uint,32,2) [] = { 0x3, 0x3 }; +VECT_VAR_DECL(expected,uint,8,8) [] = { 0x33, 0x33, 0x33, 0x33, + 0x33, 0x33, 0x33, 0x33 }; +VECT_VAR_DECL(expected,uint,16,4) [] = { 0x3333, 0x3333, 0x3333, 0x3333 }; +VECT_VAR_DECL(expected,uint,32,2) [] = { 0x33333333, 0x33333333 }; VECT_VAR_DECL(expected,uint,64,1) [] = { 0x3333333333333333 }; VECT_VAR_DECL(expected,poly,8,8) [] = { 0x33, 0x33, 0x33, 0x33, 0x33, 0x33, 0x33, 0x33 }; @@ -45,15 +45,13 @@ VECT_VAR_DECL(expected,poly,16,8) [] = { 0x3333, 0x3333, 0x3333, 0x3333, VECT_VAR_DECL(expected,hfloat,32,4) [] = { 0x33333333, 0x33333333, 0x33333333, 0x33333333 }; -#ifndef INSN_NAME #define INSN_NAME vaddl #define TEST_MSG "VADDL" -#endif -#define FNNAME1(NAME) void exec_ ## NAME (void) +#define FNNAME1(NAME) exec_ ## NAME #define FNNAME(NAME) FNNAME1(NAME) -FNNAME (INSN_NAME) +void FNNAME (INSN_NAME) (void) { /* Basic test: y=vaddl(x1,x2), then store the result. */ #define TEST_VADDL1(INSN, T1, T2, W, W2, N) \ @@ -117,6 +115,6 @@ FNNAME (INSN_NAME) int main (void) { - FNNAME (INSN_NAME); + FNNAME (INSN_NAME) (); return 0; } diff --git a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vaddw.c b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vaddw.c index 5804cd7..95cbb31 100644 --- a/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vaddw.c +++ b/gcc/testsuite/gcc.target/aarch64/advsimd-intrinsics/vaddw.c @@ -5,13 +5,13 @@ /* Expected results. */ VECT_VAR_DECL(expected,int,8,8) [] = { 0x33, 0x33, 0x33, 0x33, 0x33, 0x33, 0x33, 0x33 }; -VECT_VAR_DECL(expected,int,16,4) [] = { 0x33, 0x33, 0x33, 0x33 }; -VECT_VAR_DECL(expected,int,32,2) [] = { 0x33, 0x33 }; +VECT_VAR_DECL(expected,int,16,4) [] = { 0x3333, 0x3333, 0x3333, 0x3333 }; +VECT_VAR_DECL(expected,int,32,2) [] = { 0x33333333, 0x33333333 }; VECT_VAR_DECL(expected,int,64,1) [] = { 0x3333333333333333 }; -VECT_VAR_DECL(expected,uint,8,8) [] = { 0x3, 0x3, 0x3, 0x3, - 0x3, 0x3, 0x3, 0x3 }; -VECT_VAR_DECL(expected,uint,16,4) [] = { 0x37, 0x37, 0x37, 0x37 }; -VECT_VAR_DECL(expected,uint,32,2) [] = { 0x3, 0x3 }; +VECT_VAR_DECL(expected,uint,8,8) [] = { 0x33, 0x33, 0x33, 0x33, + 0x33, 0x33, 0x33, 0x33 }; +VECT_VAR_DECL(expected,uint,16,4) [] = { 0x3333, 0x3333, 0x3333, 0x3333 }; +VECT_VAR_DECL(expected,uint,32,2) [] = { 0x33333333, 0x33333333 }; VECT_VAR_DECL(expected,uint,64,1) [] = { 0x3333333333333333 }; VECT_VAR_DECL(expected,poly,8,8) [] = { 0x33, 0x33, 0x33, 0x33, 0x33, 0x33, 0x33, 0x33 }; @@ -45,15 +45,13 @@ VECT_VAR_DECL(expected,poly,16,8) [] = { 0x3333, 0x3333, 0x3333, 0x3333, VECT_VAR_DECL(expected,hfloat,32,4) [] = { 0x33333333, 0x33333333, 0x33333333, 0x33333333 }; -#ifndef INSN_NAME #define INSN_NAME vaddw #define TEST_MSG "VADDW" -#endif -#define FNNAME1(NAME) void exec_ ## NAME (void) +#define FNNAME1(NAME) exec_ ## NAME #define FNNAME(NAME) FNNAME1(NAME) -FNNAME (INSN_NAME) +void FNNAME (INSN_NAME) (void) { /* Basic test: y=vaddw(x1,x2), then store the result. */ #define TEST_VADDW1(INSN, T1, T2, W, W2, N) \ @@ -117,6 +115,6 @@ FNNAME (INSN_NAME) int main (void) { - FNNAME (INSN_NAME); + FNNAME (INSN_NAME) (); return 0; }