From patchwork Sat Jan 24 07:53:22 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Venkataramanan Kumar X-Patchwork-Id: 43718 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-la0-f69.google.com (mail-la0-f69.google.com [209.85.215.69]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id D367420D5D for ; Sat, 24 Jan 2015 07:53:51 +0000 (UTC) Received: by mail-la0-f69.google.com with SMTP id gm9sf635050lab.0 for ; Fri, 23 Jan 2015 23:53:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:mailing-list:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:sender :delivered-to:mime-version:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:x-original-sender :x-original-authentication-results; bh=QXY4phd2GzuRNwlXddEWd23HvfkK+mixlpxv/+i+AzU=; b=J3l4yshk4PeNPgOaB/ztUYaqh5B+YYtM0b7RxjxgTpFeALhaATjI0x5BAJ/yAM4jpo DzYPcaeAzcuSZ6Q4M4qZxLWRZUXZ89TR6hMFXYA4pMoPF3jNZbDLuUzRfTzxLYHbYrCK Eng624fnpfqRoA0dqzo1TrFwP6ZYFgquy9l6fkIwvZxyobeR02p1ERFI1QAfDHHLGDaJ P6yPmHWEvVWjzCjwuvX6/I68IjClBfUSqiFYMq77mXDWoH8Uo8bndayFfn2Pne/Lzh/N tKYqSKHAubj5Hrxos/lH9XivLJpfzzGP+SS0/zbT8s2XKW1a4wd1B/ukwh0fPOZwrZx8 Wtxw== X-Gm-Message-State: ALoCoQm7HfK5UpBMR3OtGnIRnxMQZRq1paRtiHjTnALmhpwqrNpkfTi3Bmv+430GW1Bm+mBDrmRL X-Received: by 10.112.30.131 with SMTP id s3mr209150lbh.13.1422086030219; Fri, 23 Jan 2015 23:53:50 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.1.66 with SMTP id 2ls364155lak.10.gmail; Fri, 23 Jan 2015 23:53:49 -0800 (PST) X-Received: by 10.112.37.161 with SMTP id z1mr11293923lbj.87.1422086029785; Fri, 23 Jan 2015 23:53:49 -0800 (PST) Received: from mail-la0-x235.google.com (mail-la0-x235.google.com. [2a00:1450:4010:c03::235]) by mx.google.com with ESMTPS id ss9si3397872lbb.89.2015.01.23.23.53.49 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 23 Jan 2015 23:53:49 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 2a00:1450:4010:c03::235 as permitted sender) client-ip=2a00:1450:4010:c03::235; Received: by mail-la0-f53.google.com with SMTP id gq15so1099563lab.12 for ; Fri, 23 Jan 2015 23:53:49 -0800 (PST) X-Received: by 10.152.6.132 with SMTP id b4mr11463870laa.59.1422086029306; Fri, 23 Jan 2015 23:53:49 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.35.133 with SMTP id h5csp162278lbj; Fri, 23 Jan 2015 23:53:47 -0800 (PST) X-Received: by 10.66.153.48 with SMTP id vd16mr17568554pab.146.1422086027003; Fri, 23 Jan 2015 23:53:47 -0800 (PST) Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id du17si4851511pdb.44.2015.01.23.23.53.46 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 Jan 2015 23:53:46 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-return-390338-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Received: (qmail 22206 invoked by alias); 24 Jan 2015 07:53:32 -0000 Mailing-List: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 22186 invoked by uid 89); 24 Jan 2015 07:53:27 -0000 X-Spam-SWARE-Status: No, score=-0.2 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, SPF_PASS, URIBL_BLACK autolearn=no version=3.3.2 X-HELO: mail-qg0-f46.google.com Received: from mail-qg0-f46.google.com (HELO mail-qg0-f46.google.com) (209.85.192.46) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sat, 24 Jan 2015 07:53:25 +0000 Received: by mail-qg0-f46.google.com with SMTP id i50so1072730qgf.5 for ; Fri, 23 Jan 2015 23:53:22 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.224.23.133 with SMTP id r5mr22916031qab.88.1422086002658; Fri, 23 Jan 2015 23:53:22 -0800 (PST) Received: by 10.140.91.202 with HTTP; Fri, 23 Jan 2015 23:53:22 -0800 (PST) In-Reply-To: References: <20150122140336.GA1746@tucnak.redhat.com> <20150122204447.GN1746@tucnak.redhat.com> Date: Sat, 24 Jan 2015 13:23:22 +0530 Message-ID: Subject: Re: [PING]: [PATCH]: Conditionally include target specific files while building TSAN From: Venkataramanan Kumar To: Rainer Orth Cc: Jakub Jelinek , Dmitry Vyukov , Kostya Serebryany , "gcc-patches@gcc.gnu.org" , Christophe Lyon X-IsSubscribed: yes X-Original-Sender: venkataramanan.kumar@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 2a00:1450:4010:c03::235 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org; dkim=pass header.i=@gcc.gnu.org X-Google-Group-Id: 836684582541 Hi Rainer, I reused libgcc's "host_address" test and the patch passed normal bootstrap in x86_64. Can you please check if this is fine ? regards, Venkat. On 24 January 2015 at 12:53, Rainer Orth wrote: > Hi Venkat, > >> Yes thanks I will work on fixing this. Let me know if I need to revert >> the patch meanwhile. > > I don't think this is urgent enough to justify reversion. > > Thanks. > Rainer > > -- > ----------------------------------------------------------------------------- > Rainer Orth, Center for Biotechnology, Bielefeld University Index: libsanitizer/ChangeLog =================================================================== --- libsanitizer/ChangeLog (revision 220077) +++ libsanitizer/ChangeLog (working copy) @@ -1,5 +1,10 @@ 2015-01-25 Venkataramanan Kumar + * configure.ac: Set host_address to 64 or 32. + * configure: Regenerate. + +2015-01-25 Venkataramanan Kumar + * configure.ac (TSAN_TARGET_DEPENDENT_OBJECTS): Define. * configure: Regenerate. * tsan/Makefile.am (EXTRA_libtsan_la_SOURCES): Define. Index: libsanitizer/configure =================================================================== --- libsanitizer/configure (revision 220077) +++ libsanitizer/configure (working copy) @@ -16363,12 +16363,31 @@ fi -case "${target}" in - x86_64-*-linux-*) TSAN_TARGET_DEPENDENT_OBJECTS='tsan_rtl_amd64.lo' ;; - *) TSAN_TARGET_DEPENDENT_OBJECTS='' ;; -esac +# Check 32bit or 64bit. In the case of MIPS, this really determines the +# word size rather than the address size. +cat > conftest.c <confcache <<\_ACEOF # This file is a shell script that caches the results of configure # tests run on this system so they can be shared between configure Index: libsanitizer/configure.ac =================================================================== --- libsanitizer/configure.ac (revision 220077) +++ libsanitizer/configure.ac (working copy) @@ -346,10 +346,29 @@ ]) fi -case "${target}" in - x86_64-*-linux-*) TSAN_TARGET_DEPENDENT_OBJECTS='tsan_rtl_amd64.lo' ;; - *) TSAN_TARGET_DEPENDENT_OBJECTS='' ;; -esac +# Check 32bit or 64bit. In the case of MIPS, this really determines the +# word size rather than the address size. +cat > conftest.c <