From patchwork Sat Jan 24 08:13:02 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Venkataramanan Kumar X-Patchwork-Id: 43719 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wg0-f69.google.com (mail-wg0-f69.google.com [74.125.82.69]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 04088218DB for ; Sat, 24 Jan 2015 08:13:26 +0000 (UTC) Received: by mail-wg0-f69.google.com with SMTP id x12sf654024wgg.0 for ; Sat, 24 Jan 2015 00:13:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:mailing-list:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:sender :delivered-to:mime-version:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:x-original-sender :x-original-authentication-results; bh=E3pBOFtomoLc8FOQm5UZqE/IERNA7PLbyAbVAco8mMA=; b=Lxyn5IyJrENsoM5sM+YjDijBZ1BRCsaFaU0xiNW00QDqNlEaJS6uRiL9M9+pSjPzxe +KaKylpLlD8auq/Iq3WYikLN98UgbvYpbwTIR+20y0HAm0gpbLMFwPNri/J6ACt5Wgje 0ZE/p7g5vRn1uWoI4f6x1rMJCSi88m4SnP6MZU/i6CEToI46BX/z8MYnRF4TdHg69TTN 1xoCkf7O0+xWbuC8QXSBbkcc8mrAF7drO+1JqZry+IyMPdDJvasvv3F8m1cR7XyvziYb T7BQNgGQopheQOMTp8m1VYSMGeW9O3JRBlVQCDeR73pT2h0qXo4IVjcQjvSWdL34efd2 kUPA== X-Gm-Message-State: ALoCoQmjIItG2Fc4l2WxboF1UmGmrfWfFeAv7ILi1oHcl+wTNdaPuQlxmZnCA/VgFizxw39P3D+p X-Received: by 10.180.212.76 with SMTP id ni12mr771721wic.0.1422087205271; Sat, 24 Jan 2015 00:13:25 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.203.134 with SMTP id kq6ls342113lac.36.gmail; Sat, 24 Jan 2015 00:13:24 -0800 (PST) X-Received: by 10.152.197.5 with SMTP id iq5mr11422889lac.6.1422087204964; Sat, 24 Jan 2015 00:13:24 -0800 (PST) Received: from mail-lb0-x232.google.com (mail-lb0-x232.google.com. [2a00:1450:4010:c04::232]) by mx.google.com with ESMTPS id w12si3501474lba.3.2015.01.24.00.13.24 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 24 Jan 2015 00:13:24 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 2a00:1450:4010:c04::232 as permitted sender) client-ip=2a00:1450:4010:c04::232; Received: by mail-lb0-f178.google.com with SMTP id u10so1137983lbd.9 for ; Sat, 24 Jan 2015 00:13:24 -0800 (PST) X-Received: by 10.152.43.103 with SMTP id v7mr11404587lal.29.1422087204725; Sat, 24 Jan 2015 00:13:24 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.35.133 with SMTP id h5csp166668lbj; Sat, 24 Jan 2015 00:13:23 -0800 (PST) X-Received: by 10.68.162.130 with SMTP id ya2mr17434734pbb.113.1422087202687; Sat, 24 Jan 2015 00:13:22 -0800 (PST) Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id zd8si4921135pac.24.2015.01.24.00.13.21 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 24 Jan 2015 00:13:22 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-return-390339-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Received: (qmail 2134 invoked by alias); 24 Jan 2015 08:13:08 -0000 Mailing-List: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 2116 invoked by uid 89); 24 Jan 2015 08:13:06 -0000 X-Spam-SWARE-Status: No, score=0.8 required=5.0 tests=AWL, BAYES_40, RCVD_IN_DNSWL_LOW, SPF_PASS, URIBL_BLACK autolearn=no version=3.3.2 X-HELO: mail-qg0-f48.google.com Received: from mail-qg0-f48.google.com (HELO mail-qg0-f48.google.com) (209.85.192.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sat, 24 Jan 2015 08:13:05 +0000 Received: by mail-qg0-f48.google.com with SMTP id z60so1090594qgd.7 for ; Sat, 24 Jan 2015 00:13:02 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.140.38.114 with SMTP id s105mr721086qgs.106.1422087182611; Sat, 24 Jan 2015 00:13:02 -0800 (PST) Received: by 10.140.91.202 with HTTP; Sat, 24 Jan 2015 00:13:02 -0800 (PST) In-Reply-To: References: <20150122140336.GA1746@tucnak.redhat.com> <20150122204447.GN1746@tucnak.redhat.com> Date: Sat, 24 Jan 2015 13:43:02 +0530 Message-ID: Subject: Re: [PING]: [PATCH]: Conditionally include target specific files while building TSAN From: Venkataramanan Kumar To: Rainer Orth Cc: Jakub Jelinek , Dmitry Vyukov , Kostya Serebryany , "gcc-patches@gcc.gnu.org" , Christophe Lyon X-IsSubscribed: yes X-Original-Sender: venkataramanan.kumar@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 2a00:1450:4010:c04::232 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org; dkim=pass header.i=@gcc.gnu.org X-Google-Group-Id: 836684582541 Hi Rainer, Please find the corrected patch attached. I removed some eval statements I added for debugging. regards, Venkat, On 24 January 2015 at 13:23, Venkataramanan Kumar wrote: > Hi Rainer, > > I reused libgcc's "host_address" test and the patch passed normal > bootstrap in x86_64. > > Can you please check if this is fine ? > > regards, > Venkat. > > On 24 January 2015 at 12:53, Rainer Orth wrote: >> Hi Venkat, >> >>> Yes thanks I will work on fixing this. Let me know if I need to revert >>> the patch meanwhile. >> >> I don't think this is urgent enough to justify reversion. >> >> Thanks. >> Rainer >> >> -- >> ----------------------------------------------------------------------------- >> Rainer Orth, Center for Biotechnology, Bielefeld University Index: libsanitizer/ChangeLog =================================================================== --- libsanitizer/ChangeLog (revision 220077) +++ libsanitizer/ChangeLog (working copy) @@ -1,5 +1,10 @@ 2015-01-25 Venkataramanan Kumar + * configure.ac: Set host_address to 64 or 32. + * configure: Regenerate. + +2015-01-25 Venkataramanan Kumar + * configure.ac (TSAN_TARGET_DEPENDENT_OBJECTS): Define. * configure: Regenerate. * tsan/Makefile.am (EXTRA_libtsan_la_SOURCES): Define. Index: libsanitizer/configure =================================================================== --- libsanitizer/configure (revision 220077) +++ libsanitizer/configure (working copy) @@ -16363,12 +16363,29 @@ fi -case "${target}" in - x86_64-*-linux-*) TSAN_TARGET_DEPENDENT_OBJECTS='tsan_rtl_amd64.lo' ;; - *) TSAN_TARGET_DEPENDENT_OBJECTS='' ;; -esac +# Check 32bit or 64bit. In the case of MIPS, this really determines the +# word size rather than the address size. +cat > conftest.c <confcache <<\_ACEOF # This file is a shell script that caches the results of configure # tests run on this system so they can be shared between configure Index: libsanitizer/configure.ac =================================================================== --- libsanitizer/configure.ac (revision 220077) +++ libsanitizer/configure.ac (working copy) @@ -346,10 +346,27 @@ ]) fi -case "${target}" in - x86_64-*-linux-*) TSAN_TARGET_DEPENDENT_OBJECTS='tsan_rtl_amd64.lo' ;; - *) TSAN_TARGET_DEPENDENT_OBJECTS='' ;; -esac +# Check 32bit or 64bit. In the case of MIPS, this really determines the +# word size rather than the address size. +cat > conftest.c <