From patchwork Sat Jan 24 14:39:24 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Venkataramanan Kumar X-Patchwork-Id: 43720 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-we0-f199.google.com (mail-we0-f199.google.com [74.125.82.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 027382055F for ; Sat, 24 Jan 2015 14:39:48 +0000 (UTC) Received: by mail-we0-f199.google.com with SMTP id u56sf1067160wes.2 for ; Sat, 24 Jan 2015 06:39:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:mailing-list:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:sender :delivered-to:mime-version:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:x-original-sender :x-original-authentication-results; bh=/vC0zkiEWTVZ0dpdprHFZBFCztrWS/u5nQlrlAWvXG0=; b=bJp8sykvG7hteU9HBL74Hqow6d9/wtZIM7ForK7KLXIIgMyXlmllP1SY8/lSBTpdvS ZUWmCWE0sm0S9x5geVE8vPJQYIxsLEH4qWjqj15MEhSqis5wxv+8Az/KWOBYo2fF+rKT NXuajiZV39n2KYEcgof6N/Uz/UkzQbRGUNA1aJ0sYUFfImpkNDzxSEJzMrveZwyeLszI trjzdAThv3gEB9/HlK6BIG2uyjpvQsgWiBB+ICBUOaTnCGFCgtxIlGgyQTw/uEAnCVnP 8JCTAwcM4KACqq1yxtRICMA27kNmIXClkmUoSNgYXAnPx8UhxfhYa42Ap3DOX97LZYFr Ejxg== X-Gm-Message-State: ALoCoQk8CBe2Etx4ZdpZ9XfNqhVufQY5OpInh/nWdp26fEuQXMM8qwaQ4MT4z+hfQo1g/NNv/pAH X-Received: by 10.180.94.134 with SMTP id dc6mr892214wib.2.1422110387160; Sat, 24 Jan 2015 06:39:47 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.120.193 with SMTP id le1ls147856lab.11.gmail; Sat, 24 Jan 2015 06:39:47 -0800 (PST) X-Received: by 10.112.119.139 with SMTP id ku11mr12912074lbb.76.1422110386996; Sat, 24 Jan 2015 06:39:46 -0800 (PST) Received: from mail-la0-x231.google.com (mail-la0-x231.google.com. [2a00:1450:4010:c03::231]) by mx.google.com with ESMTPS id i3si363625lag.68.2015.01.24.06.39.46 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 24 Jan 2015 06:39:46 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 2a00:1450:4010:c03::231 as permitted sender) client-ip=2a00:1450:4010:c03::231; Received: by mail-la0-f49.google.com with SMTP id gf13so1887010lab.8 for ; Sat, 24 Jan 2015 06:39:46 -0800 (PST) X-Received: by 10.112.90.170 with SMTP id bx10mr12562721lbb.69.1422110386295; Sat, 24 Jan 2015 06:39:46 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.35.133 with SMTP id h5csp255836lbj; Sat, 24 Jan 2015 06:39:45 -0800 (PST) X-Received: by 10.66.65.195 with SMTP id z3mr20120777pas.10.1422110383845; Sat, 24 Jan 2015 06:39:43 -0800 (PST) Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id o4si5612837pdg.219.2015.01.24.06.39.42 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 24 Jan 2015 06:39:43 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-return-390355-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Received: (qmail 26713 invoked by alias); 24 Jan 2015 14:39:29 -0000 Mailing-List: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 26699 invoked by uid 89); 24 Jan 2015 14:39:28 -0000 X-Spam-SWARE-Status: No, score=-0.1 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, SPF_PASS, URIBL_BLACK autolearn=no version=3.3.2 X-HELO: mail-qg0-f48.google.com Received: from mail-qg0-f48.google.com (HELO mail-qg0-f48.google.com) (209.85.192.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Sat, 24 Jan 2015 14:39:27 +0000 Received: by mail-qg0-f48.google.com with SMTP id z60so1717572qgd.7 for ; Sat, 24 Jan 2015 06:39:24 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.224.24.132 with SMTP id v4mr3371353qab.17.1422110364807; Sat, 24 Jan 2015 06:39:24 -0800 (PST) Received: by 10.140.91.202 with HTTP; Sat, 24 Jan 2015 06:39:24 -0800 (PST) In-Reply-To: <20150124091013.GA1746@tucnak.redhat.com> References: <20150122140336.GA1746@tucnak.redhat.com> <20150122204447.GN1746@tucnak.redhat.com> <20150124091013.GA1746@tucnak.redhat.com> Date: Sat, 24 Jan 2015 20:09:24 +0530 Message-ID: Subject: Re: [PING]: [PATCH]: Conditionally include target specific files while building TSAN From: Venkataramanan Kumar To: Jakub Jelinek Cc: Rainer Orth , Dmitry Vyukov , Kostya Serebryany , "gcc-patches@gcc.gnu.org" , Christophe Lyon X-IsSubscribed: yes X-Original-Sender: venkataramanan.kumar@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 2a00:1450:4010:c03::231 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org; dkim=pass header.i=@gcc.gnu.org X-Google-Group-Id: 836684582541 Hi Jakub, On 24 January 2015 at 14:40, Jakub Jelinek wrote: > On Sat, Jan 24, 2015 at 01:23:22PM +0530, Venkataramanan Kumar wrote: >> I reused libgcc's "host_address" test and the patch passed normal >> bootstrap in x86_64. >> >> Can you please check if this is fine ? > > Can't you just use what configure.tgt already uses? > > x86_64-*-linux* | i?86-*-linux*) > if test x$ac_cv_sizeof_void_p = x8; then > TSAN_SUPPORTED=yes > LSAN_SUPPORTED=yes > fi > ;; > > Just make sure AC_CHECK_SIZEOF([void *]) is above this (seems it is). > > So > > TSAN_TARGET_DEPENDENT_OBJECTS= > case "${target}" in > x86_64-*-linux* | i?86-*-linux*) > if test x$ac_cv_sizeof_void_p = x8; then > TSAN_TARGET_DEPENDENT_OBJECTS=tsan_rtl_amd64.lo > fi;; > esac > AC_SUBST([TSAN_TARGET_DEPENDENT_OBJECTS]) > > ? > Or even better move the TSAN_TARGET_DEPENDENT_OBJECTS initialization > to configure.tgt and just keep AC_SUBST([TSAN_TARGET_DEPENDENT_OBJECTS]) > in configure.ac. > > Jakub As per you suggestion, I moved the TSAN_TARGET_DEPENDENT_OBJECTS to "configure.tgt" also it includes i?86 targets. Bootstraped on x86_64 and Aarch64. regards, Venkat. Index: libsanitizer/ChangeLog =================================================================== --- libsanitizer/ChangeLog (revision 220079) +++ libsanitizer/ChangeLog (working copy) @@ -1,5 +1,11 @@ 2015-01-25 Venkataramanan Kumar + * configure.ac (TSAN_TARGET_DEPENDENT_OBJECTS): Undefine. + * configure: Regenerate. + * configure.tgt (TSAN_TARGET_DEPENDENT_OBJECTS): Define. + +2015-01-25 Venkataramanan Kumar + * configure.ac (TSAN_TARGET_DEPENDENT_OBJECTS): Define. * configure: Regenerate. * tsan/Makefile.am (EXTRA_libtsan_la_SOURCES): Define. Index: libsanitizer/configure =================================================================== --- libsanitizer/configure (revision 220079) +++ libsanitizer/configure (working copy) @@ -16363,10 +16363,6 @@ fi -case "${target}" in - x86_64-*-linux-*) TSAN_TARGET_DEPENDENT_OBJECTS='tsan_rtl_amd64.lo' ;; - *) TSAN_TARGET_DEPENDENT_OBJECTS='' ;; -esac cat >confcache <<\_ACEOF Index: libsanitizer/configure.ac =================================================================== --- libsanitizer/configure.ac (revision 220079) +++ libsanitizer/configure.ac (working copy) @@ -346,10 +346,6 @@ ]) fi -case "${target}" in - x86_64-*-linux-*) TSAN_TARGET_DEPENDENT_OBJECTS='tsan_rtl_amd64.lo' ;; - *) TSAN_TARGET_DEPENDENT_OBJECTS='' ;; -esac AC_SUBST([TSAN_TARGET_DEPENDENT_OBJECTS]) AC_OUTPUT Index: libsanitizer/configure.tgt =================================================================== --- libsanitizer/configure.tgt (revision 220079) +++ libsanitizer/configure.tgt (working copy) @@ -19,11 +19,13 @@ # lets us skip running autoconf when modifying target specific information. # Filter out unsupported systems. +TSAN_TARGET_DEPENDENT_OBJECTS= case "${target}" in x86_64-*-linux* | i?86-*-linux*) if test x$ac_cv_sizeof_void_p = x8; then TSAN_SUPPORTED=yes LSAN_SUPPORTED=yes + TSAN_TARGET_DEPENDENT_OBJECTS=tsan_rtl_amd64.lo fi ;; powerpc*le-*-linux*)