From patchwork Wed Apr 15 12:51:49 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yvan Roux X-Patchwork-Id: 47174 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-la0-f69.google.com (mail-la0-f69.google.com [209.85.215.69]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 4EEFB20553 for ; Wed, 15 Apr 2015 12:52:13 +0000 (UTC) Received: by lamp14 with SMTP id p14sf9741802lam.3 for ; Wed, 15 Apr 2015 05:52:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:mailing-list:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:sender :delivered-to:mime-version:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:x-original-sender :x-original-authentication-results; bh=ys0Tv08k8uexWGgd+RxqYT1LyqPCd1UPpS5CmEH+U8I=; b=NznM+wqWRNwj61MeBGDmd6sKh7zmFGYqasFENuqGXG+QKXqLgqeCuVfN3ZSUxo/kj+ BX0scvTU0kwKL2Em+Q+b/Oso7/Nq9KboYC/NN9faOjKSud8AMxUyd9XT2VBCrZT81wq+ 7tUCDjcaGnX4MBpOtXbUv5fZdquwNSpCym4CKuKOBTWR6E9a0hyFRVWI+UXB2KnDx3L3 exp5HaQl7KcU4ygloIXOFuT4tjjAnBTEAB9eAQgYkePKjjf0jV40eocm6iToI+WDFhpH 1bDZuHS9EQ4eNMgELjXEl/PeohZFii6BDhDQSHYSf7k51os7/BGdTRD8BtOVHhZ+7rrW XB4Q== X-Gm-Message-State: ALoCoQnNyiX0r1CDxxVotkYIiTLNeVHt30Y2nA7pkjY+6wEU8F0MyelH6+a3z5H5JWZUCiXZlEpS X-Received: by 10.112.203.168 with SMTP id kr8mr5155654lbc.10.1429102332092; Wed, 15 Apr 2015 05:52:12 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.170.198 with SMTP id ao6ls177136lac.103.gmail; Wed, 15 Apr 2015 05:52:11 -0700 (PDT) X-Received: by 10.112.83.135 with SMTP id q7mr23858167lby.13.1429102331911; Wed, 15 Apr 2015 05:52:11 -0700 (PDT) Received: from mail-lb0-x22e.google.com (mail-lb0-x22e.google.com. [2a00:1450:4010:c04::22e]) by mx.google.com with ESMTPS id xs10si3835040lbb.86.2015.04.15.05.52.11 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 Apr 2015 05:52:11 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 2a00:1450:4010:c04::22e as permitted sender) client-ip=2a00:1450:4010:c04::22e; Received: by lbbuc2 with SMTP id uc2so33068195lbb.2 for ; Wed, 15 Apr 2015 05:52:11 -0700 (PDT) X-Received: by 10.112.8.101 with SMTP id q5mr23796957lba.19.1429102331632; Wed, 15 Apr 2015 05:52:11 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.67.65 with SMTP id l1csp2490663lbt; Wed, 15 Apr 2015 05:52:10 -0700 (PDT) X-Received: by 10.68.114.194 with SMTP id ji2mr46586201pbb.132.1429102329073; Wed, 15 Apr 2015 05:52:09 -0700 (PDT) Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id ws11si6914476pac.186.2015.04.15.05.52.08 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 Apr 2015 05:52:09 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-return-395214-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Received: (qmail 10300 invoked by alias); 15 Apr 2015 12:51:54 -0000 Mailing-List: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 10291 invoked by uid 89); 15 Apr 2015 12:51:54 -0000 X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-wi0-f181.google.com Received: from mail-wi0-f181.google.com (HELO mail-wi0-f181.google.com) (209.85.212.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 15 Apr 2015 12:51:52 +0000 Received: by wiax7 with SMTP id x7so111352945wia.0 for ; Wed, 15 Apr 2015 05:51:49 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.195.12.48 with SMTP id en16mr34688850wjd.21.1429102309653; Wed, 15 Apr 2015 05:51:49 -0700 (PDT) Received: by 10.28.4.204 with HTTP; Wed, 15 Apr 2015 05:51:49 -0700 (PDT) In-Reply-To: <552D3412.6070100@redhat.com> References: <5527FCAC.3090205@redhat.com> <20150414081123.GF1725@tucnak.redhat.com> <552D3412.6070100@redhat.com> Date: Wed, 15 Apr 2015 14:51:49 +0200 Message-ID: Subject: Re: patch for PR65729 From: Yvan Roux To: Vladimir Makarov Cc: "gcc-patches@gcc.gnu.org" X-IsSubscribed: yes X-Original-Sender: yvan.roux@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 2a00:1450:4010:c04::22e as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org; dkim=pass header.i=@gcc.gnu.org X-Google-Group-Id: 836684582541 Hi, On 14 April 2015 at 17:36, Vladimir Makarov wrote: > On 04/14/2015 04:11 AM, Jakub Jelinek wrote: >> >> On Tue, Apr 14, 2015 at 10:08:24AM +0200, Yvan Roux wrote: >>> >>> --- a/gcc/lra-constraints.c >>> +++ b/gcc/lra-constraints.c >>> @@ -1656,8 +1656,7 @@ prohibited_class_reg_set_mode_p (enum reg_class >>> rclass, >>> { >>> HARD_REG_SET temp; >>> - // ??? Is this assert right >>> - // lra_assert (hard_reg_set_subset_p (set, >>> reg_class_contents[rclass])); >>> + lra_assert (hard_reg_set_subset_p (reg_class_contents[rclass],set)); >> >> Missing space after , >> Otherwise, I'll defer to Vlad for review. >> >> > The patch is ok for me to commit it into the trunk. Thanks, Yvan. The testcase needs the hard float ABI support, and can fail if tested in a way the -march=armv7-a is overridden. This patch patch restrict the test to hard vfp compliant targets. Ok for trunk ? Thanks, Yvan 2015-04-15 Yvan Roux * gcc.target/arm/pr65729.c: Restrict to hard float ABI compliant targets. diff --git a/gcc/testsuite/gcc.target/arm/pr65729.c b/gcc/testsuite/gcc.target/arm/pr65729.c index 0d7e3c1..85383b0 100644 --- a/gcc/testsuite/gcc.target/arm/pr65729.c +++ b/gcc/testsuite/gcc.target/arm/pr65729.c @@ -1,4 +1,5 @@ /* { dg-do compile } */ +/* { dg-require-effective-target arm_hard_vfp_ok } */ /* { dg-options "-O2 -march=armv7-a -mfloat-abi=hard -mfpu=vfpv3-d16" } */ int foo (void)