From patchwork Wed Jan 15 10:04:21 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhenqiang Chen X-Patchwork-Id: 23229 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-pa0-f71.google.com (mail-pa0-f71.google.com [209.85.220.71]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 64D82202FA for ; Wed, 15 Jan 2014 10:04:41 +0000 (UTC) Received: by mail-pa0-f71.google.com with SMTP id kp14sf1936533pab.2 for ; Wed, 15 Jan 2014 02:04:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:mailing-list:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:sender :delivered-to:mime-version:date:message-id:subject:from:to:cc :x-original-sender:x-original-authentication-results:content-type; bh=1YtxiYkPqk8LhRjwvCTikevKEdNfmkm3f/wM8Q+AzUA=; b=L68LO7kCEsIIB57NEEYX7cVqlRNcSGXyGvYGRs2C1bzPG6j84PJ33eFaVZSGfETaVl gx0K1R1swnVTBeD26JXWuBaMAh6FbvbRVuctF98yDezu8JPUxwqy8/giYsgO3bN3PrbH XaVHgpWEV3TkfZ9/AX7VL2YmNZU43CHxcsK213l/HrdIk1wvu3ZjIDQLZpp5DSXNAJ7G 0fRjtnPt9nS+izNrQKIR2L2oP6PgU+rFuohPt9/2l3qRMIN2iLJvoeD3lsZ7Xpyk0jZ+ 0vCaRKNO8Ik3hQ4OPXgOuNS4DqI+m45cgzSC6k+/F1pD7Rye2CrBr7hM3NmmXflfWGUA d7OQ== X-Gm-Message-State: ALoCoQmPmXxNqFIp7lziXGot2lmP1eFq1SQikROYApDPFzBkQBe0YZfR67azJhBfXJ5n3pX0T414 X-Received: by 10.66.163.67 with SMTP id yg3mr471845pab.45.1389780280686; Wed, 15 Jan 2014 02:04:40 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.131.162 with SMTP id on2ls564960qeb.73.gmail; Wed, 15 Jan 2014 02:04:40 -0800 (PST) X-Received: by 10.49.3.7 with SMTP id 7mr2764384qey.60.1389780280538; Wed, 15 Jan 2014 02:04:40 -0800 (PST) Received: from mail-ve0-x22c.google.com (mail-ve0-x22c.google.com [2607:f8b0:400c:c01::22c]) by mx.google.com with ESMTPS id j9si4712624qec.107.2014.01.15.02.04.40 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 15 Jan 2014 02:04:40 -0800 (PST) Received-SPF: neutral (google.com: 2607:f8b0:400c:c01::22c is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=2607:f8b0:400c:c01::22c; Received: by mail-ve0-f172.google.com with SMTP id jw12so327873veb.3 for ; Wed, 15 Jan 2014 02:04:40 -0800 (PST) X-Received: by 10.220.188.70 with SMTP id cz6mr7093vcb.59.1389780280292; Wed, 15 Jan 2014 02:04:40 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.59.13.131 with SMTP id ey3csp261888ved; Wed, 15 Jan 2014 02:04:39 -0800 (PST) X-Received: by 10.68.130.39 with SMTP id ob7mr1563933pbb.63.1389780279310; Wed, 15 Jan 2014 02:04:39 -0800 (PST) Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id j8si3229721pad.149.2014.01.15.02.04.38 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 Jan 2014 02:04:39 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-return-359605-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Received: (qmail 807 invoked by alias); 15 Jan 2014 10:04:27 -0000 Mailing-List: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 798 invoked by uid 89); 15 Jan 2014 10:04:26 -0000 X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.8 required=5.0 tests=AWL, BAYES_00, RCVD_IN_DNSWL_LOW, SEM_URI, SEM_URIRED, SPF_PASS autolearn=no version=3.3.2 X-HELO: mail-lb0-f178.google.com Received: from mail-lb0-f178.google.com (HELO mail-lb0-f178.google.com) (209.85.217.178) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 15 Jan 2014 10:04:25 +0000 Received: by mail-lb0-f178.google.com with SMTP id u14so601403lbd.9 for ; Wed, 15 Jan 2014 02:04:22 -0800 (PST) MIME-Version: 1.0 X-Received: by 10.152.219.133 with SMTP id po5mr959589lac.34.1389780261946; Wed, 15 Jan 2014 02:04:21 -0800 (PST) Received: by 10.112.173.137 with HTTP; Wed, 15 Jan 2014 02:04:21 -0800 (PST) Date: Wed, 15 Jan 2014 18:04:21 +0800 Message-ID: Subject: [PATCH, ARM] ICE when building kernel raid6 neon code From: Zhenqiang Chen To: "gcc-patches@gcc.gnu.org" Cc: Richard Earnshaw , Ramana Radhakrishnan X-Original-Sender: zhenqiang.chen@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 2607:f8b0:400c:c01::22c is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org; dkim=pass header.i=@gcc.gnu.org X-Google-Group-Id: 836684582541 Hi, The patch fixes ICE when building kernel raid6 neon code. lib/raid6/neon4.c: In function 'raid6_ neon4_gen_syndrome_real': lib/raid6/neon4.c:113:1: internal compiler error: in dwarf2out_frame_debug_adjust_cfa, at dwarf2cfi.c:1090 } https://bugs.launchpad.net/gcc-linaro/+bug/1268893 Root cause: When expanding epilogue, REG_CFA_ADJUST_CFA NOTE is added to handle dwarf info issue for shrink-wrap. But for TARGET_APCS_FRAME, shrink-wrap is disabled. And not all dwarf info in arm_expand_epilogue_apcs_frame are correctly updated. arm_emit_vfp_multi_reg_pop is called by both arm_expand_epilogue_apcs_frame and arm_expand_epilogue. So we should not add the NOTE in arm_emit_vfp_multi_reg_pop if shrink-wrap is not enabled. Boot strap and no make check regression on ARM Chromebook. OK for trunk? Thanks! -Zhenqiang ChangeLog: 2014-01-15 Zhenqiang Chen * config/arm/arm.c (arm_emit_vfp_multi_reg_pop): Do not add REG_CFA_ADJUST_CFA NOTE if shrink-wrap is not enabled. /* Generate and emit a pattern that will be recognized as LDRD pattern. If even diff --git a/gcc/config/arm/arm.c b/gcc/config/arm/arm.c index 18196b3..1ccb796 100644 --- a/gcc/config/arm/arm.c +++ b/gcc/config/arm/arm.c @@ -19890,8 +19890,12 @@ arm_emit_vfp_multi_reg_pop (int first_reg, int num_regs, rtx base_reg) par = emit_insn (par); REG_NOTES (par) = dwarf; - arm_add_cfa_adjust_cfa_note (par, 2 * UNITS_PER_WORD * num_regs, - base_reg, base_reg); + /* REG_CFA_ADJUST_CFA NOTE is added to handle dwarf info issue when + shrink-wrap is enabled. So when shrink-wrap is not enabled, we should + not add the note. */ + if (flag_shrink_wrap) + arm_add_cfa_adjust_cfa_note (par, 2 * UNITS_PER_WORD * num_regs, + base_reg, base_reg); }