From patchwork Mon May 18 03:42:18 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jim Wilson X-Patchwork-Id: 48667 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wi0-f199.google.com (mail-wi0-f199.google.com [209.85.212.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id E2C3321411 for ; Mon, 18 May 2015 03:42:40 +0000 (UTC) Received: by wivs14 with SMTP id s14sf17680910wiv.1 for ; Sun, 17 May 2015 20:42:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:mailing-list:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:sender :delivered-to:mime-version:date:message-id:subject:from:to :content-type:x-original-sender:x-original-authentication-results; bh=/ToezGHGpjbR0CO5EG2cQVAU3vjXW+F3nuPU0lG8T5g=; b=KleFHkIWG6GLgyCEv77NfiW9Mz3Cr2njGPQciyrupdrWCIW6WoqMf61PwIogU/9sLb Ehaf7gxLL21HsyYK9jw27UACzmlD7Mu9HwJBBCE4jH56sEHqmtJvIJEEvbINRHTvgY/1 mv+B+/GRlAZp9pmFWzKvsHg+hriSAOAxN0GzB+bFg0vU2MceG0+YdRzF6F8tJSFm345G 1d1vUVc4hEZ8egtlJyytw2TqLRh68O9j/H7XU6Sv7RD211YuvPbrJxjLwEFvZl95BY+X UEwB7HYUV74gjcOWm0WHiT4FBsDAmpaoOjOGkX4WuPfiDoBc0yCtG5pkUGgmTpJqFZFB QMJg== X-Gm-Message-State: ALoCoQkDRMMOl5ZSUFD7IARx/fWSLZbU4hTZrtMrXu+sReze5QX1mvYtCuJxFJ/Iju05yu6bUKqN X-Received: by 10.180.10.136 with SMTP id i8mr8356183wib.7.1431920560150; Sun, 17 May 2015 20:42:40 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.44.135 with SMTP id e7ls772862lam.79.gmail; Sun, 17 May 2015 20:42:39 -0700 (PDT) X-Received: by 10.112.242.40 with SMTP id wn8mr7427827lbc.57.1431920559956; Sun, 17 May 2015 20:42:39 -0700 (PDT) Received: from mail-la0-x234.google.com (mail-la0-x234.google.com. [2a00:1450:4010:c03::234]) by mx.google.com with ESMTPS id lk9si719277lac.33.2015.05.17.20.42.39 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 17 May 2015 20:42:39 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 2a00:1450:4010:c03::234 as permitted sender) client-ip=2a00:1450:4010:c03::234; Received: by lagr1 with SMTP id r1so118554814lag.0 for ; Sun, 17 May 2015 20:42:39 -0700 (PDT) X-Received: by 10.112.204.72 with SMTP id kw8mr15795007lbc.88.1431920559575; Sun, 17 May 2015 20:42:39 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.108.230 with SMTP id hn6csp3675814lbb; Sun, 17 May 2015 20:42:38 -0700 (PDT) X-Received: by 10.68.94.37 with SMTP id cz5mr40272927pbb.70.1431920557524; Sun, 17 May 2015 20:42:37 -0700 (PDT) Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id nt1si13975222pdb.23.2015.05.17.20.42.36 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 17 May 2015 20:42:37 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-return-398087-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Received: (qmail 47200 invoked by alias); 18 May 2015 03:42:23 -0000 Mailing-List: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 47191 invoked by uid 89); 18 May 2015 03:42:22 -0000 X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL, BAYES_00, KAM_ASCII_DIVIDERS, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=no version=3.3.2 X-HELO: mail-qg0-f46.google.com Received: from mail-qg0-f46.google.com (HELO mail-qg0-f46.google.com) (209.85.192.46) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 18 May 2015 03:42:21 +0000 Received: by qgfa7 with SMTP id a7so29564993qgf.1 for ; Sun, 17 May 2015 20:42:19 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.229.174.202 with SMTP id u10mr27683211qcz.4.1431920538847; Sun, 17 May 2015 20:42:18 -0700 (PDT) Received: by 10.140.104.171 with HTTP; Sun, 17 May 2015 20:42:18 -0700 (PDT) Date: Sun, 17 May 2015 20:42:18 -0700 Message-ID: Subject: [PATCH] move check-gcc parallelize value into C front end From: Jim Wilson To: "gcc-patches@gcc.gnu.org" X-Original-Sender: jim.wilson@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 2a00:1450:4010:c03::234 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org; dkim=pass header.i=@gcc.gnu.org X-Google-Group-Id: 836684582541 Every check_$lang_parallelize setting is in the language specific Make-lang.in file except for the C front-end check_gcc_parallelize setting which is in the toplevel Makefile.in file. This seems to be an oversight, as it was only 3 years ago that the c/ subdir was created, and the check_gcc_parallelize variable looks like it might be gcc generic, but it is actually C front end specific as it only affect check-gcc which is a C front end target. This patch moves the variable into the C front end where it belongs. This also consolidates the change_$lang_parallelize docs, which are currently spread across two places. It also needs to fix two places that directly refer to the check_gcc_parallelize setting in Makefile.in, and change them to references to the generic docs. Also, while looking at this, I noticed that there is no check_gnat_parallelize set, and check-gnat seems to be the only testsuite target that hasn't already been parallelized. This also looks like an oversight, but I haven't tested a patch for that yet. Jim gcc/ 2015-05-17 Jim Wilson * Makefile.in (check_gcc_parallelize): Delete. (lang_checks_parallelized): Update comment. gcc/c 2015-05-17 Jim Wilson * Make-lang.in (check_gcc_pallelize): Define. gcc/cp 2015-05-17 Jim Wilson * Make-lang.in (check_g++_parallelize): Update comment. gcc/fortran 2015-05-17 Jim Wilson * Make-lang.in (check_gfortran_parallelize): Update comment. Index: gcc/Makefile.in =================================================================== --- gcc/Makefile.in (revision 223208) +++ gcc/Makefile.in (working copy) @@ -528,10 +528,6 @@ xm_defines=@xm_defines@ lang_checks= lang_checks_parallelized= -# Upper limit to which it is useful to parallelize this lang target. -# It doesn't make sense to try e.g. 128 goals for small testsuites -# like objc or go. -check_gcc_parallelize=10000 lang_opt_files=@lang_opt_files@ $(srcdir)/c-family/c.opt $(srcdir)/common.opt lang_specs_files=@lang_specs_files@ lang_tree_files=@lang_tree_files@ @@ -3743,7 +3739,9 @@ # # To parallelize some language check, add the corresponding check-$lang # to lang_checks_parallelized variable and define check_$lang_parallelize -# variable (see above check_gcc_parallelize description). +# variable. This is the upper limit to which it is useful to parallelize the +# check-$lang target. It doesn't make sense to try e.g. 128 goals for small +# testsuites like objc or go. $(lang_checks_parallelized): check-% : site.exp -rm -rf $(TESTSUITEDIR)/$*-parallel @if [ "$(filter -j, $(MFLAGS))" = "-j" ]; then \ Index: gcc/c/Make-lang.in =================================================================== --- gcc/c/Make-lang.in (revision 223208) +++ gcc/c/Make-lang.in (working copy) @@ -95,6 +95,8 @@ # List of targets that can use the generic check- rule and its // variant. lang_checks += check-gcc lang_checks_parallelized += check-gcc +# For description see the check_$lang_parallelize comment in gcc/Makefile.in. +check_gcc_parallelize=10000 # 'make check' in gcc/ looks for check-c. Redirect it to check-gcc. check-c : check-gcc Index: gcc/cp/Make-lang.in =================================================================== --- gcc/cp/Make-lang.in (revision 223208) +++ gcc/cp/Make-lang.in (working copy) @@ -155,7 +155,7 @@ # List of targets that can use the generic check- rule and its // variant. lang_checks += check-g++ lang_checks_parallelized += check-g++ -# For description see comment above check_gcc_parallelize in gcc/Makefile.in. +# For description see the check_$lang_parallelize comment in gcc/Makefile.in. check_g++_parallelize = 10000 # # Install hooks: Index: gcc/fortran/Make-lang.in =================================================================== --- gcc/fortran/Make-lang.in (revision 223208) +++ gcc/fortran/Make-lang.in (working copy) @@ -167,7 +167,7 @@ check-fortran-subtargets : check-gfortran-subtargets lang_checks += check-gfortran lang_checks_parallelized += check-gfortran -# For description see comment above check_gcc_parallelize in gcc/Makefile.in. +# For description see the check_$lang_parallelize comment in gcc/Makefile.in. check_gfortran_parallelize = 10000 # GFORTRAN documentation.