From patchwork Tue Nov 1 14:47:54 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Martin_Li=C5=A1ka?= X-Patchwork-Id: 80370 Delivered-To: patch@linaro.org Received: by 10.80.142.83 with SMTP id 19csp687507edx; Tue, 1 Nov 2016 07:48:48 -0700 (PDT) X-Received: by 10.98.55.67 with SMTP id e64mr60102309pfa.80.1478011727942; Tue, 01 Nov 2016 07:48:47 -0700 (PDT) Return-Path: Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id h24si15108445pfk.250.2016.11.01.07.48.47 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Nov 2016 07:48:47 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-return-440042-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org; spf=pass (google.com: domain of gcc-patches-return-440042-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) smtp.mailfrom=gcc-patches-return-440042-patch=linaro.org@gcc.gnu.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :subject:to:references:cc:from:message-id:date:mime-version :in-reply-to:content-type; q=dns; s=default; b=qmMLTYwuXmheHqj+I ox5FyhflvoVubEwVkAxa5/XPuR8VWn9qXH8xQN6RlZyqz3amz+BSk6mrb8rdEfaY eD3W0Bkoxnu8Asix867Kpb1lUY2KrBGxYlfvBh33rx6NwUe4AvQnLbG5bralnd+h g5oU0ImjerzlviWWUq1pJ9P/OI= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender :subject:to:references:cc:from:message-id:date:mime-version :in-reply-to:content-type; s=default; bh=ANRHwm1FD+p9pJ+wCs0CoOU fR1k=; b=KPQzXU+T+dJ5HljFsvwVWV7cDTE2ZGwspwEM5Ib/pr/O9qV4WDqqKjX kEWAxSgBmU32bRqoa7TDRFqymsSEqqpu9E6MyL8uL0dWVOt+rIjkzxayFduNdgX/ mL98TU8CAT8rIZeABnEv9nSPzgCu58vqgroIGmZw+fYt2vYV6yiA= Received: (qmail 19914 invoked by alias); 1 Nov 2016 14:48:28 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 6293 invoked by uid 89); 1 Nov 2016 14:48:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00, SPF_PASS autolearn=ham version=3.3.2 spammy=420, 6, 4206 X-HELO: mx2.suse.de Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 01 Nov 2016 14:47:56 +0000 Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 82B5EAB9B; Tue, 1 Nov 2016 14:47:54 +0000 (UTC) Subject: Re: [PATCH, RFC] Introduce -fsanitize=use-after-scope (v2) To: Jakub Jelinek References: <20160506122225.GH26501@tucnak.zalov.cz> <57332B69.4040001@suse.cz> <20160512104156.GY28550@tucnak.redhat.com> <57348F45.5020700@suse.cz> <20160818133609.GN14857@tucnak.redhat.com> <98f408c5-7e1e-6fd8-e589-34f8de2f4455@suse.cz> <20161007111347.GF7282@tucnak.redhat.com> <20161021142617.GG7282@tucnak.redhat.com> <3a109250-0440-7438-8e1f-7e5c6d8b6580@suse.cz> <20161027172358.GN3541@tucnak.redhat.com> Cc: GCC Patches From: =?UTF-8?Q?Martin_Li=c5=a1ka?= Message-ID: <782727c2-9173-24ab-4e4c-07918dc16bf6@suse.cz> Date: Tue, 1 Nov 2016 15:47:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161027172358.GN3541@tucnak.redhat.com> X-IsSubscribed: yes On 10/27/2016 07:23 PM, Jakub Jelinek wrote: > Ok for trunk with that change. > > Jakub Hello. I'll commit the patch as soon as following patch would be accepted. The patch fixes false positives when running asan-bootstrap. Patch can bootstrap on ppc64le-redhat-linux and survives regression tests. Ready to be installed? Martin >From b62e4d7ffe659ec338ef83e84ccb572a07264283 Mon Sep 17 00:00:00 2001 From: marxin Date: Tue, 20 Sep 2016 10:31:25 +0200 Subject: [PATCH 1/4] Fix ASAN bootstrap uninitialized warning. gcc/ChangeLog: 2016-09-26 Martin Liska * ipa-devirt.c (record_targets_from_bases): Initialize a variable. * omp-low.c (lower_omp_target): Remove a variable from scope defined by a switch statement. * tree-dump.c (dequeue_and_dump): Likewise. gcc/java/ChangeLog: 2016-09-26 Martin Liska * mangle.c (mangle_type): Remove a variable from scope defined by a switch statement. --- gcc/ipa-devirt.c | 2 +- gcc/omp-low.c | 11 ++++------- gcc/tree-dump.c | 8 +++----- 3 files changed, 8 insertions(+), 13 deletions(-) diff --git a/gcc/ipa-devirt.c b/gcc/ipa-devirt.c index 49e2195..5c0ae72 100644 --- a/gcc/ipa-devirt.c +++ b/gcc/ipa-devirt.c @@ -2862,7 +2862,7 @@ record_targets_from_bases (tree otr_type, { while (true) { - HOST_WIDE_INT pos, size; + HOST_WIDE_INT pos = 0, size; tree base_binfo; tree fld; diff --git a/gcc/omp-low.c b/gcc/omp-low.c index e5b9e4c..62c9e5c 100644 --- a/gcc/omp-low.c +++ b/gcc/omp-low.c @@ -15803,11 +15803,10 @@ lower_omp_target (gimple_stmt_iterator *gsi_p, omp_context *ctx) push_gimplify_context (); fplist = NULL; + tree var, x; for (c = clauses; c ; c = OMP_CLAUSE_CHAIN (c)) switch (OMP_CLAUSE_CODE (c)) { - tree var, x; - default: break; case OMP_CLAUSE_MAP: @@ -16066,12 +16065,11 @@ lower_omp_target (gimple_stmt_iterator *gsi_p, omp_context *ctx) vec_alloc (vkind, map_cnt); unsigned int map_idx = 0; + tree ovar, nc, s, purpose, var, x, type; + unsigned int talign; for (c = clauses; c ; c = OMP_CLAUSE_CHAIN (c)) switch (OMP_CLAUSE_CODE (c)) { - tree ovar, nc, s, purpose, var, x, type; - unsigned int talign; - default: break; @@ -16442,10 +16440,10 @@ lower_omp_target (gimple_stmt_iterator *gsi_p, omp_context *ctx) if (offloaded || data_region) { tree prev = NULL_TREE; + tree var, x; for (c = clauses; c ; c = OMP_CLAUSE_CHAIN (c)) switch (OMP_CLAUSE_CODE (c)) { - tree var, x; default: break; case OMP_CLAUSE_FIRSTPRIVATE: @@ -16594,7 +16592,6 @@ lower_omp_target (gimple_stmt_iterator *gsi_p, omp_context *ctx) for (c = clauses; c; c = OMP_CLAUSE_CHAIN (c)) switch (OMP_CLAUSE_CODE (c)) { - tree var; default: break; case OMP_CLAUSE_MAP: diff --git a/gcc/tree-dump.c b/gcc/tree-dump.c index df47181..89f72a0 100644 --- a/gcc/tree-dump.c +++ b/gcc/tree-dump.c @@ -420,8 +420,6 @@ dequeue_and_dump (dump_info_p di) /* Now handle the various kinds of nodes. */ switch (code) { - int i; - case IDENTIFIER_NODE: dump_string_field (di, "strg", IDENTIFIER_POINTER (t)); dump_int (di, "lngt", IDENTIFIER_LENGTH (t)); @@ -435,6 +433,7 @@ dequeue_and_dump (dump_info_p di) case STATEMENT_LIST: { + int i; tree_stmt_iterator it; for (i = 0, it = tsi_start (t); !tsi_end_p (it); tsi_next (&it), i++) { @@ -447,7 +446,7 @@ dequeue_and_dump (dump_info_p di) case TREE_VEC: dump_int (di, "lngt", TREE_VEC_LENGTH (t)); - for (i = 0; i < TREE_VEC_LENGTH (t); ++i) + for (int i = 0; i < TREE_VEC_LENGTH (t); ++i) { char buffer[32]; sprintf (buffer, "%u", i); @@ -707,9 +706,8 @@ dequeue_and_dump (dump_info_p di) break; case OMP_CLAUSE: { - int i; fprintf (di->stream, "%s\n", omp_clause_code_name[OMP_CLAUSE_CODE (t)]); - for (i = 0; i < omp_clause_num_ops[OMP_CLAUSE_CODE (t)]; i++) + for (int i = 0; i < omp_clause_num_ops[OMP_CLAUSE_CODE (t)]; i++) dump_child ("op: ", OMP_CLAUSE_OPERAND (t, i)); } break; -- 2.10.1