From patchwork Tue Dec 13 21:51:47 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Fran=C3=A7ois_Dumont?= X-Patchwork-Id: 87945 Delivered-To: patch@linaro.org Received: by 10.140.20.101 with SMTP id 92csp2440102qgi; Tue, 13 Dec 2016 13:52:17 -0800 (PST) X-Received: by 10.84.160.204 with SMTP id v12mr159025797plg.122.1481665937818; Tue, 13 Dec 2016 13:52:17 -0800 (PST) Return-Path: Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id 90si49521789pla.135.2016.12.13.13.52.17 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Dec 2016 13:52:17 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-return-444338-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org; spf=pass (google.com: domain of gcc-patches-return-444338-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) smtp.mailfrom=gcc-patches-return-444338-patch=linaro.org@gcc.gnu.org; dmarc=fail (p=NONE dis=NONE) header.from=gmail.com DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to:cc :from:subject:message-id:date:mime-version:content-type; q=dns; s=default; b=AW8kOg4WtsqMBtcc+i/ycxJDEhcQwNM80+6PHyMGOFb6q0ck9W GAAVYdGqp0kjNy6JB127cw5lBjvMWpXoAGE6VLuP7QfZ5wSOTYQMnqyvPpp/18gv 0/xWl/63wiwrhKbKiPw6DYbpRv33L9sEzfw0KIq6FFJv0M0b+9NdQyH40= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to:cc :from:subject:message-id:date:mime-version:content-type; s= default; bh=U8SLpN/+QtuF8gANerNJR6uAJT4=; b=XXvWGLutnpBaY/M/1bpI djDWxmrVnlXzYzlcgeW1o3oYQKLeTkeihSaliVyybLfGMcIOE0My1wv/qfr/a3q/ fL7C+dRXZbGPwYn5H6Y6XFn+6oyqiLkXqViE90lMnaEZgAMo6eT9MBbENELnqDrm JQCB3BBubj3psLl0C5G+adI= Received: (qmail 116149 invoked by alias); 13 Dec 2016 21:51:53 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 116127 invoked by uid 89); 13 Dec 2016 21:51:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=hesitate X-Spam-User: qpsmtpd, 2 recipients X-HELO: mail-wj0-f179.google.com Received: from mail-wj0-f179.google.com (HELO mail-wj0-f179.google.com) (209.85.210.179) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 13 Dec 2016 21:51:51 +0000 Received: by mail-wj0-f179.google.com with SMTP id tk12so495691wjb.3; Tue, 13 Dec 2016 13:51:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:to:cc:from:subject:message-id:date:user-agent :mime-version; bh=i5t8xHFznQL2sIkSEHDRXtTIGS8og6J+jiVyNz3j8sY=; b=P7kmG6sG5/bnSrsrm977u7FieFp/rUwMZ0l771+FVZPy1zfJgeyxMHquzoM42Nw9TR rgo9s9rFzzXYKv6bb4qSpn9h8Wm0PERg+qsLOlVeX7VepNUIhMI6OU73RDsVDyaDfAwL q6tbR2U+d87el+T5/BXCdNLng0na5OOlQ1dvumWlqaafTuBA/b6nVn2WUm46nZUHVjqY YowiYsux1F/gVtvIqadqev1d2R2Zbu1z7DumNIUsU+FyHdIuonx9nrJvblfe8O7AKl2G kL3P4dKQBQhJ0wpINykLkbZicvZ30f9e5al4wK2LbgPtkaNLgnOPZN9XslywBqmDDbqw sV6w== X-Gm-Message-State: AKaTC01Dz19Qz6unN+eIYeYFx+7M2QiXFitn0zxDXEjFUAHHJ3T5dNjE8lNqcF9vCz2IBg== X-Received: by 10.28.5.193 with SMTP id 184mr4731436wmf.89.1481665909813; Tue, 13 Dec 2016 13:51:49 -0800 (PST) Received: from [192.168.0.23] (arf62-1-82-237-250-248.fbx.proxad.net. [82.237.250.248]) by smtp.googlemail.com with ESMTPSA id i15sm64083392wjs.16.2016.12.13.13.51.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Dec 2016 13:51:48 -0800 (PST) To: "libstdc++@gcc.gnu.org" , gcc-patches Cc: Christophe MONAT From: =?UTF-8?Q?Fran=c3=a7ois_Dumont?= Subject: _Rb_tree regression Message-ID: <6b9e0075-8e40-e47b-9f63-7f79722e5a17@gmail.com> Date: Tue, 13 Dec 2016 22:51:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 Hi I have been reported privately by Christophe in copy a regression resulting from my recent changes to _Rb_tree. I removed a constructor still necessary in C++03 mode or before. Tests would have shown it if I had run them in C++03. * include/bits/stl_tree.h (_Rb_tree_impl(const _Key_compare&, const _Node_allocator&): Restore before C++11 mode. I prefer to restore it only before C++11 while it used to be available in any mode. It is only call with rvalue references. Don't hesitate to commit it yourself if you prefer to fix it quickly otherwise I'll do it after validation in about 24 hours. François diff --git a/libstdc++-v3/include/bits/stl_tree.h b/libstdc++-v3/include/bits/stl_tree.h index 1bfbfa7..cb2c116 100644 --- a/libstdc++-v3/include/bits/stl_tree.h +++ b/libstdc++-v3/include/bits/stl_tree.h @@ -692,7 +692,11 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION , _Base_key_compare(__x._M_key_compare) { } -#if __cplusplus >= 201103L +#if __cplusplus < 201103L + _Rb_tree_impl(const _Key_compare& __comp, const _Node_allocator& __a) + : _Node_allocator(__a), _Base_key_compare(__comp) + { } +#else _Rb_tree_impl(_Rb_tree_impl&&) = default; _Rb_tree_impl(const _Key_compare& __comp, _Node_allocator&& __a) : _Node_allocator(std::move(__a)), _Base_key_compare(__comp)