From patchwork Fri Sep 18 08:40:35 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kyrylo Tkachov X-Patchwork-Id: 53859 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-lb0-f200.google.com (mail-lb0-f200.google.com [209.85.217.200]) by patches.linaro.org (Postfix) with ESMTPS id 0CBE6218E3 for ; Fri, 18 Sep 2015 08:40:57 +0000 (UTC) Received: by lbbti1 with SMTP id ti1sf14506507lbb.3 for ; Fri, 18 Sep 2015 01:40:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:mailing-list:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:sender :delivered-to:message-id:date:from:user-agent:mime-version:to:cc :subject:references:in-reply-to:content-type :content-transfer-encoding:x-original-sender :x-original-authentication-results; bh=axCPUixGNOWLCQJHf2spt7NP9OJeB0ptHel/X/i2F3Q=; b=ST3w9Bu4M8pM/K2gzzCRBtALnydKwU8qOgfo81+ee8ttTlXhWsO9JTRDgQ1KTykvmz pg8O12Y/iO0NhYIwuHZYSg8Ebyz989Ac5m37RPxiwrXc6uKuRp8JQ7XsZVrLSl4o7dRf rrr5leWTFBg8GsPKZRf8Kb9/N01/rWpxNXjk0lkdMnYx5M0r8nJZ4i9XZlaJxw4dIWvJ J+L6XhImCLkj8eM77eiojbbKQdP/qH2ZGbXZqqkQGUA7TkTmexghGrntwttO3BYgBton SuIUhdUbhB2vAK2PqQLv42dyhCOoZ5ijUACpukvBuWBMV+NdZA16L1hAznVgtF8B1nAa t4vA== X-Gm-Message-State: ALoCoQl6FWwQ8rNROkvvbT4/Y/S1fLeD6O1wB+JQ5V8B3Pn/AAME4xmvIFZqIcNBD7B9f0AUqnPV X-Received: by 10.112.198.33 with SMTP id iz1mr649935lbc.8.1442565656068; Fri, 18 Sep 2015 01:40:56 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.8.164 with SMTP id s4ls201573laa.63.gmail; Fri, 18 Sep 2015 01:40:55 -0700 (PDT) X-Received: by 10.112.164.35 with SMTP id yn3mr2612330lbb.18.1442565655933; Fri, 18 Sep 2015 01:40:55 -0700 (PDT) Received: from mail-la0-x22f.google.com (mail-la0-x22f.google.com. [2a00:1450:4010:c03::22f]) by mx.google.com with ESMTPS id pd10si5047333lbc.109.2015.09.18.01.40.55 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 18 Sep 2015 01:40:55 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 2a00:1450:4010:c03::22f as permitted sender) client-ip=2a00:1450:4010:c03::22f; Received: by lanb10 with SMTP id b10so26123415lan.3 for ; Fri, 18 Sep 2015 01:40:55 -0700 (PDT) X-Received: by 10.152.161.232 with SMTP id xv8mr2668729lab.32.1442565655811; Fri, 18 Sep 2015 01:40:55 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.59.35 with SMTP id w3csp151323lbq; Fri, 18 Sep 2015 01:40:54 -0700 (PDT) X-Received: by 10.69.19.202 with SMTP id gw10mr5990387pbd.60.1442565654568; Fri, 18 Sep 2015 01:40:54 -0700 (PDT) Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id wk4si11797101pbc.224.2015.09.18.01.40.54 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 18 Sep 2015 01:40:54 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-return-407753-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Received: (qmail 116718 invoked by alias); 18 Sep 2015 08:40:43 -0000 Mailing-List: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 116701 invoked by uid 89); 18 Sep 2015 08:40:42 -0000 X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL, BAYES_00, SPF_PASS autolearn=ham version=3.3.2 X-HELO: eu-smtp-delivery-143.mimecast.com Received: from eu-smtp-delivery-143.mimecast.com (HELO eu-smtp-delivery-143.mimecast.com) (207.82.80.143) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 18 Sep 2015 08:40:41 +0000 Received: from cam-owa2.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) by eu-smtp-1.mimecast.com with ESMTP id uk-mta-28-wYLWF0apSPm3xiaXTfctHg-1; Fri, 18 Sep 2015 09:40:36 +0100 Received: from [10.2.207.50] ([10.1.2.79]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Fri, 18 Sep 2015 09:40:35 +0100 Message-ID: <55FBCE03.4060004@arm.com> Date: Fri, 18 Sep 2015 09:40:35 +0100 From: Kyrill Tkachov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Christian Bruel , Ramana Radhakrishnan CC: "gcc-patches@gcc.gnu.org" Subject: Re: [PATCH 3/4] [ARM] Add attribute/pragma target fpu= References: <55F6AE3F.7050104@st.com> In-Reply-To: <55F6AE3F.7050104@st.com> X-MC-Unique: wYLWF0apSPm3xiaXTfctHg-1 X-IsSubscribed: yes X-Original-Sender: kyrylo.tkachov@arm.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 2a00:1450:4010:c03::22f as permitted sender) smtp.mailfrom=patch+caf_=patchwork-forward=linaro.org@linaro.org; dkim=pass header.i=@gcc.gnu.org X-Google-Group-Id: 836684582541 Hi Christian, (going through the patches...) On 14/09/15 12:39, Christian Bruel wrote: > This patch splits the neon_builtins initialization into 2 internals > functions. One for NEON and one for CRYPTO, each one guarded by its own > predicate. arm_init_neon_builtins is now global to be called from > arm_valid_target_attribute_tree if needed. > I don't see its relevance in this patch, and it's not mentioned in the ChangeLog. Kyrill diff -ruN gnu_trunk.p2/gcc/gcc/config/arm/arm-protos.h gnu_trunk.p3/gcc/gcc/config/arm/arm-protos.h --- gnu_trunk.p2/gcc/gcc/config/arm/arm-protos.h 2015-09-11 15:23:51.852687891 +0200 +++ gnu_trunk.p3/gcc/gcc/config/arm/arm-protos.h 2015-09-11 16:30:15.833511559 +0200 @@ -213,7 +213,10 @@ extern bool arm_change_mode_p (tree); #endif -extern tree arm_valid_target_attribute_tree (tree, struct gcc_options *, +extern void arm_init_neon_builtins (void); + +extern tree arm_valid_target_attribute_tree (tree, + struct gcc_options *, struct gcc_options *); Why the arm_valid_target_attribute_tree declaration here?