From patchwork Wed May 23 03:39:10 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Hope X-Patchwork-Id: 8893 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 7247223F0A for ; Wed, 23 May 2012 03:39:20 +0000 (UTC) Received: from mail-ob0-f180.google.com (mail-ob0-f180.google.com [209.85.214.180]) by fiordland.canonical.com (Postfix) with ESMTP id 081DCA18DD9 for ; Wed, 23 May 2012 03:39:19 +0000 (UTC) Received: by obbun3 with SMTP id un3so13651240obb.11 for ; Tue, 22 May 2012 20:39:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:message-id :date:from:user-agent:mime-version:to:cc:subject:references :in-reply-to:content-type:content-transfer-encoding :x-gm-message-state; bh=w0VMUWey2BXVWRM1xNaHpaM/UNw+008Y7uy++iHWy6w=; b=QFr98fMWdp3jIA+5n2yq9xDZlc6gOjgwJduZGP3QLkMxvtpodafURZPcEZ+UWnIjmt QclOTWQ6AhlyFbjIKZn9AVCNEuZRp7VRIfFHCrY81Q3GKEekdwSOZScowdJy6cjWPWDC VEHrOeFUIHofZ9L8szZmAXiXP3Akj/5Qk0eYgMad1SwA5Yt73JAmTqqAAMntxeWOLpht SO5DAJXu1QFeCYn2nCXWkwQN9bNwiUh+yLx1z6tTlaiI78mtRYM8Bfzkl6BGZEQykD1r sX4XKikeOIhqhpJJqYWqLBqw4RaadzpSuDTIDDe9GdiVdsrp1SlyVfob6mFKbFWsEB2P o6iA== Received: by 10.50.46.232 with SMTP id y8mr11070877igm.57.1337744359053; Tue, 22 May 2012 20:39:19 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.231.35.72 with SMTP id o8csp411857ibd; Tue, 22 May 2012 20:39:17 -0700 (PDT) Received: by 10.236.76.165 with SMTP id b25mr3866578yhe.0.1337744357018; Tue, 22 May 2012 20:39:17 -0700 (PDT) Received: from mail-gh0-f178.google.com (mail-gh0-f178.google.com [209.85.160.178]) by mx.google.com with ESMTPS id z10si21404447yhn.96.2012.05.22.20.39.16 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 22 May 2012 20:39:17 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.160.178 is neither permitted nor denied by best guess record for domain of michael.hope@linaro.org) client-ip=209.85.160.178; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.160.178 is neither permitted nor denied by best guess record for domain of michael.hope@linaro.org) smtp.mail=michael.hope@linaro.org Received: by ghbf1 with SMTP id f1so1313913ghb.37 for ; Tue, 22 May 2012 20:39:16 -0700 (PDT) Received: by 10.50.196.201 with SMTP id io9mr11325711igc.58.1337744356436; Tue, 22 May 2012 20:39:16 -0700 (PDT) Received: from [192.168.1.35] (204.47.255.123.static.snap.net.nz. [123.255.47.204]) by mx.google.com with ESMTPS id ut8sm11833601igc.8.2012.05.22.20.39.13 (version=SSLv3 cipher=OTHER); Tue, 22 May 2012 20:39:15 -0700 (PDT) Message-ID: <4FBC5BDE.6020304@linaro.org> Date: Wed, 23 May 2012 15:39:10 +1200 From: Michael Hope User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Paolo Carlini CC: gcc-patches@gcc.gnu.org, patches@linaro.org Subject: Re: [PATCH, 4.6] Fix PR53170: missing target c++11 selector References: <4FB9822B.9080805@linaro.org> <4FBA0768.6000009@oracle.com> In-Reply-To: <4FBA0768.6000009@oracle.com> X-Gm-Message-State: ALoCoQkXi/6zcN5EzUfB1bLYxFUPLpzN6Tp+K+M3CiVNS3OPralxly7qYEM5hO0/3krND/5U2awP On 21/05/12 21:14, Paolo Carlini wrote: > On 05/21/2012 01:45 AM, Michael Hope wrote: >> The testsuite for PR52796 uses the 'target c++11' selector which doesn't exist in 4.6. >> This patch backports the selector, clearing the 'ERROR: g++.dg/cpp0x/variadic-value1.C: >> syntax error in target selector "target c++11" for " dg-do 2 run { target c++11 } "' >> errors which have appeared in recent 4.6 builds. >> >> Tested on x86_64-linux-gnu with no regressions. Changes the ERROR to UNSUPPORTED. >> >> OK for 4.6? > To be honest, when I saw the issue I thought we wanted simply to not use the target selector at all in the branch and simply add a // { dg-options "-std=c++11" } I thought somebody would commit the change as obvious ;) Sure. The version below changes the selector for explicit flags that match those passed by trunk. OK for 4.6? -- Michael (who's not keen enough to commit as obvious) 2012-05-23 Michael Hope PR PR52796 * g++.dg/cpp0x/variadic-value1.C: Change selector for explicit options. diff --git a/gcc/testsuite/g++.dg/cpp0x/variadic-value1.C b/gcc/testsuite/g++.dg/cpp0x/variadic-value1.C index 179919a..301bd54 100644 --- a/gcc/testsuite/g++.dg/cpp0x/variadic-value1.C +++ b/gcc/testsuite/g++.dg/cpp0x/variadic-value1.C @@ -1,5 +1,5 @@ // PR c++/52796 -// { dg-do run { target c++11 } } +// { dg-options "-std=c++0x -pedantic-errors" } inline void *operator new(__SIZE_TYPE__ s, void *p) { return p; }