From patchwork Thu Dec 1 10:12:46 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Georg-Johann Lay X-Patchwork-Id: 85999 Delivered-To: patch@linaro.org Received: by 10.140.20.101 with SMTP id 92csp618716qgi; Thu, 1 Dec 2016 02:13:20 -0800 (PST) X-Received: by 10.84.216.8 with SMTP id m8mr82679860pli.116.1480587200389; Thu, 01 Dec 2016 02:13:20 -0800 (PST) Return-Path: Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id t1si60397252pge.38.2016.12.01.02.13.20 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 01 Dec 2016 02:13:20 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-return-443170-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org; spf=pass (google.com: domain of gcc-patches-return-443170-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) smtp.mailfrom=gcc-patches-return-443170-patch=linaro.org@gcc.gnu.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to:cc :from:subject:message-id:date:mime-version:content-type; q=dns; s=default; b=nCpGR2f0VuKgNMNq5/ktVfvGgOYj1X0oXL0NmWKAVzng2umyQE nrwOodTUhERjlqTU1hV8HRkExk8Duv47Y4az2+H6MYsfC4dsRpvGAI8g0iTfdnqs 6UUl8QwlaUDG6dIqw5eVqw2DxokuAvazdQv3a1iheaheFEFrZZntd/xlk= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to:cc :from:subject:message-id:date:mime-version:content-type; s= default; bh=T35QLX0XQq+l0FoL1NF+z/CExQY=; b=J43xDDIfXn0S8Z1A7wvD 3UhTHxSI6m1s4eMvG+SCzSRwV3a90rTjcplBByHAiaJeXBlZxMMJzJ1R8tCCibQ3 m1t01oKxmwoV/PbOKGhvk9ozZcyPiVnAufIzw5yFhblVpH48djJ+r8B4N97eGOFe WgcQ+L9O3Fya7UfN9ShQnvs= Received: (qmail 55443 invoked by alias); 1 Dec 2016 10:13:01 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 54028 invoked by uid 89); 1 Dec 2016 10:13:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL, BAYES_00, KAM_STOCKGEN, RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2 spammy=UD:avr.c, avr.c, avr_arch, avrc X-HELO: mo4-p00-ob.smtp.rzone.de Received: from mo4-p00-ob.smtp.rzone.de (HELO mo4-p00-ob.smtp.rzone.de) (81.169.146.161) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 01 Dec 2016 10:12:49 +0000 X-RZG-AUTH: :LXoWVUeid/7A29J/hMvvT3ol15ykJcYwTPLBCxG2PQt7BpWLF2I= X-RZG-CLASS-ID: mo00 Received: from [192.168.0.123] (ip5f5871bb.dynamic.kabel-deutschland.de [95.88.113.187]) by smtp.strato.de (RZmta 39.10 DYNA|AUTH) with ESMTPSA id V00b58sB1ACl0kE (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA (curve secp521r1 with 521 ECDH bits, eq. 15360 bits RSA)) (Client did not present a certificate); Thu, 1 Dec 2016 11:12:47 +0100 (CET) To: gcc-patches Cc: Denis Chertykov From: Georg-Johann Lay Subject: [avr,committed]: Use SYMBOL_REF_P if possible. Message-ID: <38c07058-45ab-93bc-044c-ca64db276e77@gjlay.de> Date: Thu, 1 Dec 2016 11:12:46 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 X-IsSubscribed: yes http://gcc.gnu.org/r243104 Use more SYMBOL_REF_P instead of SYMBOL_REF == GET_CODE (...). Committed as obvious. Johann gcc/ * config/avr/avr.c (avr_print_operand): Use SYMBOL_REF_P if possible. (avr_handle_addr_attribute, avr_asm_output_aligned_decl_common) (avr_asm_asm_output_aligned_bss, avr_addr_space_convert): Dito. Index: config/avr/avr.c =================================================================== --- config/avr/avr.c (revision 243099) +++ config/avr/avr.c (working copy) @@ -2726,7 +2726,7 @@ avr_print_operand (FILE *file, rtx x, in } else if (code == 'i') { - if (GET_CODE (x) == SYMBOL_REF && (SYMBOL_REF_FLAGS (x) & SYMBOL_FLAG_IO)) + if (SYMBOL_REF_P (x) && (SYMBOL_REF_FLAGS (x) & SYMBOL_FLAG_IO)) avr_print_operand_address (file, VOIDmode, plus_constant (HImode, x, -avr_arch->sfr_offset)); else @@ -9585,7 +9585,7 @@ avr_handle_addr_attribute (tree *node, t rtx avr_eval_addr_attrib (rtx x) { - if (GET_CODE (x) == SYMBOL_REF + if (SYMBOL_REF_P (x) && (SYMBOL_REF_FLAGS (x) & SYMBOL_FLAG_ADDRESS)) { tree decl = SYMBOL_REF_DECL (x); @@ -9896,7 +9896,7 @@ avr_asm_output_aligned_decl_common (FILE rtx symbol; if (mem != NULL_RTX && MEM_P (mem) - && GET_CODE ((symbol = XEXP (mem, 0))) == SYMBOL_REF + && SYMBOL_REF_P ((symbol = XEXP (mem, 0))) && (SYMBOL_REF_FLAGS (symbol) & (SYMBOL_FLAG_IO | SYMBOL_FLAG_ADDRESS))) { @@ -9941,7 +9941,7 @@ avr_asm_asm_output_aligned_bss (FILE *fi rtx symbol; if (mem != NULL_RTX && MEM_P (mem) - && GET_CODE ((symbol = XEXP (mem, 0))) == SYMBOL_REF + && SYMBOL_REF_P ((symbol = XEXP (mem, 0))) && (SYMBOL_REF_FLAGS (symbol) & (SYMBOL_FLAG_IO | SYMBOL_FLAG_ADDRESS))) { if (!(SYMBOL_REF_FLAGS (symbol) & SYMBOL_FLAG_ADDRESS)) @@ -12715,7 +12715,7 @@ avr_addr_space_convert (rtx src, tree ty but are located in flash. In that case we patch the incoming address space. */ - if (SYMBOL_REF == GET_CODE (sym) + if (SYMBOL_REF_P (sym) && ADDR_SPACE_FLASH == AVR_SYMBOL_GET_ADDR_SPACE (sym)) { as_from = ADDR_SPACE_FLASH;