From patchwork Wed Nov 23 15:27:47 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Wakely X-Patchwork-Id: 83697 Delivered-To: patch@linaro.org Received: by 10.140.97.165 with SMTP id m34csp2695491qge; Wed, 23 Nov 2016 07:28:22 -0800 (PST) X-Received: by 10.98.29.205 with SMTP id d196mr3343661pfd.111.1479914902784; Wed, 23 Nov 2016 07:28:22 -0800 (PST) Return-Path: Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id y66si34325800pfi.159.2016.11.23.07.28.22 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 Nov 2016 07:28:22 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-return-442396-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org; spf=pass (google.com: domain of gcc-patches-return-442396-patch=linaro.org@gcc.gnu.org designates 209.132.180.131 as permitted sender) smtp.mailfrom=gcc-patches-return-442396-patch=linaro.org@gcc.gnu.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:subject:message-id:references:mime-version:content-type :in-reply-to; q=dns; s=default; b=kMyIO2xVnBlUCXoR5uSLI2v5yS11+Q /9MCpub6GcaAnsgnIeAP+QEL5yJm21pmEixbO2N8vwEhRtYNUc+raUe0poZtJS7Q xl3iGkDPC5nd4PgATjuQ+OnPhw7IOqr4ExzRg/JJRqk484jCZ+2VepO9CxJlJkry EgRom7KT4JYnw= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:date :from:to:subject:message-id:references:mime-version:content-type :in-reply-to; s=default; bh=ghToU6o9cyVQvoX1MMCndtu+kds=; b=B/Nj SOLvXvzCzM+7DvaBHa01S/wFhi4vef4VKy4wlmxpcQ1mjP/pbP2jw3oyziacflAZ Dk0YDtmjIJL0vG/7sy9sP/FPatQ8C/3rc9yaU0g2/upfZ3eVAdHAQMtUSh6HXd9K w7kBUVsvth+pOt3Ue3YZIV54oPslCbTk7/FJoFk= Received: (qmail 49685 invoked by alias); 23 Nov 2016 15:28:01 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 49531 invoked by uid 89); 23 Nov 2016 15:28:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=BAYES_00, RP_MATCHES_RCVD, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 23 Nov 2016 15:27:50 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B0C22C04D2B1; Wed, 23 Nov 2016 15:27:48 +0000 (UTC) Received: from localhost (ovpn-116-47.ams2.redhat.com [10.36.116.47]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uANFRlff004267; Wed, 23 Nov 2016 10:27:48 -0500 Date: Wed, 23 Nov 2016 15:27:47 +0000 From: Jonathan Wakely To: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Replace unsupported effective-target with dg-options Message-ID: <20161123152747.GD3301@redhat.com> References: <20161123152543.GC3301@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20161123152543.GC3301@redhat.com> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.7.1 (2016-10-04) On 23/11/16 15:25 +0000, Jonathan Wakely wrote: >I accidentally backported tests using { target c++11 } to the branch, >but that only works on trunk. One test was also using C++14-only >features, but is meant to be valid in C++11. Also committed this version to gcc-5-branch. commit 597074d529972bde43c012a0cdca151e823224ab Author: Jonathan Wakely Date: Wed Nov 23 15:23:45 2016 +0000 Replace unsupported effective-target with dg-options * testsuite/24_iterators/reverse_iterator/71771.cc: Replace calls to C++14 std::rbegin and std::rend. Use dg-options instead of effective-target. diff --git a/libstdc++-v3/testsuite/24_iterators/reverse_iterator/71771.cc b/libstdc++-v3/testsuite/24_iterators/reverse_iterator/71771.cc index 1a7c963..b7593dd 100644 --- a/libstdc++-v3/testsuite/24_iterators/reverse_iterator/71771.cc +++ b/libstdc++-v3/testsuite/24_iterators/reverse_iterator/71771.cc @@ -15,7 +15,8 @@ // with this library; see the file COPYING3. If not see // . -// { dg-do compile { target c++11 } } +// { dg-options "-std=gnu++11" } +// { dg-do compile } #include #include @@ -38,6 +39,8 @@ test01() { int i[2]; __gnu_test::test_container - c(i); - diff2(std::rbegin(c), std::rend(c)); + c(i, i+2); + using reverse_iterator + = std::reverse_iterator<__gnu_test::bidirectional_iterator_wrapper>; + diff2(reverse_iterator(c.end()), reverse_iterator(c.begin())); }